)]}'
{"manifests/db/mysql/host_access.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4babe8369ce2369292e60e3d6e27134fea52254","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"define openstacklib::db::mysql::host_access ("},{"line_number":39,"context_line":"  $user,"},{"line_number":40,"context_line":"  $plugin \u003d undef,"},{"line_number":41,"context_line":"  $password_hash,"},{"line_number":42,"context_line":"  $database,"},{"line_number":43,"context_line":"  $privileges,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_e59132f3","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":18},"updated":"2020-03-16 12:24:04.000000000","message":"This should come after privileges so that we have optional parameters after required parameters.","commit_id":"52e78606fabe6c2feb42706010c4bf8911497b59"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"e363fbfdf11fca9631fb152325a3cb5296b8c3c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"define openstacklib::db::mysql::host_access ("},{"line_number":39,"context_line":"  $user,"},{"line_number":40,"context_line":"  $plugin \u003d undef,"},{"line_number":41,"context_line":"  $password_hash,"},{"line_number":42,"context_line":"  $database,"},{"line_number":43,"context_line":"  $privileges,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_da495ab7","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":18},"in_reply_to":"1fa4df85_e59132f3","updated":"2020-03-17 14:21:10.000000000","message":"Ack thanks will update in next revision.","commit_id":"52e78606fabe6c2feb42706010c4bf8911497b59"}],"spec/defines/openstacklib_db_mysql_host_access_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2e790be36ce9a1b7347bf9853f2d56ee626baf8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it { should contain_mysql_user(\"#{params[:user]}@10.0.0.1\").with("},{"line_number":24,"context_line":"        :plugin        \u003d\u003e nil,"},{"line_number":25,"context_line":"        :password_hash \u003d\u003e params[:password_hash],"},{"line_number":26,"context_line":"        :tls_options   \u003d\u003e [\u0027NONE\u0027]"},{"line_number":27,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df33271e_944acd7d","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":29},"updated":"2020-03-22 13:35:25.000000000","message":"I think it\u0027s actually the same but can we use \"undef\" instead ?","commit_id":"c243ae60946a3b8ac06a7a20ba0528870b08b9d6"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"42a2b0c563b82149480313b9e28b560b0795382f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it { should contain_mysql_user(\"#{params[:user]}@10.0.0.1\").with("},{"line_number":24,"context_line":"        :plugin        \u003d\u003e nil,"},{"line_number":25,"context_line":"        :password_hash \u003d\u003e params[:password_hash],"},{"line_number":26,"context_line":"        :tls_options   \u003d\u003e [\u0027NONE\u0027]"},{"line_number":27,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df33271e_fec4cf94","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":29},"in_reply_to":"df33271e_944acd7d","updated":"2020-03-23 10:21:41.000000000","message":"No we can\u0027t apparently, the ruby parser fails:\n\nSyntaxError:\n  /.../openstacklib/spec/defines/openstacklib_db_mysql_host_access_spec.rb:98: syntax error, unexpected undef\n          :plugin        \u003d\u003e undef,\n                            ^~~~~\n  /.../openstacklib/spec/defines/openstacklib_db_mysql_host_access_spec.rb:100: syntax error, unexpected \u0027)\u0027, expecting end\n        )}\n        ^\n  /.../openstacklib/spec/defines/openstacklib_db_mysql_host_access_spec.rb:136: syntax error, unexpected end, expecting end-of-input\n\nSo I mimicked what is done in openstacklib_wsgi_apache_spec.rb (e.g. field :ip), as my understanding is that an undefined parameter in puppet equals nil in ruby.","commit_id":"c243ae60946a3b8ac06a7a20ba0528870b08b9d6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a560478be4f6d36892cd565b4251c2973293160","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it { should contain_mysql_user(\"#{params[:user]}@10.0.0.1\").with("},{"line_number":24,"context_line":"        :plugin        \u003d\u003e nil,"},{"line_number":25,"context_line":"        :password_hash \u003d\u003e params[:password_hash],"},{"line_number":26,"context_line":"        :tls_options   \u003d\u003e [\u0027NONE\u0027]"},{"line_number":27,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df33271e_b44c07c8","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":29},"in_reply_to":"df33271e_fec4cf94","updated":"2020-03-25 00:22:41.000000000","message":"Thanks for clarification. understood.","commit_id":"c243ae60946a3b8ac06a7a20ba0528870b08b9d6"}]}