)]}'
{"manifests/defaults.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe0f1310ba867381926b98e287ef18b6c93b67c3","unresolved":true,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.6\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $pyvers \u003d \u0027\u0027"},{"line_number":22,"context_line":"    $pyver3 \u003d \u00272.7\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfa841c2_f7fd9efe","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":19},"updated":"2021-05-26 09:40:29.000000000","message":"I think it\u0027d be better to make $::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027 independent.\n\nAlso, please put this logic before \u003d\u003d8 as we have something like\n\n\nif Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8 {\n  # for CentOS 9\n} else Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8 {\n  # for CentOS 8\n} else {\n  # for CentOS 7\n}","commit_id":"f54b27f7647cd70dc0ba05eea2536a4ed184119e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a0e2a5d0af4fe1d004f254187f398b8142b5695a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.6\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $pyvers \u003d \u0027\u0027"},{"line_number":22,"context_line":"    $pyver3 \u003d \u00272.7\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"882bcdd0_8016a992","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"0b50cd08_14d68384","updated":"2021-05-26 10:13:44.000000000","message":"Done","commit_id":"f54b27f7647cd70dc0ba05eea2536a4ed184119e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a22901335a52fd1600fda77dbdf42d65829ba9e3","unresolved":true,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.6\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $pyvers \u003d \u0027\u0027"},{"line_number":22,"context_line":"    $pyver3 \u003d \u00272.7\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0b50cd08_14d68384","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"8138e5f7_235ebb4b","updated":"2021-05-26 10:11:50.000000000","message":"Ok updating order, may be we can keep removing fedora support as a seperate change.","commit_id":"f54b27f7647cd70dc0ba05eea2536a4ed184119e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"863cc2e6352101560b39eee78d53ecec4b3b2fe0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.6\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":20,"context_line":"  } else {"},{"line_number":21,"context_line":"    $pyvers \u003d \u0027\u0027"},{"line_number":22,"context_line":"    $pyver3 \u003d \u00272.7\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"8138e5f7_235ebb4b","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"dfa841c2_f7fd9efe","updated":"2021-05-26 10:08:25.000000000","message":"Regarding Fedora, I think we should consider removing its support seriously, considering very outdated version listed in metadata.json ...\n https://review.opendev.org/c/openstack/puppet-openstacklib/+/793134","commit_id":"f54b27f7647cd70dc0ba05eea2536a4ed184119e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4aaa1c6604b53c47280bf0e8545fcd3f664a52bc","unresolved":true,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.6\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"0e4b99c1_55e97a7d","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":37},"updated":"2021-05-26 11:02:54.000000000","message":"In current implementation this logic is never used. That is why I suggested having a separate if block for Fedora specifically.","commit_id":"bb0096eb8b7d9b532b5bb43ce50c945b09121e79"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"347815cd3f84f7865ef4daae01298104bc921716","unresolved":true,"context_lines":[{"line_number":13,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 8) {"},{"line_number":14,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":15,"context_line":"    $pyver3 \u003d \u00273.9\u0027"},{"line_number":16,"context_line":"  } elsif ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or"},{"line_number":17,"context_line":"          ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003d\u003d 8) {"},{"line_number":18,"context_line":"    $pyvers \u003d \u00273\u0027"},{"line_number":19,"context_line":"    $pyver3 \u003d \u00273.6\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8eda4d6f_c15b5590","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":37},"in_reply_to":"0e4b99c1_55e97a7d","updated":"2021-05-26 11:06:12.000000000","message":"okk adding seperate block for fedora, but likely that will not be work as it depends on fedora versions.","commit_id":"bb0096eb8b7d9b532b5bb43ce50c945b09121e79"}]}