)]}'
{"manifests/iscsi.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b5b4e765e870f2f395d3ca864e5ed9047dbda526","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstacklib::iscsi"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Installs and configures the iscsi client"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4dc6fe3f_86527d2b","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":42},"updated":"2021-06-03 15:12:33.000000000","message":"iscsid daemon","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f7b9381d8a953aee4a74929c900118cc22d14ec3","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # In CentOS9/RHEL9 initiatorname.iscsi is not created automatically"},{"line_number":33,"context_line":"  # so should be created"},{"line_number":34,"context_line":"  exec { \u0027create-initiatorname-file\u0027:"},{"line_number":35,"context_line":"    command \u003d\u003e \u0027echo \"InitiatorName\u003d`/usr/sbin/iscsi-iname`\" \u003e /etc/iscsi/initiatorname.iscsi\u0027,"},{"line_number":36,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/usr/bin\u0027],"},{"line_number":37,"context_line":"    unless  \u003d\u003e \u0027test -e /etc/iscsi/initiatorname.iscsi\u0027,"},{"line_number":38,"context_line":"    require \u003d\u003e Package[\u0027iscsi-initiator-utils\u0027],"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if $manage_service {"},{"line_number":42,"context_line":"    if $enabled {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e1e69574_bdc02944","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":3},"updated":"2021-06-03 15:15:50.000000000","message":"In centos9 there is a systemd unit iscsi-init which created this file if it doesn\u0027t exist. It\u0027s not enabled or executed by default. I decided to use this command in my patch in puppet-nova instead of using systemd iscsi-init unit because this is the only thing that iscsi-init does and i though that it\u0027s more OS agnostic and likely to work in other OSs but feel free to use what you think it\u0027s better.\n\nhttps://github.com/open-iscsi/open-iscsi/blob/master/etc/systemd/iscsi-init.service","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7043cf3971563d68a5de9d4d87964d5a84e6c793","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # In CentOS9/RHEL9 initiatorname.iscsi is not created automatically"},{"line_number":33,"context_line":"  # so should be created"},{"line_number":34,"context_line":"  exec { \u0027create-initiatorname-file\u0027:"},{"line_number":35,"context_line":"    command \u003d\u003e \u0027echo \"InitiatorName\u003d`/usr/sbin/iscsi-iname`\" \u003e /etc/iscsi/initiatorname.iscsi\u0027,"},{"line_number":36,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/usr/bin\u0027],"},{"line_number":37,"context_line":"    unless  \u003d\u003e \u0027test -e /etc/iscsi/initiatorname.iscsi\u0027,"},{"line_number":38,"context_line":"    require \u003d\u003e Package[\u0027iscsi-initiator-utils\u0027],"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if $manage_service {"},{"line_number":42,"context_line":"    if $enabled {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1d770f62_d9444d8c","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":3},"in_reply_to":"e1e69574_bdc02944","updated":"2021-06-03 15:41:47.000000000","message":"Considering that\u0027s what was implemented according to recommendation, it\u0027d be better to switch to the systemd service. My only problem is that I need to check behavior of package resource with such oneshot service... maybe we can merge this as it is now and consider replacing this by the systemd service later.","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5df3e6665b05e868df2895a9b40920e1d5d39e64","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      $service_ensure \u003d \u0027stopped\u0027"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    service { \u0027iscsi\u0027:"},{"line_number":49,"context_line":"      ensure \u003d\u003e $service_ensure,"},{"line_number":50,"context_line":"      enable \u003d\u003e $enabled,"},{"line_number":51,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dc5ff5fd_62a386ba","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":20},"updated":"2021-06-15 13:01:32.000000000","message":"iscsi or iscsid?, both exist.","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6ec445f0db07372fa177e946ef866c5ee9325554","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      $service_ensure \u003d \u0027stopped\u0027"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    service { \u0027iscsi\u0027:"},{"line_number":49,"context_line":"      ensure \u003d\u003e $service_ensure,"},{"line_number":50,"context_line":"      enable \u003d\u003e $enabled,"},{"line_number":51,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ee968143_db3e9675","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":20},"in_reply_to":"dc5ff5fd_62a386ba","updated":"2021-06-15 13:03:18.000000000","message":"Forget this comment","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e00c2f5bcd712073dd732eac43b67daaf43032c5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      $service_ensure \u003d \u0027stopped\u0027"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    service { \u0027iscsi\u0027:"},{"line_number":49,"context_line":"      ensure \u003d\u003e $service_ensure,"},{"line_number":50,"context_line":"      enable \u003d\u003e $enabled,"},{"line_number":51,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"590247eb_511ac9af","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":20},"in_reply_to":"ee968143_db3e9675","updated":"2021-06-15 13:16:54.000000000","message":"Oh wait. You are correct and this should be iscsid.","commit_id":"cacd49496a2f2b96b4fc79f0342dac4ba3487fad"}],"manifests/iscsid.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dace8c95b58f45f195aa8f7b69b10dc785b70af5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#  [*enabled*]"},{"line_number":8,"context_line":"#    (optional) Should the service be enabled."},{"line_number":9,"context_line":"#    Defaults to true."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#  [*manage_service*]"},{"line_number":12,"context_line":"#    (optional)  Whether the service should be managed by Puppet."},{"line_number":13,"context_line":"#    Defaults to true."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#  [*package_ensure*]"},{"line_number":16,"context_line":"#    (optional) ensure state for package."},{"line_number":17,"context_line":"#    Defaults to \u0027present\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstacklib::iscsid("},{"line_number":20,"context_line":"  $package_ensure \u003d \u0027present\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"059f471d_464e0f93","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":26},"updated":"2021-06-03 15:17:16.000000000","message":"Should fix the order of parameters.","commit_id":"bc00dab5650e80672288778d47c3584c97127c3c"}]}