)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"15741f47eca388397f1c206f41845c4831dc89b9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-28 14:23:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add support for purging policy rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9bb486c9191c50c11717dcb9c6af00d17c3aa8f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"34312723_452c0bd1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2021-08-09 14:29:41.000000000","message":"still wip?","commit_id":"38608dcd0b242187e84173b62dd6616a5b7429ce"}],"manifests/policy.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5bb55f0383df9214eeea19f3e2ae6882158dcf7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstacklib::policies"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This resource is an helper to call the policy definition"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters:"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bbdab1c7_9e95f247","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":58},"updated":"2021-07-26 12:35:03.000000000","message":"The plan is to use this instead of openstacklib::policies::base in each puppet modules then we can use this common implementation in all modules.","commit_id":"2e38edad9cd596a5916f1a8ca478b5032b793669"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c1de03a4a1fbe53ef66dc346972647887c282b15","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if empty($policies) {"},{"line_number":47,"context_line":"    create_resources(\u0027openstacklib::policy::default\u0027, { $policy_path \u003d\u003e {"},{"line_number":48,"context_line":"      file_mode    \u003d\u003e $file_mode,"},{"line_number":49,"context_line":"      file_user    \u003d\u003e $file_user,"},{"line_number":50,"context_line":"      file_group   \u003d\u003e $file_group,"},{"line_number":51,"context_line":"      file_format  \u003d\u003e $file_format,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c7d18f09_a6150eeb","line":48,"updated":"2021-07-27 08:48:04.000000000","message":"we also need to pass file_path    \u003d\u003e $policy_path,","commit_id":"2e38edad9cd596a5916f1a8ca478b5032b793669"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d294dae19507b9491ad46c02a1dfff432b7c858c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstacklib::policies"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This resource is an helper to call the policy definition"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"c21aa0ff_f1b31af3","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":10},"updated":"2021-07-27 23:47:42.000000000","message":"Oops. This is not a resource type but a class. We need to implement a resource type independently.","commit_id":"d70d4a798138449cfa549fd2611f409e0e5c2c7b"}],"spec/defines/openstacklib_policy_base_spec.rb":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fd3ce2f28e2c3e20275b392ef2c19bcbdd72d38c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      it { should contain_openstacklib__policy__default(\u0027/etc/nova/policy.json\u0027).with("},{"line_number":23,"context_line":"        :file_mode    \u003d\u003e \u00270644\u0027,"},{"line_number":24,"context_line":"        :file_user    \u003d\u003e \u0027foo\u0027,"},{"line_number":25,"context_line":"        :file_group   \u003d\u003e \u0027baa\u0027,"},{"line_number":26,"context_line":"        :file_format  \u003d\u003e \u0027json\u0027,"},{"line_number":27,"context_line":"        :purge_config \u003d\u003e false,"},{"line_number":28,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"7e3e94af_d1175091","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":30},"updated":"2021-07-28 09:51:21.000000000","message":"Is \u0027baa\u0027 intended, as you set above the param to bar?","commit_id":"95374ca14897ea7c54d5ba8f8d1e1c2769e5bdc0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e365ba053c6d87e01a3ac8c7fe945b327200dfbb","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      it { should contain_openstacklib__policy__default(\u0027/etc/nova/policy.json\u0027).with("},{"line_number":23,"context_line":"        :file_mode    \u003d\u003e \u00270644\u0027,"},{"line_number":24,"context_line":"        :file_user    \u003d\u003e \u0027foo\u0027,"},{"line_number":25,"context_line":"        :file_group   \u003d\u003e \u0027baa\u0027,"},{"line_number":26,"context_line":"        :file_format  \u003d\u003e \u0027json\u0027,"},{"line_number":27,"context_line":"        :purge_config \u003d\u003e false,"},{"line_number":28,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"c3e52b4d_e5de8a8f","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":30},"in_reply_to":"7e3e94af_d1175091","updated":"2021-07-28 14:24:32.000000000","message":"No. Sorry but that is just my typo...","commit_id":"95374ca14897ea7c54d5ba8f8d1e1c2769e5bdc0"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"0160880f3a78b72de4353ee209d01660d7acad34","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      it { should contain_openstacklib__policy__default(\u0027/etc/nova/policy.json\u0027).with("},{"line_number":23,"context_line":"        :file_mode    \u003d\u003e \u00270644\u0027,"},{"line_number":24,"context_line":"        :file_user    \u003d\u003e \u0027foo\u0027,"},{"line_number":25,"context_line":"        :file_group   \u003d\u003e \u0027baa\u0027,"},{"line_number":26,"context_line":"        :file_format  \u003d\u003e \u0027json\u0027,"},{"line_number":27,"context_line":"        :purge_config \u003d\u003e false,"},{"line_number":28,"context_line":"      )}"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"790fff73_dfc6a40e","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":30},"in_reply_to":"c3e52b4d_e5de8a8f","updated":"2021-07-29 05:54:04.000000000","message":"ack, no worries. Thanks for clarification","commit_id":"95374ca14897ea7c54d5ba8f8d1e1c2769e5bdc0"}],"spec/defines/openstacklib_policy_default_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d32dff7b218eaab9c2d6c3ae6b223c54705bdb3f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        :group   \u003d\u003e \u0027bar\u0027,"},{"line_number":70,"context_line":"        :content \u003d\u003e \u0027\u0027,"},{"line_number":71,"context_line":"        :replace \u003d\u003e true"},{"line_number":72,"context_line":"      )} "},{"line_number":73,"context_line":"    end"},{"line_number":74,"context_line":"  end"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ec2d7e2c_cebec80a","line":72,"updated":"2021-08-10 14:26:38.000000000","message":"nit: trailing space","commit_id":"2a53c66ed3e4ae6b1907d824915a59c175eb0258"}]}