)]}'
{"id":"openstack%2Fpuppet-openstacklib~810982","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fwallaby~I4cad8f88fc7b67bb7aa4330832fc47bac41ae9df","project":"openstack/puppet-openstacklib","branch":"stable/wallaby","hashtags":[],"change_id":"I4cad8f88fc7b67bb7aa4330832fc47bac41ae9df","subject":"Prevent --password from leaking in failed command output","status":"MERGED","created":"2021-09-27 07:25:06.000000000","updated":"2021-09-27 18:06:21.000000000","submitted":"2021-09-27 18:06:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"810982","cherry_pick_of_change":810215,"cherry_pick_of_patch_set":10,"meta_rev_id":"b85b0d56e0f244235d0820451501e087774b3f76","_number":810982,"virtual_id_number":810982,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-27 18:06:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-09-27 12:11:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2021-09-27 15:48:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":1,"date":"2021-09-27 15:48:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 09:18:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-27 12:11:42.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2021-09-27 15:48:47.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"}],"messages":[{"id":"487df3f31de1390a0f4e6fd8a1dad61226fbe727","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-09-27 07:25:06.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"667661705d269e68b51a41f5f7d68c9bf5f7a841","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 09:18:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c07e579ae42d47abbe866d7ee9ba4c1b : SUCCESS in 3m 56s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/670e3ec195b1411a83bac7d6a1510d9a : SUCCESS in 3m 46s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/f2b8ba22eeee4db1a0d6476ac8bf0850 : SUCCESS in 10m 19s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7521a7f856624fc492a82ac474faa7e7 : SUCCESS in 9m 21s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5a7107790e0b4ed4bc508297ec7a7a49 : SUCCESS in 8m 10s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6562d5d0c2ab488badbb389d51d968fd : FAILURE in 42m 32s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0c01576c4e0f47ed8d998aa85f32abb9 : SUCCESS in 55m 27s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ff5ef3c39694499ca71787eba68aacc5 : FAILURE in 28m 06s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dee895c223db4a65abc48d6cf9f4a72e : SUCCESS in 36m 18s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/255987f7df324dc081c6f801b56b8323 : SUCCESS in 1h 15m 37s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/06fd7f83d282465b8beb3a018048780e : SUCCESS in 1h 46m 10s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/dd2986a906d94815858801b8887f5973 : SUCCESS in 1h 21m 55s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ff811be3519f4211aafc140f7dc5aff2 : SUCCESS in 58m 09s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/d10551e7f36c4205a2105c26e36a3f8c : SUCCESS in 15m 53s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/71b522bc6aac4464b0010b7517ced169 : FAILURE in 11m 37s (non-voting)\n- puppet-openstacklib-tripleo-standalone https://zuul.opendev.org/t/openstack/build/0709756eeeb848968535da65686266af : SUCCESS in 1h 51m 40s","accounts_in_message":[],"_revision_number":1},{"id":"d97549b226fe98ff9dffd63faeb3c1fa340f72c7","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-09-27 12:11:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"66c785843012fc3ba0bf9532e7b64f8412a4bba0","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-09-27 15:48:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f9e3e10dac3a3f3438e5065aa222fb7775c22c75","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 15:51:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7b4f0899b2e8937d766dea4bcb8bd1ec66e0f886","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 18:06:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b8d780bbbff8447686879f43155bc055 : SUCCESS in 4m 39s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b6afb237aaf94ba9914765c906b7ee07 : SUCCESS in 4m 42s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/3de5ff92a1984850a98cea573979a66b : SUCCESS in 14m 08s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3cd3db3b332e4e1794e9b84b3910e984 : SUCCESS in 10m 56s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/d7eac3fe6b0246d2be386fa7d0de60bf : SUCCESS in 1h 12m 12s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/2d7352f7b85c491193e1890031183a2e : SUCCESS in 1h 17m 08s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a5101095d68b4c8a95debf25529e19d0 : SUCCESS in 1h 20m 43s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/5800dca15d8f4254b3141cbae00c6d01 : SUCCESS in 58m 33s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/2ad2104dce3f4ef7b8ee3564027b08a8 : SUCCESS in 19m 38s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/46b8bf121a274fcd928aae814b6df505 : FAILURE in 11m 03s (non-voting)\n- puppet-openstacklib-tripleo-standalone https://zuul.opendev.org/t/openstack/build/92e1376a2b024c1580d63afe75396250 : SUCCESS in 2h 11m 10s","accounts_in_message":[],"_revision_number":1},{"id":"b85b0d56e0f244235d0820451501e087774b3f76","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 18:06:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fa7ce171e6be4202ba933569fec3c6dc17aa4b4b","revisions":{"fa7ce171e6be4202ba933569fec3c6dc17aa4b4b":{"kind":"REWORK","_number":1,"created":"2021-09-27 07:25:06.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/82/810982/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/82/810982/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/82/810982/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/82/810982/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/82/810982/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/82/810982/1"}}},"commit":{"parents":[{"commit":"f022f26afd4a2bff0c03301a6d21aad60f0ccb32","subject":"Set fixture paths for unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f022f26afd4a2bff0c03301a6d21aad60f0ccb32"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-09-21 12:13:32.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.com","date":"2021-09-27 07:25:06.000000000","tz":0},"subject":"Prevent --password from leaking in failed command output","message":"Prevent --password from leaking in failed command output\n\nThere is cases when a command times out or when it fails\nthat we and Puppet [1] will output the raw command that\nwas executed.\n\nFor a user create command that output contains the\n--password argument passed down to openstack CLI which\ncauses sensitive passwords to be leaked into log files\nof the system executing Puppet, these can then be shipped\nof from the system into a remote syslog and still be in\nplain text.\n\nThis tries to use Ruby gsub with a regular expression\nmatching the two cases and instead output [redacted secret]\nthe same way we do with config provider.\n\n[1] https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/execution.rb#L286\n\nChange-Id: I4cad8f88fc7b67bb7aa4330832fc47bac41ae9df\n(cherry picked from commit 16ce2f30de42b1fcec55a58d24b3de346e1f9353)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/fa7ce171e6be4202ba933569fec3c6dc17aa4b4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/fa7ce171e6be4202ba933569fec3c6dc17aa4b4b"}]},"parents_data":[{"branch_name":"refs/heads/stable/wallaby","commit_id":"f022f26afd4a2bff0c03301a6d21aad60f0ccb32","is_merged_in_target_branch":false,"change_id":"Id2e226593fa9005e8c051bb714e4c341114f640f","change_number":794419,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}