)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c4d80edb6e97e1296380bba2965663a1c6bbc3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"125e19af_eb9e11ab","updated":"2022-03-03 10:42:37.000000000","message":"LGTM","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ca84bee0df780a3cf8691edeabc51295a0bfb66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"819a3c53_7bd47aef","updated":"2022-02-15 00:02:41.000000000","message":"ok","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"}],"lib/puppet/provider/openstack/auth.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3579f635305459da8f893f1db37f75598113c2da","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    # This allows overrides by users"},{"line_number":10,"context_line":"    \"/etc/openstack/puppet/clouds.yaml\","},{"line_number":11,"context_line":"    # This is created by puppet-keystone"},{"line_number":12,"context_line":"    \"/etc/openstack/puppet/admin-clouds.yaml\","},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  def get_os_vars_from_env"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"82964d89_4e20e7ca","line":12,"updated":"2022-02-14 18:02:38.000000000","message":"should we fall back to /etc/openstack/clouds.yaml which is usually the default?","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2afaec6ef75a12bae2beeea876164fb0ff34c4c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    # This allows overrides by users"},{"line_number":10,"context_line":"    \"/etc/openstack/puppet/clouds.yaml\","},{"line_number":11,"context_line":"    # This is created by puppet-keystone"},{"line_number":12,"context_line":"    \"/etc/openstack/puppet/admin-clouds.yaml\","},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  def get_os_vars_from_env"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"362d46c1_b7f00d59","line":12,"in_reply_to":"6bf18b3d_66a8236a","updated":"2022-02-21 16:42:53.000000000","message":"Done","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c51f0e75aee4b0d6b26abf5097956cc92cb0f6be","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    # This allows overrides by users"},{"line_number":10,"context_line":"    \"/etc/openstack/puppet/clouds.yaml\","},{"line_number":11,"context_line":"    # This is created by puppet-keystone"},{"line_number":12,"context_line":"    \"/etc/openstack/puppet/admin-clouds.yaml\","},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  def get_os_vars_from_env"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"6bf18b3d_66a8236a","line":12,"in_reply_to":"82964d89_4e20e7ca","updated":"2022-02-14 23:18:58.000000000","message":"I\u0027d avoid it because\n\n- the file requires specific cloud names(project and system)\n\n- It\u0027d cause unexpected results(or failure) if a user has created the file.","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c4b700841d7010689a2e6f1a6556ba8f119858fa","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    unless @credentials.set? and (!@credentials.scope_set? or @credentials.scope \u003d\u003d scope)"},{"line_number":65,"context_line":"      # Then look for clouds.yaml"},{"line_number":66,"context_line":"      @credentials.unset"},{"line_number":67,"context_line":"      clouds_env \u003d get_os_vars_from_cloudsfile(scope)"},{"line_number":68,"context_line":"      if ! clouds_env.empty?"},{"line_number":69,"context_line":"        set_credentials(@credentials, clouds_env)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"b98c998b_7c56b0c8","line":66,"updated":"2022-02-11 14:34:44.000000000","message":"isn\u0027t unless @credentials.set? assumes the credentials are not set? why to unset it again?","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5910b02e6f6c25621f68803dec4cd07321146f24","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    unless @credentials.set? and (!@credentials.scope_set? or @credentials.scope \u003d\u003d scope)"},{"line_number":65,"context_line":"      # Then look for clouds.yaml"},{"line_number":66,"context_line":"      @credentials.unset"},{"line_number":67,"context_line":"      clouds_env \u003d get_os_vars_from_cloudsfile(scope)"},{"line_number":68,"context_line":"      if ! clouds_env.empty?"},{"line_number":69,"context_line":"        set_credentials(@credentials, clouds_env)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a93373e_31d15ebe","line":66,"in_reply_to":"720b5bf0_0a32a372","updated":"2022-02-11 14:40:13.000000000","message":"Done","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"19d05a4184794c4e49eabc3448fddba7bd9479d3","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    unless @credentials.set? and (!@credentials.scope_set? or @credentials.scope \u003d\u003d scope)"},{"line_number":65,"context_line":"      # Then look for clouds.yaml"},{"line_number":66,"context_line":"      @credentials.unset"},{"line_number":67,"context_line":"      clouds_env \u003d get_os_vars_from_cloudsfile(scope)"},{"line_number":68,"context_line":"      if ! clouds_env.empty?"},{"line_number":69,"context_line":"        set_credentials(@credentials, clouds_env)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"720b5bf0_0a32a372","line":66,"in_reply_to":"b98c998b_7c56b0c8","updated":"2022-02-11 14:37:24.000000000","message":"This is to ensure incomplete parameters set by L64 are cleared.","commit_id":"08bf393ee48723cd344ff5bce37843c41878914c"}]}