)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1a66318af54537887abb46afd38ec420db762296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"720bae9c_7f1f5d75","updated":"2022-03-15 08:16:25.000000000","message":"well done","commit_id":"b645bfb709c77bf2a3b21f93a6f591b6fcb45fba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2825be7de8cca767911a713ae734c268a97c95c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f01626b_3417d9d0","updated":"2022-03-15 16:07:21.000000000","message":"I\u0027m still wondering how beneficial to have this new function.\n\nThe current implementation results in having two similar but incomplete functions.\n\ninet6_prefix\n - works for ipv4/ipv6 when ip is used\n - works for ipv4 when hostname is used\n\ninet6_prefix_any\n - works for ipv4/ipv6 when ip is used\n - works for ipv6 when hostname is used","commit_id":"5ac380f3fa5f0322c7752e6bbeca48e0ef81a6bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4769aa8518feb26d018795729d3bf1c91ac7f11c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd3b25f2_3553900c","in_reply_to":"1bea6615_095dfd74","updated":"2022-03-17 14:37:01.000000000","message":"I\u0027ve drafted a potential solution to introduce such flag with backward compatibility kept.\n https://review.opendev.org/c/openstack/puppet-openstacklib/+/834175","commit_id":"5ac380f3fa5f0322c7752e6bbeca48e0ef81a6bf"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0e8aa94bbcf328974d23b66722e46ad53e52688","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1bea6615_095dfd74","in_reply_to":"5f01626b_3417d9d0","updated":"2022-03-15 16:31:34.000000000","message":"Right, it would be nice to have one that could handle both.\n\nWhile I kind of like the idea of using resolve as done in your patch, it would not work in case puppet runs in some build system which cannot resolve the names.\n\nIf we could have inet6_prefix have a kw argument like (list, prefix_hostname\u003dTrue) Not sure if that would be possible without breaking bacward compatibility.","commit_id":"5ac380f3fa5f0322c7752e6bbeca48e0ef81a6bf"}],"lib/puppet/functions/inet6_prefix_any.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2825be7de8cca767911a713ae734c268a97c95c9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    args \u003d [args] unless args.kind_of?(Array)"},{"line_number":25,"context_line":"    args.each do |x|"},{"line_number":26,"context_line":"      unless not x or x.match(/^inet6:.+/)"},{"line_number":27,"context_line":"        # If entry is IPv4 address, don\u0027t add inet6 prefix"},{"line_number":28,"context_line":"        begin"},{"line_number":29,"context_line":"          if IPAddr.new(x).ipv4? then"},{"line_number":30,"context_line":"            result \u003c\u003c x"},{"line_number":31,"context_line":"            next"},{"line_number":32,"context_line":"          end"},{"line_number":33,"context_line":"        rescue *exp"},{"line_number":34,"context_line":"          # Ignore exception"},{"line_number":35,"context_line":"        end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # If entry is IPv6 address, bracket it before continuing"},{"line_number":38,"context_line":"        begin"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"2436892f_f25798ec","line":35,"range":{"start_line":27,"start_character":0,"end_line":35,"end_character":11},"updated":"2022-03-15 16:07:21.000000000","message":"We should not do this if we name this function as _any.","commit_id":"5ac380f3fa5f0322c7752e6bbeca48e0ef81a6bf"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0e8aa94bbcf328974d23b66722e46ad53e52688","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    args \u003d [args] unless args.kind_of?(Array)"},{"line_number":25,"context_line":"    args.each do |x|"},{"line_number":26,"context_line":"      unless not x or x.match(/^inet6:.+/)"},{"line_number":27,"context_line":"        # If entry is IPv4 address, don\u0027t add inet6 prefix"},{"line_number":28,"context_line":"        begin"},{"line_number":29,"context_line":"          if IPAddr.new(x).ipv4? then"},{"line_number":30,"context_line":"            result \u003c\u003c x"},{"line_number":31,"context_line":"            next"},{"line_number":32,"context_line":"          end"},{"line_number":33,"context_line":"        rescue *exp"},{"line_number":34,"context_line":"          # Ignore exception"},{"line_number":35,"context_line":"        end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # If entry is IPv6 address, bracket it before continuing"},{"line_number":38,"context_line":"        begin"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"84639451_83563d90","line":35,"range":{"start_line":27,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"2436892f_f25798ec","updated":"2022-03-15 16:31:34.000000000","message":"I agree.","commit_id":"5ac380f3fa5f0322c7752e6bbeca48e0ef81a6bf"}],"spec/functions/inet6_prefix_any_spec.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1a66318af54537887abb46afd38ec420db762296","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  it { should run.with_params(\u0027foo.example.com:11211\u0027, \u0027bar.example.com:11211\u0027).and_return([\u0027inet6:[foo.example.com]:11211\u0027, \u0027inet6:[bar.example.com]:11211\u0027])}"},{"line_number":13,"context_line":"  it { should run.with_params([\u0027foo.example.com:11211\u0027, \u0027bar.example.com:11211\u0027]).and_return([\u0027inet6:[foo.example.com]:11211\u0027, \u0027inet6:[bar.example.com]:11211\u0027])}"},{"line_number":14,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":15,"context_line":"  it { should run.with_params(\u0027::1\u0027).and_return(\u0027inet6:[:]:1\u0027)}"},{"line_number":16,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":17,"context_line":"  it { should run.with_params(\u0027127.0.0.1\u0027).and_return(\u0027inet6:[127.0.0.1]\u0027)}"},{"line_number":18,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"e556a474_2f389d88","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":61},"updated":"2022-03-15 08:16:25.000000000","message":"shouldn\u0027t it be inet6:[::1]","commit_id":"b645bfb709c77bf2a3b21f93a6f591b6fcb45fba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d7aeec71c3ad18fef415545c2a2cd61d5c54f15b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  it { should run.with_params(\u0027foo.example.com:11211\u0027, \u0027bar.example.com:11211\u0027).and_return([\u0027inet6:[foo.example.com]:11211\u0027, \u0027inet6:[bar.example.com]:11211\u0027])}"},{"line_number":13,"context_line":"  it { should run.with_params([\u0027foo.example.com:11211\u0027, \u0027bar.example.com:11211\u0027]).and_return([\u0027inet6:[foo.example.com]:11211\u0027, \u0027inet6:[bar.example.com]:11211\u0027])}"},{"line_number":14,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":15,"context_line":"  it { should run.with_params(\u0027::1\u0027).and_return(\u0027inet6:[:]:1\u0027)}"},{"line_number":16,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":17,"context_line":"  it { should run.with_params(\u0027127.0.0.1\u0027).and_return(\u0027inet6:[127.0.0.1]\u0027)}"},{"line_number":18,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"2682dfab_38ea8e90","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":61},"in_reply_to":"e556a474_2f389d88","updated":"2022-03-15 09:15:49.000000000","message":"Done","commit_id":"b645bfb709c77bf2a3b21f93a6f591b6fcb45fba"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8bcc4264aae0f5708cfac09f8f611b775517232f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":15,"context_line":"  it { should run.with_params(\u0027::1\u0027).and_return(\u0027inet6:[:]:1\u0027)}"},{"line_number":16,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":17,"context_line":"  it { should run.with_params(\u0027127.0.0.1\u0027).and_return(\u0027inet6:[127.0.0.1]\u0027)}"},{"line_number":18,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7f57c2e5_59ee9396","line":17,"updated":"2022-03-15 08:18:19.000000000","message":"there is https://ruby-doc.org/stdlib-2.5.1/libdoc/ipaddr/rdoc/IPAddr.html#method-i-ipv6-3F, but would require ipaddr gem","commit_id":"b645bfb709c77bf2a3b21f93a6f591b6fcb45fba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d7aeec71c3ad18fef415545c2a2cd61d5c54f15b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":15,"context_line":"  it { should run.with_params(\u0027::1\u0027).and_return(\u0027inet6:[:]:1\u0027)}"},{"line_number":16,"context_line":"  # Passing a non wrapped IPv6 address will give INVALID result"},{"line_number":17,"context_line":"  it { should run.with_params(\u0027127.0.0.1\u0027).and_return(\u0027inet6:[127.0.0.1]\u0027)}"},{"line_number":18,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"b18afa4c_eea4a263","line":17,"in_reply_to":"7f57c2e5_59ee9396","updated":"2022-03-15 09:15:49.000000000","message":"Done","commit_id":"b645bfb709c77bf2a3b21f93a6f591b6fcb45fba"}]}