)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5299afdf97ab057a055e07c072ca229e56181773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f8927852_28895d95","updated":"2022-07-30 21:21:04.000000000","message":"Here\u0027s some background info. I tripped across the problem late in the day last Friday when I did a local standalone tripleo build from master, and got this puppet-apache package:\n\nName         : puppet-apache\nVersion      : 7.0.1\nRelease      : 0.20220729113326.fd2360d.el9\nArchitecture : src\nSize         : 412 k\nSource       : None\nRepository   : delorean-component-tripleo\nSummary      : Installs, configures, and manages Apache virtual hosts, web services, and modules.\nURL          : https://github.com/puppetlabs/puppetlabs-apache\nLicense      : ASL 2.0\nDescription  : Installs, configures, and manages Apache virtual hosts, web services, and modules.\n\nNotice that it\u0027s marked v7.0.1, with date code 20220729 (also Friday). This version includes the \"narrow down datatypes\" that broke my deployment.\n\nLooking further, puppetlabs has not tagged a 7.0.1 release, so this is directly off their master. But this patch\u0027s unit tests are failing because our puppet-openstack-integration is pinning puppet-apache at v7.0.0 [1].\n\n[1] https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L159\n\nThe tests fail because the puppetlabs-apache module doesn\u0027t include the \"narrow down datatypes\" patch, and is passing in \u0027false\u0027 for the access_log_XXX parameters.\n\nBTW, it might be interesting to explore adding code to this module that basically converts null values for those parameters to undef. That might alleviate the need (at least in the short term) to update all those other openstack puppet modules that still default the parameters to False.\n","commit_id":"0d8aef6b1a8d761ca0f8decad47022daa38a4110"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"78ba875661d3115018bfea0309751307bf87e562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1a5ec5a_a833245d","in_reply_to":"2e2fa4fd_dea26b86","updated":"2022-08-02 12:46:45.000000000","message":"I\u0027ll unblock this now so that we can get the other patches.\n\nWe can consider implementing transitional logic but I\u0027d leave it now because dealing with underlying breaking change is something out of our scope and we don\u0027t really want to bump version required for that.\nThis change is compatible with the existing releases (\u003c\u003d 7.0.0), and users should update the values according to the requirement by puppetlabs-apache.\n\nI\u0027ll be open for this topic and am happy to discuss what we want in our modules. Even if we implement the logic, we can do it as a follow-up, I think.","commit_id":"0d8aef6b1a8d761ca0f8decad47022daa38a4110"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"06c8b2053cf4d99a67e9cd96b30b9a3618ec20cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6e98b48_8d67968b","in_reply_to":"2e2fa4fd_dea26b86","updated":"2022-08-02 12:36:24.000000000","message":"Seems like the cause is that RDO pulled in puppetlabs/apache and built puppet-apache from main branch.\n\nAnyway, this makes sense, but I understand the issue here that we might need to bump minimal puppetlabs/apache version for the default values, or people need to fix the param values they provide.\n\nI think it makes sense to change the default values, if we 1) bump the minimum version and 2) DONT enforce the values ourselves that way we\u0027ll support both usecases but favor running something newer.","commit_id":"0d8aef6b1a8d761ca0f8decad47022daa38a4110"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b2f2e98ad292553976dc89e052f1267b14e86f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3c7718e_4fc5f2c8","in_reply_to":"d1a5ec5a_a833245d","updated":"2022-08-02 12:54:35.000000000","message":"Oops. I should have reloaded the page before I post my comment.\n\n\u003e Anyway, this makes sense, but I understand the issue here that we might need to bump minimal puppetlabs/apache version for the default values\n\nThe new default values I\u0027m using here are compatible with the existing versions (7.0.0 and older), and do not cause any functional change in underlying logic. puppetlabs-apache has been supporting integer priority and access_log_* set to undef and it has been behaving same manner with string priority and access_log_* set to false\n\nThe only things affected by version bump of puppetlabs-apache are the unit tests effectively asserting defaults in apache::vhost but I don\u0027t really think we want to make our unit tests compatible with all versions we support as unit tests are mostly for our development purpose.","commit_id":"0d8aef6b1a8d761ca0f8decad47022daa38a4110"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dfffaf4caf6fc6391c69b698930832066c31ac91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e2fa4fd_dea26b86","in_reply_to":"f8927852_28895d95","updated":"2022-08-02 05:43:59.000000000","message":"Thanks for these inputs, Alan.\n\nI\u0027ll take time to reconsider implementing the workaround logic here while I\u0027m drafting the fix in a few modules.\n\nMy initial thought was that it\u0027s a kind of over-killing for us to deal with the broken compatibility in our module but it might be helpful later in case anybody tries to use stable release with newer puppetlabs-apache (as we can backport it to stable branches), as we have never declared upper version explicitly.","commit_id":"0d8aef6b1a8d761ca0f8decad47022daa38a4110"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9fb042a7ae6ccef6ba7842a3e3a2490da8dfc8f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cb2c771_f577ad4c","updated":"2022-08-02 14:11:25.000000000","message":"It sounds like we have a plan.","commit_id":"8334afc2a6967093e061cf605e087777a594ee03"}]}