)]}'
{"id":"openstack%2Fpuppet-openstacklib~852690","triplet_id":"openstack%2Fpuppet-openstacklib~master~I7bbe54972143bd51e41f73ccc838fd222788b08d","project":"openstack/puppet-openstacklib","branch":"master","topic":"bug/1983300","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2022-08-12 07:09:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7bbe54972143bd51e41f73ccc838fd222788b08d","subject":"Stop testing underlying default in puppetlabs-apache","status":"MERGED","created":"2022-08-10 02:40:44.000000000","updated":"2022-08-12 07:09:18.000000000","submitted":"2022-08-12 07:09:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"852690-bug/1983300","meta_rev_id":"071ba5e6e0583c7f169558b5b3a0b27778d61e6e","_number":852690,"virtual_id_number":852690,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-12 07:09:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":2,"date":"2022-08-10 14:28:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2022-08-12 06:36:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2022-08-12 06:36:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-10 03:02:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-10 14:28:38.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2022-08-12 06:36:26.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"ab4ccea5b27763fbf042f02a4267b13f4fe89bb5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 02:40:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1bb61b3cb389032b428ad5053646023a490f749b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 02:40:58.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bb65111015ed871f544bdb135bd869b70b53a96e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 03:02:27.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/6673a61b1b5b4f4c9d96926bf4456d07\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6497d62b7f2545e0aeaa150ae46d9ee9 : SUCCESS in 3m 52s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2d5e8550f6774473ab57414eeab024b7 : SUCCESS in 4m 05s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/249bed166605440290e09146a667444e : SUCCESS in 4m 06s\n- puppet-openstack-unit-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/45cb1bf7ecd14e598fdac1cfca7c77d3 : FAILURE in 16m 23s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c462cae6885b47cb93ca5925fd36f7af : FAILURE in 11m 44s\n- puppet-openstack-unit-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/913b19b0f4834d75aaa01b7cb899c166 : FAILURE in 13m 20s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1d7ce84cce514ad0a943f206bb8f18e9 : FAILURE in 13m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1f7efcd3ef8c864bb6269bf22b4440a2a226e3ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 03:51:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"311621380a32e0d0cff63ae4f4d7815fac5cc2ea","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 04:10:58.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/c00677039ee74f47aa7e021df66c1f9f\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0e8006f770004bd4995f34713a9ba785 : SUCCESS in 3m 50s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/809612b0de6149cdac293e8138b389b5 : SUCCESS in 3m 54s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0cd26d02ff9a4f4ca3bf1300b7f791c2 : SUCCESS in 3m 39s\n- puppet-openstack-unit-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/3fed9007c5bd4d6cae81bda5bfd83ca3 : FAILURE in 14m 42s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9468779e60a04ba5916ae6b40822a02b : FAILURE in 10m 22s\n- puppet-openstack-unit-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2bf36bb4c5734456a417927047f48e5a : FAILURE in 10m 10s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9e64e5ea77fc4fecb678e54d33a5e712 : FAILURE in 9m 28s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"625f7e6be658a812ec3bffc0027519b822819139","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 07:47:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"684caca236fa5cd5056b4ef8a6147ac15e091f63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 07:51:41.000000000","message":"Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4.","accounts_in_message":[],"_revision_number":5},{"id":"85898332f804ea1a7872a92f2f0c2ce9ba1ac0e3","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-10 07:53:02.000000000","message":"Topic set to bug/1983300","accounts_in_message":[],"_revision_number":5},{"id":"446a9f89c324721525ca32610127136d934cb6e5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 08:24:38.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f17b79bf036641b0beceb7b9148e1ab0\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d37a8c6dfda44afbbfbf75f720ca9a3d : SUCCESS in 3m 05s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/870b33281d174055b38decbf146fdd61 : SUCCESS in 5m 24s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/54974b0e1ac6401394e6714b3f142c3f : SUCCESS in 5m 22s\n- puppet-openstack-unit-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/10d36ca737a043e1aa644703ebcf8b04 : SUCCESS in 22m 54s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/4e80c2216e4345089d21adaf1231320c : SUCCESS in 18m 18s\n- puppet-openstack-unit-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fa8ad728d5614c1db198e62152d14f09 : SUCCESS in 18m 04s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ddd2e41db08c448884258491ed584fbd : SUCCESS in 17m 47s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"c9c91daffb6310d9f85aaa49c1ae98e1ea41c584","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2022-08-10 14:28:38.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"3d48860e22a0bf77445d9ad93b06c3ad0d022314","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2022-08-12 06:36:26.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"11d5fa26397a49e78a82f0629d07a5ad4b211f28","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-12 06:37:29.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"5a9e4a0799e3626731f0874f1bad4d5f40962a6e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-12 07:09:18.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/49e8be29d1ac466a8a4cd84b537bff4d\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/de5ff20390e14ec0b23f610a6da341e3 : SUCCESS in 5m 17s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a70f13d983a945cd885dbe53b34cf76e : SUCCESS in 5m 27s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/64b980484088489fa3f526c5337b14ff : SUCCESS in 5m 37s\n- puppet-openstack-unit-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/f45388c7c1ee4499851cc3a2b4d40039 : SUCCESS in 24m 32s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/40f5aebd1b21440d88f04898ac75d893 : SUCCESS in 18m 52s\n- puppet-openstack-unit-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/087b533c24b8434e91e0a903937bec86 : SUCCESS in 18m 39s","accounts_in_message":[],"_revision_number":5},{"id":"071ba5e6e0583c7f169558b5b3a0b27778d61e6e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-12 07:09:18.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"ba19e6dbd30fcd931d78877d4e262fbd2e3d1da1","revisions":{"67da4eebf3ee4443e5633dd8e64529b87a602af7":{"kind":"REWORK","_number":1,"created":"2022-08-10 02:40:44.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/90/852690/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/852690/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/1"}}},"commit":{"parents":[{"commit":"81af4a04761b270609f4f356484fdb61f3505688","subject":"Merge \"Adapt to new type validation in puppetlabs-apache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/81af4a04761b270609f4f356484fdb61f3505688"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"subject":"Update unit tests to adapt to new puppetlabs-apache","message":"Update unit tests to adapt to new puppetlabs-apache\n\nSome default values have been updated in the latest puppetlabs-apache\nv8.0.0 release. This change updates unit tests to adapts to the new\ndefaults.\n\nDepends-on: https://review.opendev.org/852689\nChange-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d\nRelated-Bug: #1983300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/67da4eebf3ee4443e5633dd8e64529b87a602af7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/67da4eebf3ee4443e5633dd8e64529b87a602af7"}]},"branch":"refs/heads/master"},"10c28607e257ca729bda1de3f5301c8b9a1dcbbf":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-08-10 02:40:58.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/90/852690/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/852690/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/2"}}},"commit":{"parents":[{"commit":"81af4a04761b270609f4f356484fdb61f3505688","subject":"Merge \"Adapt to new type validation in puppetlabs-apache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/81af4a04761b270609f4f356484fdb61f3505688"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:40:47.000000000","tz":540},"subject":"Update unit tests to adapt to new puppetlabs-apache","message":"Update unit tests to adapt to new puppetlabs-apache\n\nSome default values have been updated in the latest puppetlabs-apache\nv8.0.0 release. This change updates unit tests to adapts to the new\ndefaults.\n\nRelated-Bug: #1983300\nDepends-on: https://review.opendev.org/852689\nChange-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/10c28607e257ca729bda1de3f5301c8b9a1dcbbf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/10c28607e257ca729bda1de3f5301c8b9a1dcbbf"}]},"branch":"refs/heads/master"},"0f1ccc96888ae79f49fa85748c09fa950832e544":{"kind":"REWORK","_number":3,"created":"2022-08-10 03:51:33.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/90/852690/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/852690/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/3"}}},"commit":{"parents":[{"commit":"81af4a04761b270609f4f356484fdb61f3505688","subject":"Merge \"Adapt to new type validation in puppetlabs-apache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/81af4a04761b270609f4f356484fdb61f3505688"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 03:51:23.000000000","tz":540},"subject":"Update unit tests to adapt to new puppetlabs-apache","message":"Update unit tests to adapt to new puppetlabs-apache\n\nSome default values have been updated in the latest puppetlabs-apache\nv8.0.0 release. This change updates unit tests to adapts to the new\ndefaults.\n\nRelated-Bug: #1983300\nDepends-on: https://review.opendev.org/852689\nChange-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/0f1ccc96888ae79f49fa85748c09fa950832e544"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/0f1ccc96888ae79f49fa85748c09fa950832e544"}]},"branch":"refs/heads/master"},"2083789a80afdf16ca8ef2f7a1a94630b58f66c2":{"kind":"REWORK","_number":4,"created":"2022-08-10 07:47:51.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/90/852690/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/852690/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/4"}}},"commit":{"parents":[{"commit":"b47a62da1c12e43feb502b53bd5838522f28c86a","subject":"Fix unit test failure with new type validation in puppetlabs-apache","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/b47a62da1c12e43feb502b53bd5838522f28c86a"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 07:47:09.000000000","tz":540},"subject":"Stop testing underlying default in puppetlabs-apache","message":"Stop testing underlying default in puppetlabs-apache\n\nWhen passing undef(nil) to a defined resource type then the value is\njust ignored and the default value in the defined resource type is\nused. Because of this any change in default value in the dependent\nmodule can directly break our unit tests if we strictly assert behavior\nwith undef passed.\n\nThis change removes a few validations which effectively assert defaults\nin puppetlabs-apache. They updated a few default values in 8.0.0 and\nthat is causing multiple failures now.\n\nRelated-Bug: #1983300\nChange-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/2083789a80afdf16ca8ef2f7a1a94630b58f66c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/2083789a80afdf16ca8ef2f7a1a94630b58f66c2"}]},"branch":"refs/heads/master"},"ba19e6dbd30fcd931d78877d4e262fbd2e3d1da1":{"kind":"NO_CHANGE","_number":5,"created":"2022-08-10 07:51:41.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/90/852690/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/852690/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/852690/5"}}},"commit":{"parents":[{"commit":"a11ca496f7ae515c0d97fbb1f888f87cc00214a3","subject":"Fix unit test failure with new type validation in puppetlabs-apache","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/a11ca496f7ae515c0d97fbb1f888f87cc00214a3"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 02:39:21.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-08-10 07:51:31.000000000","tz":540},"subject":"Stop testing underlying default in puppetlabs-apache","message":"Stop testing underlying default in puppetlabs-apache\n\nWhen passing undef(nil) to a defined resource type then the value is\njust ignored and the default value in the defined resource type is\nused. Because of this any change in default value in the dependent\nmodule can directly break our unit tests if we strictly assert behavior\nwith undef passed.\n\nThis change removes a few validations which effectively assert defaults\nin puppetlabs-apache. They updated a few default values in 8.0.0 and\nthat is causing multiple failures now.\n\nRelated-Bug: #1983300\nChange-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/ba19e6dbd30fcd931d78877d4e262fbd2e3d1da1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/ba19e6dbd30fcd931d78877d4e262fbd2e3d1da1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}}]}],"submit_requirements":[]}