)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5d92abb1257c45d81f9720568b40125cb3c97463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c3cd2b6_b1385d49","updated":"2023-06-19 23:14:33.000000000","message":"I also tend to lean against ServiceDefault but to keep things moving let\u0027s change that later if we have consensus on that later, feel free to +w to move it along.","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ab7663197d217bd15b56cdd9ce1a27531b73bfac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04d71968_934eb30d","updated":"2023-06-20 22:16:13.000000000","message":"recheck tempest","commit_id":"a22990d4d5abe1eecd59a818b6e69eb6aa3423e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"82907ea3e4ae5ebc5de99195d70ab71b3fdc684b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f119f66_5d0b9c0c","updated":"2023-06-26 00:42:53.000000000","message":"recheck tempest","commit_id":"a22990d4d5abe1eecd59a818b6e69eb6aa3423e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"826d20a4da8d4fbf18cb91ff9d3c3290d130c12d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31d38161_0559d5dc","updated":"2023-06-23 00:27:33.000000000","message":"recheck tempest","commit_id":"a22990d4d5abe1eecd59a818b6e69eb6aa3423e1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"fb54f06465e21843143022c384df618ef9537b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d82b6781_7296419b","updated":"2023-06-25 21:31:16.000000000","message":"recheck tempest timeout","commit_id":"a22990d4d5abe1eecd59a818b6e69eb6aa3423e1"}],"types/servicedefault.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"61046c2a4f9a668b08ad7bb428663c211ea98d5a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"type Openstacklib::Servicedefault \u003d Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fc16b5cb_105f2518","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":33},"updated":"2023-06-19 08:39:17.000000000","message":"I\u0027ve checked a few other modules (eg. puppetlabs-apache and stdlib) and saw some of these use CamelCase for readability. I\u0027m ok with this but still feel like `ServiceDefault` naming is a valid option.","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"08f6a937154ec3ce0e981bbda2c666c67dc98355","unresolved":false,"context_lines":[{"line_number":1,"context_line":"type Openstacklib::Servicedefault \u003d Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bc4dce38_22f65cba","line":1,"updated":"2023-06-19 19:45:25.000000000","message":"My vote would be for ServiceDefault for readability, but feel free to merge this if you don\u0027t want to rename it.","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"82907ea3e4ae5ebc5de99195d70ab71b3fdc684b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"type Openstacklib::Servicedefault \u003d Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"c6b88f72_e743338b","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":33},"in_reply_to":"6afda99c_158bc058","updated":"2023-06-26 00:42:53.000000000","message":"Done","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a2455037cba591e12811434660c0000808d337b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"type Openstacklib::Servicedefault \u003d Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"6afda99c_158bc058","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":33},"in_reply_to":"86c845e0_6d7da667","updated":"2023-06-19 09:27:14.000000000","message":"I tend to keep this now because it would be more consistent with the Dbconn type we already have in puppet-oslo. I\u0027d be open for any additional feedback from the other cores.","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d110678e82e02f69396f35fa73dbff80c960a932","unresolved":true,"context_lines":[{"line_number":1,"context_line":"type Openstacklib::Servicedefault \u003d Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"86c845e0_6d7da667","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":33},"in_reply_to":"fc16b5cb_105f2518","updated":"2023-06-19 08:45:18.000000000","message":"According to the puppet documentation it would be valid. I let the decision up to you. If you like, I change.","commit_id":"d34deaa726b8697c4b3707c9db7bebdb50350c0f"}]}