)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"4dad032d72b827fbf96d044e3b78fbb2e0387d90","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8205339c_48d7d1bd","updated":"2025-02-18 10:02:02.000000000","message":"Note that actually there is no acceptance test as I don\u0027t know the best way to create a non-root user to then test file ownership","commit_id":"a561c941c2fef4e1cd715bdf0d6cec70af4ee87c"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"606f92cd35ba31c01e321bde2f29b1ee752859f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b58b4071_c6ad7e27","in_reply_to":"8205339c_48d7d1bd","updated":"2025-02-18 10:31:25.000000000","message":"Done as per IRC, changed param names for consistency with https://opendev.org/openstack/puppet-openstacklib/src/branch/master/spec/defines/openstacklib_policy_default_spec.rb#L13-L14","commit_id":"a561c941c2fef4e1cd715bdf0d6cec70af4ee87c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1ff942e92aac8bd931b41f0454d7a2e6095401e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b73f118f_e8e8941c","updated":"2025-02-18 14:01:30.000000000","message":"Also please add a release note.","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"111f54052e0a1ba63f46f0c8ebec5b21ab6b1e8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"91458d30_48cb9a57","in_reply_to":"b73f118f_e8e8941c","updated":"2025-02-18 14:20:12.000000000","message":"Done","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f8845b5af7258a4a76186fa92f278627fccb1dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1c787ce1_b24dc58f","updated":"2025-02-20 13:26:01.000000000","message":"recheck","commit_id":"2ca50984b19e73f42410a5e5a250952f65120467"}],"manifests/clouds.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1ff942e92aac8bd931b41f0454d7a2e6095401e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"#   Defaults to {}"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*file_user*]"},{"line_number":51,"context_line":"# User that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*file_group*]"},{"line_number":54,"context_line":"# Group that owns the clouds.yaml file. Defaults to \u0027root\u0027."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"65dea314_1651f9fc","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":58},"updated":"2025-02-18 14:01:30.000000000","message":"Please make the line format consistent with the others.\n\n```\n#  (Optional) User that owns the clouds.yaml file\n#  Defaults to \u0027root\u0027\n```","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"111f54052e0a1ba63f46f0c8ebec5b21ab6b1e8a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   Defaults to {}"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*file_user*]"},{"line_number":51,"context_line":"# User that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*file_group*]"},{"line_number":54,"context_line":"# Group that owns the clouds.yaml file. Defaults to \u0027root\u0027."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a170a82_d8e65895","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":58},"in_reply_to":"65dea314_1651f9fc","updated":"2025-02-18 14:20:12.000000000","message":"Done","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1ff942e92aac8bd931b41f0454d7a2e6095401e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"# User that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*file_group*]"},{"line_number":54,"context_line":"# Group that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"define openstacklib::clouds ("},{"line_number":57,"context_line":"  String[1] $username,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8393c012_937c7fbb","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":7},"updated":"2025-02-18 14:01:30.000000000","message":"ditto","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"111f54052e0a1ba63f46f0c8ebec5b21ab6b1e8a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# User that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*file_group*]"},{"line_number":54,"context_line":"# Group that owns the clouds.yaml file. Defaults to \u0027root\u0027."},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"define openstacklib::clouds ("},{"line_number":57,"context_line":"  String[1] $username,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"48837b03_3550e3c9","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":7},"in_reply_to":"8393c012_937c7fbb","updated":"2025-02-18 14:20:12.000000000","message":"Done","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1ff942e92aac8bd931b41f0454d7a2e6095401e","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { $path:"},{"line_number":76,"context_line":"    mode      \u003d\u003e \u00270600\u0027,"},{"line_number":77,"context_line":"    owner     \u003d\u003e \u0027root\u0027,"},{"line_number":78,"context_line":"    group     \u003d\u003e \u0027root\u0027,"},{"line_number":79,"context_line":"    content   \u003d\u003e template(\u0027openstacklib/clouds.yaml.erb\u0027),"},{"line_number":80,"context_line":"    show_diff \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8ba87ae2_fbbd4fac","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":22},"updated":"2025-02-18 14:01:30.000000000","message":"the parameters may need to be used here","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"111f54052e0a1ba63f46f0c8ebec5b21ab6b1e8a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { $path:"},{"line_number":76,"context_line":"    mode      \u003d\u003e \u00270600\u0027,"},{"line_number":77,"context_line":"    owner     \u003d\u003e \u0027root\u0027,"},{"line_number":78,"context_line":"    group     \u003d\u003e \u0027root\u0027,"},{"line_number":79,"context_line":"    content   \u003d\u003e template(\u0027openstacklib/clouds.yaml.erb\u0027),"},{"line_number":80,"context_line":"    show_diff \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"49b224af_fd814547","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":22},"in_reply_to":"8ba87ae2_fbbd4fac","updated":"2025-02-18 14:20:12.000000000","message":"Sorry, I was convinced I\u0027d added it... Hadn\u0027t staged it yet probably","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1ff942e92aac8bd931b41f0454d7a2e6095401e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  file { $path:"},{"line_number":76,"context_line":"    mode      \u003d\u003e \u00270600\u0027,"},{"line_number":77,"context_line":"    owner     \u003d\u003e \u0027root\u0027,"},{"line_number":78,"context_line":"    group     \u003d\u003e \u0027root\u0027,"},{"line_number":79,"context_line":"    content   \u003d\u003e template(\u0027openstacklib/clouds.yaml.erb\u0027),"},{"line_number":80,"context_line":"    show_diff \u003d\u003e false,"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"97b49b8b_cd966afc","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":22},"updated":"2025-02-18 14:01:30.000000000","message":"and here","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"111f54052e0a1ba63f46f0c8ebec5b21ab6b1e8a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  file { $path:"},{"line_number":76,"context_line":"    mode      \u003d\u003e \u00270600\u0027,"},{"line_number":77,"context_line":"    owner     \u003d\u003e \u0027root\u0027,"},{"line_number":78,"context_line":"    group     \u003d\u003e \u0027root\u0027,"},{"line_number":79,"context_line":"    content   \u003d\u003e template(\u0027openstacklib/clouds.yaml.erb\u0027),"},{"line_number":80,"context_line":"    show_diff \u003d\u003e false,"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"417317f2_1b206d7c","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":22},"in_reply_to":"97b49b8b_cd966afc","updated":"2025-02-18 14:20:12.000000000","message":"Idem","commit_id":"3ac95eca8c2106cb90371b826818b3b54d8b3e30"}],"spec/acceptance/mysql_spec.rb":[{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"0ec9950d55d28dc33b3a3572c626807638d095b3","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      class { \u0027mysql::server\u0027: }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      $charset \u003d $::operatingsystem ? {"},{"line_number":14,"context_line":"        \u0027Ubuntu\u0027 \u003d\u003e \u0027utf8mb3\u0027,"},{"line_number":15,"context_line":"        default  \u003d\u003e \u0027utf8\u0027,"},{"line_number":16,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"c1fa97c9_608f8c46","side":"PARENT","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":35},"updated":"2025-02-19 09:42:11.000000000","message":"Had to replace legacy fact otherwise Puppet 8 tests failed, is it be ok to include it in this review?","commit_id":"3587f2fa67d6d39b30bc17ac675a40b21933d518"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"e226b7a73baa137ee8629eae9b9f81b6cef50932","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      class { \u0027mysql::server\u0027: }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      $charset \u003d $::operatingsystem ? {"},{"line_number":14,"context_line":"        \u0027Ubuntu\u0027 \u003d\u003e \u0027utf8mb3\u0027,"},{"line_number":15,"context_line":"        default  \u003d\u003e \u0027utf8\u0027,"},{"line_number":16,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"f73701ec_c8c5661d","side":"PARENT","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":35},"in_reply_to":"30047a0e_3384fca8","updated":"2025-02-19 10:03:49.000000000","message":"Ok, thanks for the rebase, I updated the commit message accordingly","commit_id":"3587f2fa67d6d39b30bc17ac675a40b21933d518"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"58b536990dad7ab3eea9ff3a774696bb0d751eca","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      class { \u0027mysql::server\u0027: }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      $charset \u003d $::operatingsystem ? {"},{"line_number":14,"context_line":"        \u0027Ubuntu\u0027 \u003d\u003e \u0027utf8mb3\u0027,"},{"line_number":15,"context_line":"        default  \u003d\u003e \u0027utf8\u0027,"},{"line_number":16,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"30047a0e_3384fca8","side":"PARENT","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":35},"in_reply_to":"c1fa97c9_608f8c46","updated":"2025-02-19 09:51:39.000000000","message":"There is already another change to replace it https://review.opendev.org/c/openstack/puppet-openstacklib/+/942025 . We should merge that one first instead of squashing the fix into this change.","commit_id":"3587f2fa67d6d39b30bc17ac675a40b21933d518"}]}