)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5c6328ac9eff45738cf4189f0a259ddbee7c192d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17d63279_14f1e26c","updated":"2025-06-17 14:53:35.000000000","message":"Trying to wrap my head around this change, think I understand but could you please add some testing.","commit_id":"725d0e99329ce4a0cf56d17ec150761f362fa7fe"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"4a3a682a9f47055d12b04607ace1e6bb2d02d49c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34c63b0d_580fbc6f","in_reply_to":"17d63279_14f1e26c","updated":"2025-06-17 20:38:48.000000000","message":"In short: It\u0027s not possible to make a spec test to ensure a manifest is idempotent !\n\nI added some tests to ensure the right policy content and ensure that file line\nis not used if purge_config is true.\n\nsome more info about the fix: \nSetting $purge_config to true and setting $policies!\u003d{} is working, but not idempotent and worse triggers an api reload on every run, the reason is, that (before this fix) it runs openstacklib::policy::base which purges the config (since $purge_config is true) which ensure_resource openstacklib::policy::default which sets content to \u0027\u0027 and then it runs the file_line statements to enter the the lines again. Since puppet thinks now the policy changed, it triggers the reloads.\n\nOther Remark: I\u0027m pretty shure that all [ensure|create]_resources are not needed and could be replaced by a simple each loop in openstacklib::policy which also makes openstacklib::policy::* obsolete. If this is done we should also get rid of file_line which is \u0027not best practice\u0027 !","commit_id":"725d0e99329ce4a0cf56d17ec150761f362fa7fe"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d8f3be03f33628d705b441c71131fbf352f88577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f752505d_40cd2577","updated":"2025-06-18 06:46:29.000000000","message":"recheck","commit_id":"978dfe014cd061a243e825f24c9b4d3c1f4428b4"}]}