)]}'
{"manifests/cors.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"df6f70eb8d48290dcc4c82a20b0f342c4eaea60c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  create_resources($name, {\u0027cors/expose_headers\u0027 \u003d\u003e { value \u003d\u003e $expose_headers }})"},{"line_number":46,"context_line":"  create_resources($name, {\u0027cors/max_age\u0027 \u003d\u003e { value \u003d\u003e $max_age }})"},{"line_number":47,"context_line":"  create_resources($name, {\u0027cors/allow_methods\u0027 \u003d\u003e { value \u003d\u003e $allow_methods }})"},{"line_number":48,"context_line":"  create_resources($name, {\u0027cors/allow_headers\u0027 \u003d\u003e { value \u003d\u003e $allow_headers }})"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_fa2cf8ac","line":48,"updated":"2016-02-10 16:26:58.000000000","message":"also see the comments about switching to a hash and a single create_resources over on https://review.openstack.org/#/c/274764/","commit_id":"6007f13b378958d205021c9e1180f89e4924dace"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"ac48feacae56d02d137179e5fb8e3198176ec168","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  create_resources($name, {\u0027cors/expose_headers\u0027 \u003d\u003e { value \u003d\u003e $expose_headers }})"},{"line_number":46,"context_line":"  create_resources($name, {\u0027cors/max_age\u0027 \u003d\u003e { value \u003d\u003e $max_age }})"},{"line_number":47,"context_line":"  create_resources($name, {\u0027cors/allow_methods\u0027 \u003d\u003e { value \u003d\u003e $allow_methods }})"},{"line_number":48,"context_line":"  create_resources($name, {\u0027cors/allow_headers\u0027 \u003d\u003e { value \u003d\u003e $allow_headers }})"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_9f70e173","line":48,"in_reply_to":"3a57f1b5_fa2cf8ac","updated":"2016-03-01 09:02:31.000000000","message":"Done","commit_id":"6007f13b378958d205021c9e1180f89e4924dace"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c97f5873f8c45c446cdabe2d294fe33cd89235b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*allowed_origin*]"},{"line_number":11,"context_line":"#   (Optional) Indicate whether this resource may be shared with the domain received"},{"line_number":12,"context_line":"#   in the requests \"origin\" header."},{"line_number":13,"context_line":"#   Defaults to $::os_service_default."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*allow_credentials*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1af94dfe_23cd57b7","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":35},"updated":"2016-03-18 10:31:28.000000000","message":"just a suggestion: can you please specify type of each parameter like it\u0027s done \u0027allow_methods\u0027?","commit_id":"11f7be58554d2ccd9e67848ae41db21d81cb3ae9"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c97f5873f8c45c446cdabe2d294fe33cd89235b9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  create_resources($name, {\u0027cors/expose_headers\u0027 \u003d\u003e { value \u003d\u003e $expose_headers }})"},{"line_number":46,"context_line":"  create_resources($name, {\u0027cors/max_age\u0027 \u003d\u003e { value \u003d\u003e $max_age }})"},{"line_number":47,"context_line":"  create_resources($name, {\u0027cors/allow_methods\u0027 \u003d\u003e { value \u003d\u003e $allow_methods }})"},{"line_number":48,"context_line":"  create_resources($name, {\u0027cors/allow_headers\u0027 \u003d\u003e { value \u003d\u003e $allow_headers }})"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1af94dfe_43a34300","line":48,"range":{"start_line":48,"start_character":18,"end_line":48,"end_character":20},"updated":"2016-03-18 10:31:28.000000000","message":"let\u0027s do only one call of create_resources","commit_id":"11f7be58554d2ccd9e67848ae41db21d81cb3ae9"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*allowed_origin*]"},{"line_number":11,"context_line":"#   (Optional) Indicate whether this resource may be shared with the domain"},{"line_number":12,"context_line":"#   received in the requests \"origin\" header. (string)"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*allow_credentials*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_14a60410","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":53},"updated":"2016-04-13 10:53:48.000000000","message":"lets have same format - \"(${type} value)\", always \"full\" version","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*allow_credentials*]"},{"line_number":16,"context_line":"#   (Optional) Indicate that the actual request can include user credentials."},{"line_number":17,"context_line":"#   (boolean)"},{"line_number":18,"context_line":"#   Defaults to $::os_service_default."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*expose_headers*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_94ba1422","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":12},"updated":"2016-04-13 10:53:48.000000000","message":"same here: (boolean) --\u003e (boolean value)","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   Defaults to $::os_service_default."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*max_age*]"},{"line_number":26,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests. (integer)"},{"line_number":27,"context_line":"#   Defaults to $::os_service_default."},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*allow_methods*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_74b5b82f","line":26,"range":{"start_line":26,"start_character":62,"end_line":26,"end_character":69},"updated":"2016-04-13 10:53:48.000000000","message":"same","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   request. (list value)"},{"line_number":37,"context_line":"#   Defaults to $::os_service_default."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*subdomain*]"},{"line_number":40,"context_line":"#   (Optional) Indicates if we should set the values in cors.subdomain or cors."},{"line_number":41,"context_line":"#   If set to true, we use cors.subdomain as the section in the ini file."},{"line_number":42,"context_line":"#   If set to false, we use cors as the section in the inifile."},{"line_number":43,"context_line":"#   (boolean)"},{"line_number":44,"context_line":"#   Defaults to false"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"define oslo::cors("},{"line_number":47,"context_line":"  $allowed_origin    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_9f850d5b","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":21},"updated":"2016-04-13 10:53:48.000000000","message":"As I see in docs (http://docs.openstack.org/developer/oslo.middleware/cors.html), subdomain should be \"something\", so I suggest to set default value as \"undef\" and pass \"something\" (string) as subdomain here.\n\nAs result we can:\nif $subdomain {\n    $section \u003d \"cors.${subdomain}\"\n} else {\n    $section \u003d \u0027cors\u0027\n}","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"cac60a617926d4daf658d5bfcca04c8d8bed4350","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   request. (list value)"},{"line_number":37,"context_line":"#   Defaults to $::os_service_default."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*subdomain*]"},{"line_number":40,"context_line":"#   (Optional) Indicates if we should set the values in cors.subdomain or cors."},{"line_number":41,"context_line":"#   If set to true, we use cors.subdomain as the section in the ini file."},{"line_number":42,"context_line":"#   If set to false, we use cors as the section in the inifile."},{"line_number":43,"context_line":"#   (boolean)"},{"line_number":44,"context_line":"#   Defaults to false"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"define oslo::cors("},{"line_number":47,"context_line":"  $allowed_origin    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_88cc556b","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":21},"in_reply_to":"5a18252c_9f850d5b","updated":"2016-04-20 08:56:11.000000000","message":"I agree with that.","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $subdomain         \u003d false,"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":"  if $subdomain {"},{"line_number":56,"context_line":"    $section \u003d \u0027cors.subdomain\u0027"},{"line_number":57,"context_line":"  } else {"},{"line_number":58,"context_line":"    $section \u003d \u0027cors\u0027"},{"line_number":59,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_9107c61b","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":31},"updated":"2016-04-13 10:53:48.000000000","message":"Should \"subdomain\" be replaced with \"$name\"?\nAnd there is a commen above about subdomain parameter","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"cac60a617926d4daf658d5bfcca04c8d8bed4350","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $subdomain         \u003d false,"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":"  if $subdomain {"},{"line_number":56,"context_line":"    $section \u003d \u0027cors.subdomain\u0027"},{"line_number":57,"context_line":"  } else {"},{"line_number":58,"context_line":"    $section \u003d \u0027cors\u0027"},{"line_number":59,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_c8c2cd33","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":31},"in_reply_to":"5a18252c_9107c61b","updated":"2016-04-20 08:56:11.000000000","message":"Done","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"73e7c834e253ada00b1ad2a11a19d3dca21c6752","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*subdomain*]"},{"line_number":43,"context_line":"#   (Optional) Indicates if we should set the values in cors.$subdomain or cors."},{"line_number":44,"context_line":"#   If set to an string, we use cors.$subdomain as the section in the ini file."},{"line_number":45,"context_line":"#   If set to undef, we use cors as the section in the inifile."},{"line_number":46,"context_line":"#   (string value)"},{"line_number":47,"context_line":"#   Defaults to undef."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_ecefd484","line":44,"range":{"start_line":44,"start_character":14,"end_line":44,"end_character":16},"updated":"2016-04-20 12:17:51.000000000","message":"just \"a\", not \"an\" :)","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"aef34e4fe4851c95305b61fa02d60f2faa9e71c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   Defaults to undef."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"define oslo::cors("},{"line_number":50,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":51,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $expose_headers    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $max_age           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_b13a50e5","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":44},"updated":"2016-04-20 12:26:31.000000000","message":"What value is this?","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"b8e34b02e889bf6e76de86a79e911f9b6a16d1bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   Defaults to undef."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"define oslo::cors("},{"line_number":50,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":51,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $expose_headers    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $max_age           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_dfa1d395","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":44},"in_reply_to":"1a122d0e_b13a50e5","updated":"2016-04-20 12:44:47.000000000","message":"As I know, there would be no line about \"allowed_origin\" - it would be commented out (# allowed_origin \u003d ).","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"da015911ad5a4a8b91ec55a84f6c51f58f438786","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   Defaults to undef."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"define oslo::cors("},{"line_number":50,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":51,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $expose_headers    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $max_age           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_8a1b9680","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":44},"in_reply_to":"1a122d0e_dfa1d395","updated":"2016-04-20 14:25:13.000000000","message":"$::os_service_default is \u003cSERVICE DEFAULT\u003e, which our config providers treat as ensure \u003d\u003e absent","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"30426aef8c2cd42a4c10e171e8dc2d6fc483cd7e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   Defaults to undef."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"define oslo::cors("},{"line_number":50,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":51,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $expose_headers    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $max_age           \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_4a55fec3","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":44},"in_reply_to":"1a122d0e_dfa1d395","updated":"2016-04-20 14:44:31.000000000","message":"this option is available: https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/cors.py#L29","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"aef34e4fe4851c95305b61fa02d60f2faa9e71c5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"${section}/allow_methods\"     \u003d\u003e { value \u003d\u003e $allow_methods },"},{"line_number":70,"context_line":"    \"${section}/allow_headers\"     \u003d\u003e { value \u003d\u003e $allow_headers }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  create_resources($name, $cors_options)"},{"line_number":73,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_b4f23e04","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":40},"updated":"2016-04-20 12:26:31.000000000","message":"Every service contains configuration defaults that include its own header and method defaults. If, using this module, the user does not explicitly override them in the module, what will this generate?\n\nIf it generates:\n\n[cors]\n# expose_headers\u003d\n\nThen this is great, as the oslo configuration options will take over and use the expected sane defaults for CORS.\n\nIf it instead generates:\n\n[cors]\nexpose_headers\u003d\n\nThen this is bad, because the service\u0027s own defaults are ignored/overridden, and absolutely no headers will be permitted.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"da015911ad5a4a8b91ec55a84f6c51f58f438786","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"${section}/allow_methods\"     \u003d\u003e { value \u003d\u003e $allow_methods },"},{"line_number":70,"context_line":"    \"${section}/allow_headers\"     \u003d\u003e { value \u003d\u003e $allow_headers }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  create_resources($name, $cors_options)"},{"line_number":73,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_0a102656","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":40},"in_reply_to":"1a122d0e_5fbca3ba","updated":"2016-04-20 14:25:13.000000000","message":"1st case, right.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"b8e34b02e889bf6e76de86a79e911f9b6a16d1bb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"${section}/allow_methods\"     \u003d\u003e { value \u003d\u003e $allow_methods },"},{"line_number":70,"context_line":"    \"${section}/allow_headers\"     \u003d\u003e { value \u003d\u003e $allow_headers }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  create_resources($name, $cors_options)"},{"line_number":73,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_5fbca3ba","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":40},"in_reply_to":"1a122d0e_b4f23e04","updated":"2016-04-20 12:44:47.000000000","message":"1st case - commented out.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"30426aef8c2cd42a4c10e171e8dc2d6fc483cd7e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"${section}/allow_methods\"     \u003d\u003e { value \u003d\u003e $allow_methods },"},{"line_number":70,"context_line":"    \"${section}/allow_headers\"     \u003d\u003e { value \u003d\u003e $allow_headers }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  create_resources($name, $cors_options)"},{"line_number":73,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_e8aa1284","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":40},"in_reply_to":"1a122d0e_b4f23e04","updated":"2016-04-20 14:44:31.000000000","message":"It will comment out.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9b75503be6c5d20f29f697532524e3df049efa8b","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  $cors_options \u003d {"},{"line_number":52,"context_line":"    \"cors/allowed_origin\"    \u003d\u003e { value \u003d\u003e $allowed_origin },"},{"line_number":53,"context_line":"    \"cors/allow_credentials\" \u003d\u003e { value \u003d\u003e $allow_credentials },"},{"line_number":54,"context_line":"    \"cors/expose_headers\"    \u003d\u003e { value \u003d\u003e $expose_headers },"},{"line_number":55,"context_line":"    \"cors/max_age\"           \u003d\u003e { value \u003d\u003e $max_age },"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"dab17558_b565ecaf","line":52,"updated":"2016-05-17 13:49:19.000000000","message":"These should be single quotes since there is no longer a variable in the strings","commit_id":"d61360257c483f8a5d4f465b5db501f88daed87e"}],"manifests/cors/subdomain.pp":[{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*allowed_origin*]"},{"line_number":13,"context_line":"#   (Optional) Indicate whether this resource may be shared with the domain"},{"line_number":14,"context_line":"#   received in the requests \"origin\" header. (string)"},{"line_number":15,"context_line":"#   Defaults to $::os_service_default."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*allow_credentials*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_b43ab096","line":14,"range":{"start_line":14,"start_character":47,"end_line":14,"end_character":53},"updated":"2016-04-13 10:53:48.000000000","message":"same: (string) --\u003e (string value)","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*allow_credentials*]"},{"line_number":18,"context_line":"#   (Optional) Indicate that the actual request can include user credentials."},{"line_number":19,"context_line":"#   (boolean)"},{"line_number":20,"context_line":"#   Defaults to $::os_service_default."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*expose_headers*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_f444281c","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":12},"updated":"2016-04-13 10:53:48.000000000","message":"same","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   Defaults to $::os_service_default."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*max_age*]"},{"line_number":28,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests. (integer)"},{"line_number":29,"context_line":"#   Defaults to $::os_service_default."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*allow_methods*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_745138d8","line":28,"range":{"start_line":28,"start_character":62,"end_line":28,"end_character":69},"updated":"2016-04-13 10:53:48.000000000","message":"same","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    max_age           \u003d\u003e $max_age,"},{"line_number":54,"context_line":"    allow_methods     \u003d\u003e $allow_methods,"},{"line_number":55,"context_line":"    allow_headers     \u003d\u003e $allow_headers,"},{"line_number":56,"context_line":"    subdomain         \u003d\u003e true,"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_1fc0dd7b","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":30},"updated":"2016-04-13 10:53:48.000000000","message":"look at questions in cors.pp","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"babdfb67a696f2e09bd4390c204caad444a169ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   (string value)"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"define oslo::cors::subdomain("},{"line_number":51,"context_line":"  $subdomain,"},{"line_number":52,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $expose_headers    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_edaea42c","line":51,"updated":"2016-04-20 14:30:44.000000000","message":"This should probably just be $name by default rather than duplicating the subdomain","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c64b5e04f0ee2986b793fff08c16fc96ed0e93ed","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   (string value)"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"define oslo::cors::subdomain("},{"line_number":51,"context_line":"  $subdomain,"},{"line_number":52,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $expose_headers    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_9e92b44a","line":51,"in_reply_to":"1a122d0e_c8eab673","updated":"2016-04-20 15:11:13.000000000","message":"I\u0027m not sure we should duplicate all of this, but ok.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"30426aef8c2cd42a4c10e171e8dc2d6fc483cd7e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   (string value)"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"define oslo::cors::subdomain("},{"line_number":51,"context_line":"  $subdomain,"},{"line_number":52,"context_line":"  $allowed_origin    \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $allow_credentials \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $expose_headers    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_c8eab673","line":51,"in_reply_to":"1a122d0e_edaea42c","updated":"2016-04-20 14:44:31.000000000","message":"Hi, Alex, I think oslo::cors::subdomain should not call oslo::cors.\nAnd I will remove subdomain in oslo::cors.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"da015911ad5a4a8b91ec55a84f6c51f58f438786","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    max_age           \u003d\u003e $max_age,"},{"line_number":65,"context_line":"    allow_methods     \u003d\u003e $allow_methods,"},{"line_number":66,"context_line":"    allow_headers     \u003d\u003e $allow_headers,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_4d907895","line":67,"updated":"2016-04-20 14:25:13.000000000","message":"why we need this file at all? we can call oslo::cors from orchestration layer.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"babdfb67a696f2e09bd4390c204caad444a169ae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    max_age           \u003d\u003e $max_age,"},{"line_number":65,"context_line":"    allow_methods     \u003d\u003e $allow_methods,"},{"line_number":66,"context_line":"    allow_headers     \u003d\u003e $allow_headers,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_6d9bb418","line":67,"in_reply_to":"1a122d0e_4d907895","updated":"2016-04-20 14:30:44.000000000","message":"It just provides an simple interface. I would have used $name instead of a $subdomain to this resource however.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"30426aef8c2cd42a4c10e171e8dc2d6fc483cd7e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    max_age           \u003d\u003e $max_age,"},{"line_number":65,"context_line":"    allow_methods     \u003d\u003e $allow_methods,"},{"line_number":66,"context_line":"    allow_headers     \u003d\u003e $allow_headers,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_8866fe4e","line":67,"in_reply_to":"1a122d0e_6d9bb418","updated":"2016-04-20 14:44:31.000000000","message":"I think we can just reserve oslo::cors::subdomain and remove oslo::cors. Or we can keep both of them, but no call relationships between them, prepare for changes in the future.","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"31b9865d23b96340b4ad58aa5599b1fcae0ec9f4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    max_age           \u003d\u003e $max_age,"},{"line_number":65,"context_line":"    allow_methods     \u003d\u003e $allow_methods,"},{"line_number":66,"context_line":"    allow_headers     \u003d\u003e $allow_headers,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_a3083ddb","line":67,"in_reply_to":"1a122d0e_6d9bb418","updated":"2016-04-20 14:52:59.000000000","message":"yeah, already got it, but with one remark.\n\nwe can have:\n\noslo::cors { \u0027keystone_config\u0027:\n  subdomains \u003d\u003e [ \u0027some\u0027, \u0027elements\u0027 ],\n  \u003c...\u003e\n}\n\nin oslo::cors we can do next:\n\n$subdomains_real \u003d concat($subdomains, \u0027cors\u0027)\noslo::cors::subdomains { $subdomains_real:\n  \u003c...\u003e\n}","commit_id":"6f5b14fbc6243386779826836e2664461b9bb9a4"}],"manifests/middleware.pp":[{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"44da93b7cfc55e6db15d06b3a50abd9a2412ed1d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*max_request_body_size*]"},{"line_number":11,"context_line":"#   (Optional) Make exception message format errors fatal."},{"line_number":12,"context_line":"#   Defaults to $::os_service_default."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"define oslo::middleware("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a18252c_912186fe","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":58},"updated":"2016-04-13 10:53:48.000000000","message":"value type is missing - (integer value)","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"cac60a617926d4daf658d5bfcca04c8d8bed4350","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*max_request_body_size*]"},{"line_number":11,"context_line":"#   (Optional) Make exception message format errors fatal."},{"line_number":12,"context_line":"#   Defaults to $::os_service_default."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"define oslo::middleware("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_6853b96b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":58},"in_reply_to":"5a18252c_912186fe","updated":"2016-04-20 08:56:11.000000000","message":"Done","commit_id":"34dcf1f86fb8d855b1d9abedf42c853c6a340845"}],"spec/defines/oslo_cors_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dc6958be536a79e19526233421e60d6ea1bc8465","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  context \u0027on a Debian osfamily\u0027 do"},{"line_number":34,"context_line":"    let :facts do"},{"line_number":35,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \"Debian\" })"},{"line_number":36,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a57f1b5_ba1760a2","line":33,"updated":"2016-02-10 16:21:21.000000000","message":"The new patten for these is to use on_supported_os to leverage rspec-puppet-facts and our OSDefaults.  As an example, https://github.com/openstack/puppet-designate/blob/master/spec/defines/designate_pool_spec.rb#L45-L56\n\nI\u0027d like to cut down on the tests that\u0027ll have to be updated :)","commit_id":"6007f13b378958d205021c9e1180f89e4924dace"}],"spec/defines/oslo_cors_subdomain_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dc6958be536a79e19526233421e60d6ea1bc8465","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  context \u0027on a Debian osfamily\u0027 do"},{"line_number":34,"context_line":"    let :facts do"},{"line_number":35,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \"Debian\" })"},{"line_number":36,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a57f1b5_5a0c2c94","line":33,"updated":"2016-02-10 16:21:21.000000000","message":"same here","commit_id":"6007f13b378958d205021c9e1180f89e4924dace"}],"spec/defines/oslo_middleware_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dc6958be536a79e19526233421e60d6ea1bc8465","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  context \u0027on a Debian osfamily\u0027 do"},{"line_number":29,"context_line":"    let :facts do"},{"line_number":30,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \"Debian\" })"},{"line_number":31,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a57f1b5_7a11e8ab","line":28,"updated":"2016-02-10 16:21:21.000000000","message":"and here as well","commit_id":"6007f13b378958d205021c9e1180f89e4924dace"}]}