)]}'
{"manifests/messaging/amqp.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87ff16f084015bf824abc409f3ddbb8104c72158","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_dir\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_dir }})"},{"line_number":105,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_name\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_name }})"},{"line_number":106,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/username\u0027 \u003d\u003e { value \u003d\u003e $username }})"},{"line_number":107,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/password\u0027 \u003d\u003e { value \u003d\u003e $password }})"},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a57f1b5_5a6d0c03","line":107,"updated":"2016-02-10 16:25:20.000000000","message":"I agree with Michael, it\u0027d probably be cleaner to just build the hash and call create resources one time.\n\n$oslo_messaging_amqp \u003d {\n  \u0027oslo_messaging_amqp/server_request_prefix\u0027 \u003d\u003e { value \u003d\u003e $server_request_prefix },\n  \u0027oslo_messaging_amqp/broadcast_prefix\u0027 \u003d\u003e { value \u003d\u003e $broadcast_prefix },\n  ...\n}\n\ncreate_resources($name, $oslo_messaging_amqp)","commit_id":"0401b9c11efc6710fa5362ff58810d86cdb1e304"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"8c1a68755fdcd35ef9e151b0e07376c8cba5666c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_dir\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_dir }})"},{"line_number":105,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_name\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_name }})"},{"line_number":106,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/username\u0027 \u003d\u003e { value \u003d\u003e $username }})"},{"line_number":107,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/password\u0027 \u003d\u003e { value \u003d\u003e $password }})"},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a5ae5dd_9f751d33","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":85},"updated":"2016-02-08 08:41:54.000000000","message":"What about to make hash of these params and then call create_resource just once with it?","commit_id":"0401b9c11efc6710fa5362ff58810d86cdb1e304"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"66b68069eeaae47453986737987aa56b04bf18e8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_dir\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_dir }})"},{"line_number":105,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_name\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_name }})"},{"line_number":106,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/username\u0027 \u003d\u003e { value \u003d\u003e $username }})"},{"line_number":107,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/password\u0027 \u003d\u003e { value \u003d\u003e $password }})"},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a57f1b5_dce438e2","line":107,"in_reply_to":"3a57f1b5_5a6d0c03","updated":"2016-02-12 06:15:45.000000000","message":"You mean we combie all these params into a hash type parameter like $oslo_messaging_amqp ?","commit_id":"0401b9c11efc6710fa5362ff58810d86cdb1e304"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"fd5754724ee7ce43db2c5a61ce0af64f93231368","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_dir\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_dir }})"},{"line_number":105,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_name\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_name }})"},{"line_number":106,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/username\u0027 \u003d\u003e { value \u003d\u003e $username }})"},{"line_number":107,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/password\u0027 \u003d\u003e { value \u003d\u003e $password }})"},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a57f1b5_585051d4","line":107,"in_reply_to":"3a57f1b5_dce438e2","updated":"2016-02-12 08:13:18.000000000","message":"Definitely","commit_id":"0401b9c11efc6710fa5362ff58810d86cdb1e304"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4e08c40c3f3229e6c901b46d948e3e614e5082e5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_dir\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_dir }})"},{"line_number":105,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/sasl_config_name\u0027 \u003d\u003e { value \u003d\u003e $sasl_config_name }})"},{"line_number":106,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/username\u0027 \u003d\u003e { value \u003d\u003e $username }})"},{"line_number":107,"context_line":"  create_resources($name, {\u0027oslo_messaging_amqp/password\u0027 \u003d\u003e { value \u003d\u003e $password }})"},{"line_number":108,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a57f1b5_dc1c156c","line":107,"in_reply_to":"3a57f1b5_dce438e2","updated":"2016-02-12 17:29:19.000000000","message":"I don\u0027t mean a single class param but rather construct a single hash in the class from all the class parameters into a single hash that you use with a single create_resources(...).  Kinda like what I started in my comment that should be the contents of the class.","commit_id":"0401b9c11efc6710fa5362ff58810d86cdb1e304"}]}
