)]}'
{"manifests/messaging_rabbit.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"4ad3acf21207ad9c5d96abe337af3aa8de8e6fc8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    warning(\u0027fake_rabbit is deprecated, please use use rpc_backend\u003dkombu+memory or rpc_backend\u003dfake\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/fake_rabbit\u0027 \u003d\u003e { value \u003d\u003e $fake_rabbit }})"},{"line_number":162,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/amqp_durable_queues\u0027 \u003d\u003e { value \u003d\u003e $amqp_durable_queues }})"},{"line_number":163,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/rabbit_userid\u0027 \u003d\u003e { value \u003d\u003e $rabbit_userid }})"},{"line_number":164,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/rabbit_password\u0027 \u003d\u003e { value \u003d\u003e $rabbit_password }})"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afc51ec_4150bb5e","line":161,"range":{"start_line":161,"start_character":2,"end_line":161,"end_character":17},"updated":"2016-03-14 14:24:14.000000000","message":"Could we collect to hash all options and make just one call of create_resources with it?","commit_id":"08ec12613c76ccee5287af47205fb37265e4a3aa"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8df2dec80964733a9b278609b2180d4ea7d0dcc8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    warning(\u0027fake_rabbit is deprecated, please use use rpc_backend\u003dkombu+memory or rpc_backend\u003dfake\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/fake_rabbit\u0027 \u003d\u003e { value \u003d\u003e $fake_rabbit }})"},{"line_number":162,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/amqp_durable_queues\u0027 \u003d\u003e { value \u003d\u003e $amqp_durable_queues }})"},{"line_number":163,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/rabbit_userid\u0027 \u003d\u003e { value \u003d\u003e $rabbit_userid }})"},{"line_number":164,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/rabbit_password\u0027 \u003d\u003e { value \u003d\u003e $rabbit_password }})"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afc51ec_d7e9291c","line":161,"range":{"start_line":161,"start_character":2,"end_line":161,"end_character":17},"in_reply_to":"3afc51ec_4150bb5e","updated":"2016-03-14 14:44:25.000000000","message":"I\u0027m not sure it\u0027s a good idea. I think it will be easy to look at separate calls of create_resources instead of dealing with huge hash","commit_id":"08ec12613c76ccee5287af47205fb37265e4a3aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2add9fde52d7915f88aa9e2a8fd80c999894782d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    fail(\u0027Rabbit hosts should be an array\u0027)"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/amqp_durable_queues\u0027 \u003d\u003e { value \u003d\u003e $amqp_durable_queues }})"},{"line_number":181,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/heartbeat_rate\u0027 \u003d\u003e { value \u003d\u003e $heartbeat_rate }})"},{"line_number":182,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/heartbeat_timeout_threshold\u0027 \u003d\u003e { value \u003d\u003e $heartbeat_timeout_threshold }})"},{"line_number":183,"context_line":"  create_resources($name, {\u0027oslo_messaging_rabbit/kombu_compression\u0027 \u003d\u003e { value \u003d\u003e $kombu_compression }})"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3afc51ec_13743766","line":180,"updated":"2016-03-14 18:05:33.000000000","message":"If we\u0027re reworking this class, we should also switch to using a hash and reduce the number of create_resources calls.  For example, https://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/amqp.pp#L92-L109","commit_id":"d5ad0983a71ee2005999f16acb01053a6fb2370d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"15d0f0123af8441cce38090eaaee8bf6d7b8424c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  $rabbit_transient_queues_ttl          \u003d $::os_service_default,"},{"line_number":153,"context_line":"  $heartbeat_timeout_threshold          \u003d $::os_service_default,"},{"line_number":154,"context_line":"  $heartbeat_rate                       \u003d $::os_service_default,"},{"line_number":155,"context_line":"  $rpc_backend                          \u003d $::os_service_default,"},{"line_number":156,"context_line":"){"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_6a9c076a","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":64},"updated":"2016-03-15 12:52:30.000000000","message":"we don\u0027t need this - this class is for rabbit only, so it can be placed in config directly.","commit_id":"4ef70ad03a78ec000b2847d43e59559d67f33073"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7016e428e699bcb48db15ce790fc436e79280a3d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  $rabbit_transient_queues_ttl          \u003d $::os_service_default,"},{"line_number":153,"context_line":"  $heartbeat_timeout_threshold          \u003d $::os_service_default,"},{"line_number":154,"context_line":"  $heartbeat_rate                       \u003d $::os_service_default,"},{"line_number":155,"context_line":"  $rpc_backend                          \u003d $::os_service_default,"},{"line_number":156,"context_line":"){"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_73db5bee","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":64},"in_reply_to":"1af94dfe_6a9c076a","updated":"2016-03-15 15:08:33.000000000","message":"Done","commit_id":"4ef70ad03a78ec000b2847d43e59559d67f33073"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"15d0f0123af8441cce38090eaaee8bf6d7b8424c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"},{"line_number":194,"context_line":"  }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"  if $rabbit_use_ssl \u003d\u003d true {"},{"line_number":197,"context_line":"    $kombu_ssl_ca_certs_orig \u003d $kombu_ssl_ca_certs"},{"line_number":198,"context_line":"    $kombu_ssl_certfile_orig \u003d $kombu_ssl_certfile"},{"line_number":199,"context_line":"    $kombu_ssl_keyfile_orig  \u003d $kombu_ssl_keyfile"},{"line_number":200,"context_line":"    $kombu_ssl_version_orig  \u003d $kombu_ssl_version"},{"line_number":201,"context_line":"  } else {"},{"line_number":202,"context_line":"    # Do not set any of following parameters"},{"line_number":203,"context_line":"    $kombu_ssl_ca_certs_orig \u003d $::os_service_default"},{"line_number":204,"context_line":"    $kombu_ssl_certfile_orig \u003d $::os_service_default"},{"line_number":205,"context_line":"    $kombu_ssl_keyfile_orig  \u003d $::os_service_default"},{"line_number":206,"context_line":"    $kombu_ssl_version_orig  \u003d $::os_service_default"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  $rabbit_options \u003d { \u0027oslo_messaging_rabbit/amqp_durable_queues\u0027 \u003d\u003e { value \u003d\u003e $amqp_durable_queues },"},{"line_number":210,"context_line":"                      \u0027oslo_messaging_rabbit/heartbeat_rate\u0027 \u003d\u003e { value \u003d\u003e $heartbeat_rate },"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_aad72f22","line":207,"range":{"start_line":196,"start_character":0,"end_line":207,"end_character":3},"updated":"2016-03-15 12:52:30.000000000","message":"not sure that we need such if case. We have validation checks for these parameters in beginning.","commit_id":"4ef70ad03a78ec000b2847d43e59559d67f33073"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7016e428e699bcb48db15ce790fc436e79280a3d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"},{"line_number":194,"context_line":"  }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"  if $rabbit_use_ssl \u003d\u003d true {"},{"line_number":197,"context_line":"    $kombu_ssl_ca_certs_orig \u003d $kombu_ssl_ca_certs"},{"line_number":198,"context_line":"    $kombu_ssl_certfile_orig \u003d $kombu_ssl_certfile"},{"line_number":199,"context_line":"    $kombu_ssl_keyfile_orig  \u003d $kombu_ssl_keyfile"},{"line_number":200,"context_line":"    $kombu_ssl_version_orig  \u003d $kombu_ssl_version"},{"line_number":201,"context_line":"  } else {"},{"line_number":202,"context_line":"    # Do not set any of following parameters"},{"line_number":203,"context_line":"    $kombu_ssl_ca_certs_orig \u003d $::os_service_default"},{"line_number":204,"context_line":"    $kombu_ssl_certfile_orig \u003d $::os_service_default"},{"line_number":205,"context_line":"    $kombu_ssl_keyfile_orig  \u003d $::os_service_default"},{"line_number":206,"context_line":"    $kombu_ssl_version_orig  \u003d $::os_service_default"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  $rabbit_options \u003d { \u0027oslo_messaging_rabbit/amqp_durable_queues\u0027 \u003d\u003e { value \u003d\u003e $amqp_durable_queues },"},{"line_number":210,"context_line":"                      \u0027oslo_messaging_rabbit/heartbeat_rate\u0027 \u003d\u003e { value \u003d\u003e $heartbeat_rate },"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_53d8dfef","line":207,"range":{"start_line":196,"start_character":0,"end_line":207,"end_character":3},"in_reply_to":"1af94dfe_aad72f22","updated":"2016-03-15 15:08:33.000000000","message":"Done","commit_id":"4ef70ad03a78ec000b2847d43e59559d67f33073"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f6dade75f7aceef6d4da488e4e75dfd509af098","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be set together\u0027)"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  if !is_service_default($kombu_compression) and $kombu_compression !\u003d \u0027gzip\u0027 and $kombu_compression !\u003d \u0027bz2\u0027 {"},{"line_number":171,"context_line":"    fail(\u0027Unsupported Kombu compression. Possible values are gzip and bz2\u0027)"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1af94dfe_9220819d","line":170,"updated":"2016-03-16 02:43:35.000000000","message":"You could use !($kombu_compression in [\u0027gzip\u0027,\u0027bz2\u0027])","commit_id":"6d59d10d935926b566b3985ff3e55ad4cd4907f1"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7347f47ee84145a62d331b91b4b7e16d52e674ea","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be set together\u0027)"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  if !is_service_default($kombu_compression) and $kombu_compression !\u003d \u0027gzip\u0027 and $kombu_compression !\u003d \u0027bz2\u0027 {"},{"line_number":171,"context_line":"    fail(\u0027Unsupported Kombu compression. Possible values are gzip and bz2\u0027)"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1af94dfe_24c67d67","line":170,"in_reply_to":"1af94dfe_9220819d","updated":"2016-03-16 10:43:05.000000000","message":"+1 to this way","commit_id":"6d59d10d935926b566b3985ff3e55ad4cd4907f1"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"6965df71709b499035d3f147b2d3711115a19587","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be set together\u0027)"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  if !is_service_default($kombu_compression) and $kombu_compression !\u003d \u0027gzip\u0027 and $kombu_compression !\u003d \u0027bz2\u0027 {"},{"line_number":171,"context_line":"    fail(\u0027Unsupported Kombu compression. Possible values are gzip and bz2\u0027)"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1af94dfe_bf573401","line":170,"in_reply_to":"1af94dfe_9220819d","updated":"2016-03-16 10:54:39.000000000","message":"Done","commit_id":"6d59d10d935926b566b3985ff3e55ad4cd4907f1"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"b1a0f0575a0f712fbfdb67007fe4153ba14c069a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#  [*amqp_durable_queues*]"},{"line_number":11,"context_line":"#    (optional) Boolean. Define queues as \"durable\" to rabbitmq."},{"line_number":12,"context_line":"#    Defaults to $::os_service_default"},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*kombu_ssl_version*]"},{"line_number":15,"context_line":"#   (Optional) SSL version to use (valid only if SSL enabled). \u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_b9210ffe","line":12,"range":{"start_line":10,"start_character":1,"end_line":12,"end_character":38},"updated":"2016-03-16 12:11:15.000000000","message":"some extra spaces here in beginning","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"305e3723c3a6305f50ddb16ddb36781ffa69beee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#  [*amqp_durable_queues*]"},{"line_number":11,"context_line":"#    (optional) Boolean. Define queues as \"durable\" to rabbitmq."},{"line_number":12,"context_line":"#    Defaults to $::os_service_default"},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*kombu_ssl_version*]"},{"line_number":15,"context_line":"#   (Optional) SSL version to use (valid only if SSL enabled). \u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_886e7b2d","line":12,"range":{"start_line":10,"start_character":1,"end_line":12,"end_character":38},"in_reply_to":"1af94dfe_b9210ffe","updated":"2016-03-16 13:34:10.000000000","message":"Done","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"187fa77c4e7c83050a5862ffa3f3adbf5e94f30e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"){"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"},{"line_number":154,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_certfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_certfile parameter requires rabbit_use_ssl to be set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_ad19c97b","line":154,"range":{"start_line":154,"start_character":13,"end_line":154,"end_character":32},"updated":"2016-03-16 13:06:39.000000000","message":"What about a case when kombu_ssl_ca_certs is not service_default and set to false? It should be also ok","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"305e3723c3a6305f50ddb16ddb36781ffa69beee","unresolved":false,"context_lines":[{"line_number":151,"context_line":"){"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"},{"line_number":154,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_certfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_certfile parameter requires rabbit_use_ssl to be set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_bc19f87b","line":154,"range":{"start_line":154,"start_character":13,"end_line":154,"end_character":32},"in_reply_to":"1af94dfe_ad19c97b","updated":"2016-03-16 13:34:10.000000000","message":"kombu_ssl_ca_certs should be a string value, so probably we need to add string validation only","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54c0e64bbe5ee167920a40ed9bcb993c5b53b108","unresolved":false,"context_lines":[{"line_number":151,"context_line":"){"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"},{"line_number":154,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_certfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_certfile parameter requires rabbit_use_ssl to be set to true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_9cb07c45","line":154,"range":{"start_line":154,"start_character":13,"end_line":154,"end_character":32},"in_reply_to":"1af94dfe_bc19f87b","updated":"2016-03-16 13:36:08.000000000","message":"the same for kombu_ssl_certfile, kombu_ssl_keyfile and kombu_ssl_version","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"3c058b80dbc70ed40e3084f0389deff0757768fe","unresolved":false,"context_lines":[{"line_number":150,"context_line":"  $heartbeat_rate                       \u003d $::os_service_default,"},{"line_number":151,"context_line":"){"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"},{"line_number":154,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_certfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_certfile parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":"  if !is_service_default($kombu_ssl_keyfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":160,"context_line":"    fail(\u0027The kombu_ssl_keyfile parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":"  if !is_service_default($kombu_ssl_version) and $rabbit_use_ssl !\u003d true {"},{"line_number":163,"context_line":"    fail(\u0027The kombu_ssl_version parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":"  if (is_service_default($kombu_ssl_certfile) and !is_service_default($kombu_ssl_keyfile)) or"},{"line_number":166,"context_line":"    (is_service_default($kombu_ssl_keyfile) and !is_service_default($kombu_ssl_certfile)) {"},{"line_number":167,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be set together\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_d63aea97","line":164,"range":{"start_line":153,"start_character":2,"end_line":164,"end_character":3},"updated":"2016-03-16 11:41:58.000000000","message":"unless $rabbit_use_ssl {\n  unless is_service_default($kombu_ssl_ca_certs) {\n    fail(...)\n  }\n  unless is_service_default($kombu_ssl_certfile) {\n    fail(...)\n  }\n  ...\n}","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54c0e64bbe5ee167920a40ed9bcb993c5b53b108","unresolved":false,"context_lines":[{"line_number":150,"context_line":"  $heartbeat_rate                       \u003d $::os_service_default,"},{"line_number":151,"context_line":"){"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if !is_service_default($kombu_ssl_ca_certs) and $rabbit_use_ssl !\u003d true {"},{"line_number":154,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_certfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_certfile parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":"  if !is_service_default($kombu_ssl_keyfile) and $rabbit_use_ssl !\u003d true {"},{"line_number":160,"context_line":"    fail(\u0027The kombu_ssl_keyfile parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":"  if !is_service_default($kombu_ssl_version) and $rabbit_use_ssl !\u003d true {"},{"line_number":163,"context_line":"    fail(\u0027The kombu_ssl_version parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":"  if (is_service_default($kombu_ssl_certfile) and !is_service_default($kombu_ssl_keyfile)) or"},{"line_number":166,"context_line":"    (is_service_default($kombu_ssl_keyfile) and !is_service_default($kombu_ssl_certfile)) {"},{"line_number":167,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be set together\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_5c7d546d","line":164,"range":{"start_line":153,"start_character":2,"end_line":164,"end_character":3},"in_reply_to":"1af94dfe_d63aea97","updated":"2016-03-16 13:36:08.000000000","message":"I think it makes sense","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"187fa77c4e7c83050a5862ffa3f3adbf5e94f30e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    $rabbit_host_orig  \u003d $rabbit_host"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  if !is_service_default($rabbit_hosts) and size($rabbit_hosts) \u003e 1 {"},{"line_number":190,"context_line":"    $rabbit_ha_queues_orig \u003d true"},{"line_number":191,"context_line":"  } else {"},{"line_number":192,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_0d06fdcd","line":189,"range":{"start_line":189,"start_character":26,"end_line":189,"end_character":38},"updated":"2016-03-16 13:06:39.000000000","message":"Please validate or transform to an array $rabbit_hosts. This will work incorrectly, for example:\n\n$rabbit_hosts \u003d \u0027127.0.0.1:5900\u0027","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"305e3723c3a6305f50ddb16ddb36781ffa69beee","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    $rabbit_host_orig  \u003d $rabbit_host"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  if !is_service_default($rabbit_hosts) and size($rabbit_hosts) \u003e 1 {"},{"line_number":190,"context_line":"    $rabbit_ha_queues_orig \u003d true"},{"line_number":191,"context_line":"  } else {"},{"line_number":192,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1af94dfe_48a0f343","line":189,"range":{"start_line":189,"start_character":26,"end_line":189,"end_character":38},"in_reply_to":"1af94dfe_0d06fdcd","updated":"2016-03-16 13:34:10.000000000","message":"Array validation is at 174 line. The only thing we need here is to check $rabbit_hosts_orig instead of $rabbit_hosts","commit_id":"4c915480122671ad6ce607278a9e6d20a3f9e3f6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"950643414e28d088326a008203ea142e3e249ce0","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if !is_service_default($rabbit_hosts) {"},{"line_number":185,"context_line":"    $rabbit_hosts_orig \u003d join($rabbit_hosts, \u0027,\u0027)"},{"line_number":186,"context_line":"    if size($rabbit_hosts) \u003e 1 {"},{"line_number":187,"context_line":"      $rabbit_ha_queues_orig \u003d true"},{"line_number":188,"context_line":"    } else {"},{"line_number":189,"context_line":"      $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1af94dfe_246f81c6","line":186,"updated":"2016-03-16 17:26:19.000000000","message":"Do we want an \u0027and !is_service_default($rabbit_ha_queues)\u0027 here?  basically we\u0027re doing auto determination of rabbit ha queues if rabbit_hosts \u003e 1 but we are not providing a way for a user to override this with $rabbit_ha_queues","commit_id":"eccdc81f7abc93d553a5f3a4ae59a26c54b30794"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1d3b2c5eb4d83efa52ef2c21a6f756ac8a657547","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if !is_service_default($rabbit_hosts) {"},{"line_number":185,"context_line":"    $rabbit_hosts_orig \u003d join($rabbit_hosts, \u0027,\u0027)"},{"line_number":186,"context_line":"    if size($rabbit_hosts) \u003e 1 {"},{"line_number":187,"context_line":"      $rabbit_ha_queues_orig \u003d true"},{"line_number":188,"context_line":"    } else {"},{"line_number":189,"context_line":"      $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1af94dfe_e4dd9915","line":186,"in_reply_to":"1af94dfe_246f81c6","updated":"2016-03-16 17:31:45.000000000","message":"if rabbit_hosts \u003e 1 we should always set rabbit_ha_queues to true, isn\u0027t? that\u0027s why I think we shouldn\u0027t accept user value here","commit_id":"eccdc81f7abc93d553a5f3a4ae59a26c54b30794"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f16b1d29a24e62f12714c409ed3368fda88cf67b","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if !is_service_default($rabbit_hosts) {"},{"line_number":185,"context_line":"    $rabbit_hosts_orig \u003d join($rabbit_hosts, \u0027,\u0027)"},{"line_number":186,"context_line":"    if size($rabbit_hosts) \u003e 1 {"},{"line_number":187,"context_line":"      $rabbit_ha_queues_orig \u003d true"},{"line_number":188,"context_line":"    } else {"},{"line_number":189,"context_line":"      $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1af94dfe_a4827192","line":186,"in_reply_to":"1af94dfe_e4dd9915","updated":"2016-03-16 17:37:24.000000000","message":"you are right. I\u0027ve changed a bit this behavior.","commit_id":"eccdc81f7abc93d553a5f3a4ae59a26c54b30794"}]}
