)]}'
{"manifests/messaging_rabbit.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fd28c299565ad0e905fad24d17b62ac1cd84f94f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } else {"},{"line_number":198,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":201,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_710ac07a","line":198,"range":{"start_line":198,"start_character":6,"end_line":198,"end_character":24},"updated":"2016-03-17 12:11:14.000000000","message":"this value by default is \u0027rabbit_hosts \u003d $rabbit_host:$rabbit_port\u0027\n\nhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L105\n\nso will be used rabbit_host and rabbit_port parameters (not from puppet, from config). Do we need this parameter if we have only one rabbit host? May be just to $os_service_default","commit_id":"a0947ac7517c104d50bec813d52bb846fd99df90"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7620f0dad438ba646d878f7350488e3e5ec8bb1d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } else {"},{"line_number":198,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":201,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_5d0b498e","line":198,"range":{"start_line":198,"start_character":6,"end_line":198,"end_character":24},"in_reply_to":"1af94dfe_710ac07a","updated":"2016-03-17 15:33:22.000000000","message":"So why should we allow this case? Is there a time when we would want to configure rabbit but not provide either $rabbit_hosts or $rabbit_host/$rabbit_port?  This else seems like it should be a failure?","commit_id":"a0947ac7517c104d50bec813d52bb846fd99df90"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"bba17b582bd0462593f9f1a756f8beccfb242cd2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } else {"},{"line_number":198,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":201,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_7110005a","line":198,"range":{"start_line":198,"start_character":6,"end_line":198,"end_character":24},"in_reply_to":"1af94dfe_710ac07a","updated":"2016-03-17 12:14:54.000000000","message":"Your point is valid but I\u0027m keeping the same behavior as we have right now in puppet-modules. So, let\u0027s decide here which way we should follow.","commit_id":"a0947ac7517c104d50bec813d52bb846fd99df90"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0eb5fa9506440e0830bf8e0a698c7bfc07683630","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } else {"},{"line_number":198,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":201,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_343946a5","line":198,"range":{"start_line":198,"start_character":6,"end_line":198,"end_character":24},"in_reply_to":"1af94dfe_7110005a","updated":"2016-03-17 12:19:24.000000000","message":"Then, we need to know more opinions here and now :)","commit_id":"a0947ac7517c104d50bec813d52bb846fd99df90"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"913405c0e8b5108681f1a10dd27605d826a8f55c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"      $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"},{"line_number":190,"context_line":"    }"},{"line_number":191,"context_line":"    # Do not set rabbit_port and rabbit_host"},{"line_number":192,"context_line":"    $rabbit_port_orig \u003d $::os_service_default"},{"line_number":193,"context_line":"    $rabbit_host_orig \u003d $::os_service_default"},{"line_number":194,"context_line":"  } else {"},{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa0719c6_b886e0d8","line":193,"range":{"start_line":192,"start_character":4,"end_line":193,"end_character":45},"updated":"2016-03-23 14:04:47.000000000","message":"don\u0027t need that, when rabbit_hosts is set rabbit_port and rabbit_host will be ignored","commit_id":"483edaef0b9c3316d6332e260400aedfe3535a8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"913405c0e8b5108681f1a10dd27605d826a8f55c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    $rabbit_host_orig \u003d $::os_service_default"},{"line_number":194,"context_line":"  } else {"},{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } elsif (!is_service_default($rabbit_host) and is_service_default($rabbit_port)) or (is_service_default($rabbit_host) and !is_service_default($rabbit_port)) {"},{"line_number":198,"context_line":"      fail(\u0027Rabbit host and port should be provided together\u0027)"},{"line_number":199,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa0719c6_d8e594dc","line":196,"range":{"start_line":196,"start_character":6,"end_line":196,"end_character":24},"updated":"2016-03-23 14:04:47.000000000","message":"why we need that? let\u0027s just use different parameters rabbit_host and rabbit_port without rabbit_hosts","commit_id":"483edaef0b9c3316d6332e260400aedfe3535a8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"913405c0e8b5108681f1a10dd27605d826a8f55c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    if !is_service_default($rabbit_host) and !is_service_default($rabbit_port) {"},{"line_number":196,"context_line":"      $rabbit_hosts_orig \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":197,"context_line":"    } elsif (!is_service_default($rabbit_host) and is_service_default($rabbit_port)) or (is_service_default($rabbit_host) and !is_service_default($rabbit_port)) {"},{"line_number":198,"context_line":"      fail(\u0027Rabbit host and port should be provided together\u0027)"},{"line_number":199,"context_line":"    } else {"},{"line_number":200,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":201,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa0719c6_98bcbcdd","line":198,"range":{"start_line":198,"start_character":6,"end_line":198,"end_character":62},"updated":"2016-03-23 14:04:47.000000000","message":"why? we can pass rabbit_host with standard port, can\u0027t we?","commit_id":"483edaef0b9c3316d6332e260400aedfe3535a8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"913405c0e8b5108681f1a10dd27605d826a8f55c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    } else {"},{"line_number":200,"context_line":"      $rabbit_hosts_orig \u003d $::os_service_default"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":203,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"},{"line_number":204,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"},{"line_number":205,"context_line":"  }"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa0719c6_7867284d","line":203,"range":{"start_line":202,"start_character":2,"end_line":203,"end_character":41},"updated":"2016-03-23 14:04:47.000000000","message":"let\u0027s use just $rabbit_port and $rabbit_host","commit_id":"483edaef0b9c3316d6332e260400aedfe3535a8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"282abffd05307d20ef10f0fc9a348eb91cde79f2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    $rabbit_port_orig  \u003d $::os_service_default"},{"line_number":193,"context_line":"    $rabbit_host_orig  \u003d $::os_service_default"},{"line_number":194,"context_line":"  } else {"},{"line_number":195,"context_line":"    $rabbit_hosts_orig     \u003d \"${rabbit_host}:${rabbit_port}\""},{"line_number":196,"context_line":"    $rabbit_port_orig      \u003d $rabbit_port"},{"line_number":197,"context_line":"    $rabbit_host_orig      \u003d $rabbit_host"},{"line_number":198,"context_line":"    $rabbit_ha_queues_orig \u003d $rabbit_ha_queues"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa0719c6_2966cb50","side":"PARENT","line":195,"updated":"2016-03-24 11:28:53.000000000","message":"let\u0027s just remove only 195 line.\n\nSo, if someone will pass rabbit_hosts - we will set this and will remove _host _port\n\nIf someone will not pass _hosts - we will set _host _port if present.\n\nIt will help to avoid duplication parameters when we have _hosts or _host/_port","commit_id":"14b9a2d9f6cf16d5cff5f31bbf7b56052b33c498"}],"releasenotes/notes/fix-rabbit-hosts-28d67e588522e973.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb4b2e6f5bb5ebea55f5bd186c31d8012e4b4737","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Improve checks for rabbit host, port and hosts parameters"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa0719c6_de3907d9","line":1,"updated":"2016-03-23 11:43:55.000000000","message":"I like this effort of release note: thanks a lot!\nBut since this module was not released and won\u0027t be release for Mitaka, I suggest we don\u0027t add notes yet.\n\nThough we\u0027ll create a first note when doing the first release, a bit like puppet-mistral or puppet-zaqar is doing (free free to look).","commit_id":"e3433a3df4434a4fda6127e6bf984f96eaf6904b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"fed08a75ce5cb753237f6d05b42d9aef104d4d11","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Improve checks for rabbit host, port and hosts parameters"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa0719c6_e7271ac8","line":1,"in_reply_to":"fa0719c6_de3907d9","updated":"2016-03-23 12:40:10.000000000","message":"Done","commit_id":"e3433a3df4434a4fda6127e6bf984f96eaf6904b"}]}
