)]}'
{"manifests/policy.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"61d63a80c421fb13cbc2c935f7d9bce479a312c5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $policy_default_rule \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $policy_dirs         \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($policy_dirs) and is_array($policy_dirs) {"},{"line_number":33,"context_line":"    $policy_dirs_orig \u003d join($policy_dirs, \u0027,\u0027)"},{"line_number":34,"context_line":"  } else {"},{"line_number":35,"context_line":"    $policy_dirs_orig \u003d $policy_dirs"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_7b56c506","line":32,"updated":"2016-04-07 14:17:18.000000000","message":"why not dropping this conditional and use any2array function?","commit_id":"979ad4a888e4082223baf59afb287db2c3782775"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"214a25c00ac91123a18f75ca426834bb6c777260","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $policy_default_rule \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $policy_dirs         \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($policy_dirs) and is_array($policy_dirs) {"},{"line_number":33,"context_line":"    $policy_dirs_orig \u003d join($policy_dirs, \u0027,\u0027)"},{"line_number":34,"context_line":"  } else {"},{"line_number":35,"context_line":"    $policy_dirs_orig \u003d $policy_dirs"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_6008d1da","line":32,"in_reply_to":"9a061dce_0a181474","updated":"2016-04-07 15:13:03.000000000","message":"We\u0027ve discussed this question with the team (and Alex Schultz) - I\u0027ll rewrite code to be permissive.","commit_id":"979ad4a888e4082223baf59afb287db2c3782775"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e76d48780562fdd1543d068f857b0d235b0a7706","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $policy_default_rule \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $policy_dirs         \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($policy_dirs) and is_array($policy_dirs) {"},{"line_number":33,"context_line":"    $policy_dirs_orig \u003d join($policy_dirs, \u0027,\u0027)"},{"line_number":34,"context_line":"  } else {"},{"line_number":35,"context_line":"    $policy_dirs_orig \u003d $policy_dirs"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_a08149fd","line":32,"in_reply_to":"9a061dce_0a181474","updated":"2016-04-07 15:15:11.000000000","message":"no strong opinion. this code is just adding more conditionals...","commit_id":"979ad4a888e4082223baf59afb287db2c3782775"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"574aeff6d979c7f99e4ed9c48cb6b6493bcae4f6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $policy_default_rule \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $policy_dirs         \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($policy_dirs) and is_array($policy_dirs) {"},{"line_number":33,"context_line":"    $policy_dirs_orig \u003d join($policy_dirs, \u0027,\u0027)"},{"line_number":34,"context_line":"  } else {"},{"line_number":35,"context_line":"    $policy_dirs_orig \u003d $policy_dirs"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_0a181474","line":32,"in_reply_to":"9a061dce_7b56c506","updated":"2016-04-07 14:46:10.000000000","message":"We had a small discussion with degorenko - for \"list parameters\" we preferred strict policy (pass array, not string or something else).\n\"Explicit is better than implicit\" :)\n\nYou disagree?","commit_id":"979ad4a888e4082223baf59afb287db2c3782775"}]}