)]}'
{"id":"openstack%2Fpuppet-oslo~675405","triplet_id":"openstack%2Fpuppet-oslo~master~If5fb021a6864abbe95f4d23281484cb859537f3b","project":"openstack/puppet-oslo","branch":"master","topic":"heartbeat","hashtags":[],"change_id":"If5fb021a6864abbe95f4d23281484cb859537f3b","subject":"Introduce the new `heartbeat_in_pthread` oslo.messaging option.","status":"MERGED","created":"2019-08-08 16:42:45.000000000","updated":"2019-08-10 03:20:53.000000000","submitted":"2019-08-10 03:20:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"675405-1565407253159-0fc9d827","meta_rev_id":"744a40b6881fe6756c983d3b0bbb92716dfcd98d","_number":675405,"virtual_id_number":675405,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":2,"date":"2019-08-10 03:20:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-08-09 12:17:07.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-08-10 01:59:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-08-10 01:59:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-09 12:17:07.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-08-10 01:59:23.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-08-10 03:20:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cc74e92398423714b444a5b4db0d0e5bc8128f15","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-08-08 16:42:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0abd4baa889357ef94a8598ce2627312a3a5137a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 18:25:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-lint-ubuntu-bionic/0aab582/ : SUCCESS in 4m 48s\n- puppet-openstack-syntax-5-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-syntax-5-ubuntu-bionic/4d7ab64/ : SUCCESS in 4m 55s\n- puppet-openstack-syntax-6-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-syntax-6-ubuntu-bionic/ebbee4b/ : SUCCESS in 3m 54s\n- puppet-openstack-unit-5.5-centos-7 https://logs.opendev.org/05/675405/1/check/puppet-openstack-unit-5.5-centos-7/827c8ff/ : SUCCESS in 17m 07s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-unit-6.4-ubuntu-bionic/a683b5b/ : SUCCESS in 11m 00s\n- puppet-openstack-unit-latest-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-unit-latest-ubuntu-bionic/e62e487/ : SUCCESS in 10m 58s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/f5e21f1/ : SUCCESS in 54m 08s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/a6ad588/ : SUCCESS in 1h 00m 44s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/f090c26/ : SUCCESS in 1h 06m 32s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/a9b9b03/ : FAILURE in 58m 53s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/4e0dde1/ : FAILURE in 43m 54s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/293c97f/ : FAILURE in 28m 27s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/1411a61/ : FAILURE in 25m 21s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://logs.opendev.org/05/675405/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/25a61e1/ : FAILURE in 22m 05s (non-voting)\n- puppet-openstack-beaker-centos-7 https://logs.opendev.org/05/675405/1/check/puppet-openstack-beaker-centos-7/53b2701/ : SUCCESS in 6m 51s\n- puppet-openstack-beaker-ubuntu-bionic https://logs.opendev.org/05/675405/1/check/puppet-openstack-beaker-ubuntu-bionic/f4848fe/ : SUCCESS in 7m 01s (non-voting)\n- build-openstack-releasenotes https://logs.opendev.org/05/675405/1/check/build-openstack-releasenotes/4cf4f67/html/ : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":1},{"id":"d9b23782e74b3fb5f495e5ae694a9ecacd426d53","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-08 23:10:35.000000000","message":"Patch Set 1: Code-Review-1\n\ncould you please add unit tests for this new option, in spec/defines/oslo_messaging_rabbit_spec.rb\n\nthanks!","accounts_in_message":[],"_revision_number":1},{"id":"fcb423d8158e36475ae4757464aa0c8ee75422f8","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-08-09 08:20:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"adda0cac5f75698747556c35848573990f05d95d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 09:42:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-lint-ubuntu-bionic/5cbdb58/ : SUCCESS in 4m 47s\n- puppet-openstack-syntax-5-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-syntax-5-ubuntu-bionic/13a0478/ : SUCCESS in 4m 50s\n- puppet-openstack-syntax-6-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-syntax-6-ubuntu-bionic/1122532/ : SUCCESS in 5m 12s\n- puppet-openstack-unit-5.5-centos-7 https://logs.opendev.org/05/675405/2/check/puppet-openstack-unit-5.5-centos-7/82b479a/ : SUCCESS in 11m 01s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-unit-6.4-ubuntu-bionic/024ec7c/ : SUCCESS in 9m 59s\n- puppet-openstack-unit-latest-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-unit-latest-ubuntu-bionic/60a1b5b/ : SUCCESS in 11m 15s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/a1d1a97/ : SUCCESS in 50m 30s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/ba12ed7/ : SUCCESS in 59m 04s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/7076917/ : SUCCESS in 1h 16m 00s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/f6cb607/ : SUCCESS in 49m 42s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/b21b4fd/ : FAILURE in 35m 48s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/b52a62f/ : FAILURE in 47m 09s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/962f301/ : FAILURE in 42m 00s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://logs.opendev.org/05/675405/2/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/4ae7ae8/ : FAILURE in 40m 37s (non-voting)\n- puppet-openstack-beaker-centos-7 https://logs.opendev.org/05/675405/2/check/puppet-openstack-beaker-centos-7/b11781d/ : SUCCESS in 9m 01s\n- puppet-openstack-beaker-ubuntu-bionic https://logs.opendev.org/05/675405/2/check/puppet-openstack-beaker-ubuntu-bionic/36cb154/ : SUCCESS in 9m 48s (non-voting)\n- build-openstack-releasenotes https://logs.opendev.org/05/675405/2/check/build-openstack-releasenotes/980c55e/html/ : SUCCESS in 4m 18s","accounts_in_message":[],"_revision_number":2},{"id":"ce44b0d4d604d99054ecb48516988ae3e147f9e2","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-09 12:17:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2173da1f2a199c3b47026c4ecab1461d3f215a79","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-08-10 01:59:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b7d9858569576194b58995f980349b0a63e267c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-10 01:59:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9bb2487476bbaf738d482975624cff86a9941963","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-10 03:20:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://logs.opendev.org/05/675405/2/gate/puppet-openstack-lint-ubuntu-bionic/3e72aac/ : SUCCESS in 3m 51s\n- puppet-openstack-syntax-5-ubuntu-bionic https://logs.opendev.org/05/675405/2/gate/puppet-openstack-syntax-5-ubuntu-bionic/e36db37/ : SUCCESS in 3m 57s\n- puppet-openstack-syntax-6-ubuntu-bionic https://logs.opendev.org/05/675405/2/gate/puppet-openstack-syntax-6-ubuntu-bionic/3b89c7a/ : SUCCESS in 3m 59s\n- puppet-openstack-unit-5.5-centos-7 https://logs.opendev.org/05/675405/2/gate/puppet-openstack-unit-5.5-centos-7/769612b/ : SUCCESS in 9m 33s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://logs.opendev.org/05/675405/2/gate/puppet-openstack-unit-6.4-ubuntu-bionic/64e930c/ : SUCCESS in 6m 53s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://logs.opendev.org/05/675405/2/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/95ac69f/ : SUCCESS in 57m 29s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://logs.opendev.org/05/675405/2/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/5c04879/ : SUCCESS in 52m 21s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://logs.opendev.org/05/675405/2/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/cdff41e/ : SUCCESS in 1h 13m 57s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://logs.opendev.org/05/675405/2/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/2cd9b39/ : SUCCESS in 48m 49s\n- puppet-openstack-beaker-centos-7 https://logs.opendev.org/05/675405/2/gate/puppet-openstack-beaker-centos-7/9f4a522/ : SUCCESS in 6m 49s\n- build-openstack-releasenotes https://logs.opendev.org/05/675405/2/gate/build-openstack-releasenotes/ea0b271/html/ : SUCCESS in 2m 57s","accounts_in_message":[],"_revision_number":2},{"id":"a6366449fb6107a231bef23b30bc838427ba75a2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-10 03:20:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"23eb13c6c86ef7b3a1deb9b1b8f636a8c072908d","revisions":{"3f282afe22c6b26221cdc4391e5f9a347608059a":{"kind":"REWORK","_number":1,"created":"2019-08-08 16:42:45.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/05/675405/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-oslo","ref":"refs/changes/05/675405/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/1"}}},"commit":{"parents":[{"commit":"e69e317002222a372d1e2afb2b969d3d17122ac7","subject":"Sync Sphinx requirement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/e69e317002222a372d1e2afb2b969d3d17122ac7"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-08-08 16:39:53.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-08-08 16:42:37.000000000","tz":120},"subject":"Introduce the new `heartbeat_in_pthread` oslo.messaging option.","message":"Introduce the new `heartbeat_in_pthread` oslo.messaging option.\n\noslo.messaging RabbitMQ driver have now a new option that allow user to\nrun the RabbitMQ AMQP heartbeat over a native python thread.\n\nThese change allow user to use this new option.\n\nFor further reading:\nhttps://review.opendev.org/#/c/663074/\n\nChange-Id: If5fb021a6864abbe95f4d23281484cb859537f3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/3f282afe22c6b26221cdc4391e5f9a347608059a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/3f282afe22c6b26221cdc4391e5f9a347608059a"}]},"branch":"refs/heads/master"},"23eb13c6c86ef7b3a1deb9b1b8f636a8c072908d":{"kind":"REWORK","_number":2,"created":"2019-08-09 08:20:37.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/05/675405/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-oslo","ref":"refs/changes/05/675405/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-oslo refs/changes/05/675405/2"}}},"commit":{"parents":[{"commit":"e69e317002222a372d1e2afb2b969d3d17122ac7","subject":"Sync Sphinx requirement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/e69e317002222a372d1e2afb2b969d3d17122ac7"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-08-08 16:39:53.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2019-08-09 08:20:25.000000000","tz":120},"subject":"Introduce the new `heartbeat_in_pthread` oslo.messaging option.","message":"Introduce the new `heartbeat_in_pthread` oslo.messaging option.\n\noslo.messaging RabbitMQ driver have now a new option that allow user to\nrun the RabbitMQ AMQP heartbeat over a native python thread.\n\nThese change allow user to use this new option.\n\nFor further reading:\nhttps://review.opendev.org/#/c/663074/\n\nChange-Id: If5fb021a6864abbe95f4d23281484cb859537f3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/23eb13c6c86ef7b3a1deb9b1b8f636a8c072908d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-oslo/commit/23eb13c6c86ef7b3a1deb9b1b8f636a8c072908d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}