)]}'
{"manifests/db.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc62e1f26feb2c6b5fb96bc1a660cd39d3ca191d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"  $backend                                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":115,"context_line":"  Boolean $manage_backend_package          \u003d true,"},{"line_number":116,"context_line":"  $backend_package_ensure                  \u003d present,"},{"line_number":117,"context_line":"  Optional[Oslo::Dbconn] $connection       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn] $slave_connection \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":119,"context_line":"  $mysql_sql_mode                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $connection_recycle_time                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"a633f18a_2c858766","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":24},"updated":"2023-06-19 08:12:27.000000000","message":"I\u0027d probably suggest we use `Variant[Oslo::DBconn, Openstacklib::ServiceDefault]` instead of including service default in DBconn type.\n\nhttps://review.opendev.org/c/openstack/puppet-openstacklib/+/886378","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"5849c2c123b52cdec48db9e16d288386a3812040","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $backend                                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":115,"context_line":"  Boolean $manage_backend_package          \u003d true,"},{"line_number":116,"context_line":"  $backend_package_ensure                  \u003d present,"},{"line_number":117,"context_line":"  Optional[Oslo::Dbconn] $connection       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn] $slave_connection \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":119,"context_line":"  $mysql_sql_mode                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $connection_recycle_time                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"b79364e9_1c8eed10","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":24},"in_reply_to":"333315cc_0950a587","updated":"2023-06-21 09:08:03.000000000","message":"Done","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac7c78242349fdb5c077c444a3114caf1db73e24","unresolved":true,"context_lines":[{"line_number":114,"context_line":"  $backend                                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":115,"context_line":"  Boolean $manage_backend_package          \u003d true,"},{"line_number":116,"context_line":"  $backend_package_ensure                  \u003d present,"},{"line_number":117,"context_line":"  Optional[Oslo::Dbconn] $connection       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn] $slave_connection \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":119,"context_line":"  $mysql_sql_mode                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $connection_recycle_time                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"333315cc_0950a587","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":24},"in_reply_to":"84b294f7_3a516ac9","updated":"2023-06-20 01:14:15.000000000","message":"\u003e Agree, but this needs a new version of openstacklib included in metadata. Which I do not know when in happens.\n\nWe test using the latest master instead of a released version so you can use it as soon as the openstacklib change is merged. We bump the requirements before making a new release so you don\u0027t have to care about metadata.json modification for now\n\n\u003e Question is, if you ever will use DBConn without Servicedefault ?\nProbably you are correct (When I was trying to implement some types for config options I actually did include service defaults[1]). Let\u0027s include ServiceDefault for now and consider splitting it later if needed.\n\n[1] https://review.opendev.org/c/openstack/puppet-openstacklib/+/816109","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"0b0d98ff214dabfd3de43112755b8839b3ac9818","unresolved":true,"context_lines":[{"line_number":114,"context_line":"  $backend                                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":115,"context_line":"  Boolean $manage_backend_package          \u003d true,"},{"line_number":116,"context_line":"  $backend_package_ensure                  \u003d present,"},{"line_number":117,"context_line":"  Optional[Oslo::Dbconn] $connection       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn] $slave_connection \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":119,"context_line":"  $mysql_sql_mode                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $connection_recycle_time                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"84b294f7_3a516ac9","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":24},"in_reply_to":"a633f18a_2c858766","updated":"2023-06-19 21:21:43.000000000","message":"Agree, but this needs a new version of openstacklib included in metadata. Which I do not know when in happens.\n\nQuestion is, if you ever will use DBConn without Servicedefault ?\nIf yes, we should define Dbconn without ServiceDefault and use youre suggestion, If no, we could use it like I did.\n\nIt\u0027s up to you to decide.","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"}],"types/dbconn/mongodb.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a4c7c64b8e03f0f0e0d4b3ea61c6ba6becbb64f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"type Oslo::Dbconn::Mongodb \u003d Pattern[/^mongodb:\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?/]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bcfd6cf4_6196b67d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":72},"updated":"2023-06-19 08:05:16.000000000","message":"we should have removed this when we removed support for mongodb. I\u0027ve pushed https://review.opendev.org/c/openstack/puppet-oslo/+/886374 to remove this.","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"0b0d98ff214dabfd3de43112755b8839b3ac9818","unresolved":false,"context_lines":[{"line_number":1,"context_line":"type Oslo::Dbconn::Mongodb \u003d Pattern[/^mongodb:\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?/]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"382a8229_a776bfdb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":72},"in_reply_to":"bcfd6cf4_6196b67d","updated":"2023-06-19 21:21:43.000000000","message":"ok I removed it in the new commit, will adapt again if youre request is merged.","commit_id":"4312d04e22e7226b699fe1a6d1b31ee157dd85a2"}]}