)]}'
{"manifests/northd.pp":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"06c988e78db5a4174f24fec937c803ef9927e92e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"},{"line_number":24,"context_line":"        group   \u003d\u003e \u0027root\u0027,"},{"line_number":25,"context_line":"        content \u003d\u003e \"[Service]"},{"line_number":26,"context_line":"  Environment\u003d\\\"NORTHD_OPTS\u003d--db-nb-addr\u003d${dbs_listen_ip} --db-sb-addr\u003d${dbs_listen_ip}\\\"\","},{"line_number":27,"context_line":"        before  \u003d\u003e Service[\u0027northd\u0027],"},{"line_number":28,"context_line":"        require \u003d\u003e File[\u0027/etc/systemd/system/ovn-northd.service.d\u0027]"},{"line_number":29,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a77a97e_aa969bed","line":26,"updated":"2016-11-17 15:13:33.000000000","message":"The corresponding patch in ovs [1] to use this env variable expects \"OVN_NORTHD_OPTS\".\n\n[1] - https://patchwork.ozlabs.org/patch/696112/","commit_id":"f8ed0ef30cf7ac71718cb143b5c1068659fdd8ae"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"32b578a1ee01023590b23c0be3a182844e6a5291","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"},{"line_number":24,"context_line":"        group   \u003d\u003e \u0027root\u0027,"},{"line_number":25,"context_line":"        content \u003d\u003e \"[Service]"},{"line_number":26,"context_line":"  Environment\u003d\\\"NORTHD_OPTS\u003d--db-nb-addr\u003d${dbs_listen_ip} --db-sb-addr\u003d${dbs_listen_ip}\\\"\","},{"line_number":27,"context_line":"        before  \u003d\u003e Service[\u0027northd\u0027],"},{"line_number":28,"context_line":"        require \u003d\u003e File[\u0027/etc/systemd/system/ovn-northd.service.d\u0027]"},{"line_number":29,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a77a97e_852f0587","line":26,"in_reply_to":"7a77a97e_aa969bed","updated":"2016-11-17 18:29:11.000000000","message":"yep, I changed it when I updated the patch in OVS.","commit_id":"f8ed0ef30cf7ac71718cb143b5c1068659fdd8ae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4d7fd90a6b80ce395f2fb2a2c065833f2ebcdb60","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_c94e686e","line":20,"updated":"2016-11-18 03:37:14.000000000","message":"Rather than managing systemd configuration files, is it possible to fix it in the packaging such that it would load an EnvironmentFile\u003d-/etc/sysconfig/ovn-northd or something?  I\u0027m not really keen on managing systemd stuff via puppet.  basic sysconfig syntax is fairly straight forward to manage and there\u0027s precident for doing that.","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"96a97e1244db677825ed145b19552658c654a4c7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_be8f4bcb","line":20,"in_reply_to":"7a77a97e_26460d4f","updated":"2016-11-21 15:12:28.000000000","message":"I guess, but we generally try not to use content or templates as they can interfere with system provided configurations or other config updates from the user as they just overwrite everything.  I guess the question would be is there a less intrusive way of doing this since this?  With the sysconfig method, it\u0027s just a shell var and it\u0027s easily updated in a targeted approach without writing all of it.","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f4e2940a1d14520932c77bed6256cd5337ecd6e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_41e733ac","line":20,"in_reply_to":"7a77a97e_2b3bf89d","updated":"2016-11-21 16:38:48.000000000","message":"It\u0027s not today, yes. But if at some point down the road packaging changes and RDO ships a local.conf, then yes it would be changing it.  I\u0027m aware it doesn\u0027t exist today, I\u0027m just asking if there\u0027s a better implementation.  \n\nHonestly this seems like a hack in puppet and not a clean implementation of a configuration.  That\u0027s all.","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bb65135dae2a563fc4d7ea56b64a1a6eec02e17b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_7a34d549","line":20,"in_reply_to":"7a77a97e_3a8180fc","updated":"2016-11-21 18:37:23.000000000","message":"Alex is right, we usually don\u0027t manage these files and directory with Puppet because they are included in packaging.  I\u0027m not a fan on this patch and its implementation but it sounds like this is how it currently works; just please keep in mind this is not how we usually configure services.","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e541b0f502ff1a24e42dc50ab851d38fd503eb6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_3a8180fc","line":20,"in_reply_to":"7a77a97e_41e733ac","updated":"2016-11-21 17:29:57.000000000","message":"The filename isn\u0027t important.  We could call it \"tripleo.conf\" if \"local.conf\" seems to risky to be reused by something else.\n\nPackaging would never put something in this directory btw.","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"4837f325c88f1e567962bd2f2b2a7c5714cf182b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_1a9041ec","line":20,"in_reply_to":"7a77a97e_7a34d549","updated":"2016-11-21 18:43:45.000000000","message":"I have the ability to change how this works upstream, but I just want to be convinced of why this is wrong.  I get that most of /etc/systemd/ is system or package-owned, but this particular directory: /etc/systemd/system/ovn-northd.service.d/ is, as I understand it, *not* owned by packages, and is a feature of systemd for how you customize the service configuration provided by the package.  Do you think we have misunderstood this systemd feature?\n\nFor more info, see:\n\nhttps://fedoraproject.org/wiki/Systemd#How_do_I_customize_a_unit_file.2F_add_a_custom_unit_file.3F\n\nor:\n\n\"Example 2. Overriding vendor settings\"\nhttps://www.freedesktop.org/software/systemd/man/systemd.unit.html","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e8a09abe3e830b20e67a33f9292a4c875a032d29","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_2b3bf89d","line":20,"in_reply_to":"7a77a97e_be8f4bcb","updated":"2016-11-21 15:40:35.000000000","message":"To be clear, this is *not* overwriting any system provided configuration.  This is a method provided by systemd to provide customizations.  The only customization we\u0027re providing here is an environment variable.  I really don\u0027t see this as different from what you\u0027re describing ...","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"32c760882163375ed75e9447d29c80b52caeff72","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        group  \u003d\u003e \u0027root\u0027"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      file { \u0027/etc/systemd/system/ovn-northd.service.d/local.conf\u0027:"},{"line_number":21,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":22,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":23,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_26460d4f","line":20,"in_reply_to":"7a77a97e_c94e686e","updated":"2016-11-18 16:15:14.000000000","message":"We could add that, it just seemed like a \"legacy\" approach since this approach is something generic provided by systemd automatically.  I imagine this change would look incredibly similar with an EnvironmentFile.  It would just be a different filename and the content wouldn\u0027t include \"[Service]\".","commit_id":"19df073a243905996d67dcb6f99cfd986a89a3cb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b053afb5499b499ea1cefa7f12eac8a7ba6e3da1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"class ovn::northd($dbs_listen_ip \u003d \u00270.0.0.0\u0027) {"},{"line_number":11,"context_line":"    include ::ovn::params"},{"line_number":12,"context_line":"    if $::osfamily \u003d\u003d \u0027RedHat\u0027 {"},{"line_number":13,"context_line":"      file { \u0027/etc/sysconfig/ovn-northd\u0027:"},{"line_number":14,"context_line":"        ensure  \u003d\u003e file,"},{"line_number":15,"context_line":"        mode    \u003d\u003e \u00270600\u0027,"},{"line_number":16,"context_line":"        owner   \u003d\u003e \u0027root\u0027,"},{"line_number":17,"context_line":"        group   \u003d\u003e \u0027root\u0027,"},{"line_number":18,"context_line":"        content \u003d\u003e \"OVN_NORTHD_OPTS\u003d--db-nb-addr\u003d${dbs_listen_ip} --db-sb-addr\u003d${dbs_listen_ip}\","},{"line_number":19,"context_line":"        before  \u003d\u003e Service[\u0027northd\u0027]"},{"line_number":20,"context_line":"      }"},{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    service { \u0027northd\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a74a57a_c2c41c94","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":7},"updated":"2016-11-23 14:52:57.000000000","message":"Should us augeas for this.\n\naugeas { \u0027sysconfig-ovn-northd\u0027:\n  context \u003d\u003e \u0027/files/etc/sysconfig/ovn-northd\u0027,\n  changes \u003d\u003e \"set OVN_NORTHD_OPTS \\\"--db-nb-addr\u003d${dbs_listen_ip} --db-sb-addr\u003d${dbs_listen_ip}\\\"\",\n  before  \u003d\u003e Service[\u0027northd\u0027],\n}","commit_id":"4d2fba8fb986ae851811a917aa36e8a24f285f18"}]}
