)]}'
{"manifests/controller.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"ae24a716a15707a1f2fbc7dbb2313017648ab173","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   (optional) List of \u003cbridge-name\u003e:\u003cinterface-name\u003e when doing bridge mapping"},{"line_number":25,"context_line":"#   Defaults to empty list"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ovn::controller("},{"line_number":29,"context_line":"  $ovn_remote,"},{"line_number":30,"context_line":"  $ovn_encap_ip,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a77a97e_1f85e158","line":27,"updated":"2016-11-18 13:27:27.000000000","message":"more than one line, should be remove:)","commit_id":"8a8c697ed88b6e7febd2cfa17a5f6e6377fe04e1"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"ae24a716a15707a1f2fbc7dbb2313017648ab173","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class ovn::controller("},{"line_number":29,"context_line":"  $ovn_remote,"},{"line_number":30,"context_line":"  $ovn_encap_ip,"},{"line_number":31,"context_line":"  $ovn_encap_type \u003d \u0027geneve\u0027,"},{"line_number":32,"context_line":"  $ovn_bridge_mappings \u003d [],"},{"line_number":33,"context_line":"  $bridge_interface_mappings \u003d []"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":"  include ::ovn::params"},{"line_number":36,"context_line":"  include ::vswitch::ovs"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a77a97e_df8fe972","line":33,"range":{"start_line":31,"start_character":1,"end_line":33,"end_character":33},"updated":"2016-11-18 13:27:27.000000000","message":"alignment is better :)","commit_id":"8a8c697ed88b6e7febd2cfa17a5f6e6377fe04e1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"313c7268fc5deb9db76fd24c7a878139c7d578ee","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class ovn::controller("},{"line_number":29,"context_line":"  $ovn_remote,"},{"line_number":30,"context_line":"  $ovn_encap_ip,"},{"line_number":31,"context_line":"  $ovn_encap_type \u003d \u0027geneve\u0027,"},{"line_number":32,"context_line":"  $ovn_bridge_mappings \u003d [],"},{"line_number":33,"context_line":"  $bridge_interface_mappings \u003d []"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":"  include ::ovn::params"},{"line_number":36,"context_line":"  include ::vswitch::ovs"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a77a97e_43f13b6a","line":33,"range":{"start_line":31,"start_character":1,"end_line":33,"end_character":33},"in_reply_to":"7a77a97e_df8fe972","updated":"2016-11-18 16:09:23.000000000","message":"what change are you looking for here exactly?","commit_id":"8a8c697ed88b6e7febd2cfa17a5f6e6377fe04e1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"57eada1a0b95bf3b5fe54e4959c79ddb38f3244a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      before \u003d\u003e Service[\u0027controller\u0027]"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  vs_config { \u0027external_ids:ovn-remote\u0027:"},{"line_number":59,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":60,"context_line":"      value   \u003d\u003e $ovn_remote,"},{"line_number":61,"context_line":"      require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  vs_config { \u0027external_ids:ovn-encap-type\u0027:"},{"line_number":65,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":66,"context_line":"      value   \u003d\u003e $ovn_encap_type,"},{"line_number":67,"context_line":"      require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  vs_config { \u0027external_ids:ovn-encap-ip\u0027:"},{"line_number":71,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":72,"context_line":"      value   \u003d\u003e $ovn_encap_ip,"},{"line_number":73,"context_line":"      require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if ($ovn_bridge_mappings !\u003d []) {"},{"line_number":77,"context_line":"    $mappings \u003d join($ovn_bridge_mappings, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a74a57a_15dbd4ee","line":74,"range":{"start_line":58,"start_character":0,"end_line":74,"end_character":3},"updated":"2016-11-22 21:54:58.000000000","message":"Since we\u0027re adding more vs_config items, it would be beneficial not to duplicate them like this. You can use create_resource with a hash to set all of these at once. \n\nAnd for the mapping stuff below you could follow a similar format or just merge the $config_items with a $mapping_items hash.\n\n  $config_items \u003d { \n    \u0027external_ids:ovn-remote\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_remote },\n    \u0027external_ids:ovn-encap-type\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_type },\n    \u0027external_ids:ovn-encap-ip\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_ip  },\n  }\n\n  if !empty($ovn_bridge_mappings) {\n    $bridge_items \u003d { \u0027external_ids:ovn-bridge-mappings\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e join(any2array($ovn_bridge_mappings), \u0027,\u0027) }\n  } else {\n    $bridge_items \u003d {}\n  }\n  create_resource(\u0027vs_config\u0027, merge($config_items, $bridge_items))\n\n  Service[\u0027openvswitch\u0027] -\u003e vs_config\u003c||\u003e -\u003e Service[\u0027controller\u0027]","commit_id":"46f4934bffbc83dc07da1d81e4319f234228c2ae"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"119e016f3d9028ab65c2da4297c921e2f21351ab","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  $config_items \u003d {"},{"line_number":59,"context_line":"    \u0027external_ids:ovn-remote\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_remote, \u0027ensure\u0027 \u003d\u003e present },"},{"line_number":60,"context_line":"    \u0027external_ids:ovn-encap-type\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_type, \u0027ensure\u0027 \u003d\u003e present },"},{"line_number":61,"context_line":"    \u0027external_ids:ovn-encap-ip\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_ip, \u0027ensure\u0027 \u003d\u003e present  },"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if !empty($ovn_bridge_mappings) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a74a57a_6535e0d8","line":61,"updated":"2016-11-24 12:54:07.000000000","message":"alignment","commit_id":"b0745e8c0b9f90a21ca3d3a83f2a0e58f5494e4d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"026448d34a99a7c6a68c107a1e61f54906449c3d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      before \u003d\u003e Service[\u0027controller\u0027]"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  $config_items \u003d {"},{"line_number":59,"context_line":"    \u0027external_ids:ovn-remote\u0027     \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_remote, \u0027ensure\u0027 \u003d\u003e present },"},{"line_number":60,"context_line":"    \u0027external_ids:ovn-encap-type\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_type, \u0027ensure\u0027 \u003d\u003e present },"},{"line_number":61,"context_line":"    \u0027external_ids:ovn-encap-ip\u0027   \u003d\u003e { \u0027value\u0027 \u003d\u003e $ovn_encap_ip, \u0027ensure\u0027 \u003d\u003e present  },"},{"line_number":62,"context_line":"    \u0027external_ids:hostname\u0027       \u003d\u003e { \u0027value\u0027 \u003d\u003e $::fqdn, \u0027ensure\u0027 \u003d\u003e present  },"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if !empty($ovn_bridge_mappings) {"},{"line_number":66,"context_line":"    $bridge_items \u003d {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a74a57a_f3d950f4","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":3},"updated":"2016-11-28 15:02:26.000000000","message":"the ensure \u003d\u003e present is redundant here. You can drop those.","commit_id":"1d96f90befe23fe8ed6cd2a99abad039f0c57c63"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"026448d34a99a7c6a68c107a1e61f54906449c3d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if !empty($ovn_bridge_mappings) {"},{"line_number":66,"context_line":"    $bridge_items \u003d {"},{"line_number":67,"context_line":"      \u0027external_ids:ovn-bridge-mappings\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e join(any2array($ovn_bridge_mappings), \u0027,\u0027), \u0027ensure\u0027 \u003d\u003e present }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    ovn::controller::bridge { $ovn_bridge_mappings:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a74a57a_739b8018","line":67,"range":{"start_line":67,"start_character":101,"end_line":67,"end_character":120},"updated":"2016-11-28 15:02:26.000000000","message":"same this is not needed","commit_id":"1d96f90befe23fe8ed6cd2a99abad039f0c57c63"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32fb7cb2627cccaba75533a1eb41b0ef296677b9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      hasstatus \u003d\u003e $::ovn::params::ovn_controller_service_status,"},{"line_number":45,"context_line":"      pattern   \u003d\u003e $::ovn::params::ovn_controller_service_pattern,"},{"line_number":46,"context_line":"      enable    \u003d\u003e true,"},{"line_number":47,"context_line":"      require   \u003d\u003e [Vs_config[\u0027external_ids:ovn-remote\u0027],"},{"line_number":48,"context_line":"                    Vs_config[\u0027external_ids:ovn-encap-type\u0027],"},{"line_number":49,"context_line":"                    Vs_config[\u0027external_ids:ovn-encap-ip\u0027]]"},{"line_number":50,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_6a191c88","line":47,"updated":"2016-12-02 21:31:59.000000000","message":"This require is redundant because of the relationship stuff on line line 83. Should just remove it here.","commit_id":"4479e97a116a086b8ccdf20c818aa7aceb8c3150"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32fb7cb2627cccaba75533a1eb41b0ef296677b9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  create_resources(\u0027vs_config\u0027, merge($config_items, $bridge_items))"},{"line_number":83,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e -\u003e Service[\u0027controller\u0027]"},{"line_number":84,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_8a1cb878","line":83,"updated":"2016-12-02 21:31:59.000000000","message":"If someone changes the external_ids:*, do we need to restart the controller? If so switch the -\u003e to a ~\u003e","commit_id":"4479e97a116a086b8ccdf20c818aa7aceb8c3150"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e046e332762d181b49edc6bc2def4556b91bf989","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  create_resources(\u0027vs_config\u0027, merge($config_items, $bridge_items))"},{"line_number":83,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e -\u003e Service[\u0027controller\u0027]"},{"line_number":84,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_7d648448","line":83,"in_reply_to":"3a71b18c_5dbb48e5","updated":"2016-12-02 21:59:49.000000000","message":"Ok so if that\u0027s the case, then put subscribe \u003d\u003e Vs_config[\u0027external_ids:ovn-remote\u0027] for the service up on line 47 and ditch the requires. This covers the requires.","commit_id":"4479e97a116a086b8ccdf20c818aa7aceb8c3150"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"7f4a0bf4c284327992a0262888a6371e38a464f1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  create_resources(\u0027vs_config\u0027, merge($config_items, $bridge_items))"},{"line_number":83,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e -\u003e Service[\u0027controller\u0027]"},{"line_number":84,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_5dbb48e5","line":83,"in_reply_to":"3a71b18c_8a1cb878","updated":"2016-12-02 21:45:41.000000000","message":"It looks like changing the \"ovn-remote\" option will require an ovn-controller restart.  Changes to the other options do not require a restart.","commit_id":"4479e97a116a086b8ccdf20c818aa7aceb8c3150"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"9c73a86a37c6e0cc579d0d19f414d5703ec4f8fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  validate_string($ovn_encap_ip)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  service { \u0027controller\u0027:"},{"line_number":42,"context_line":"      ensure    \u003d\u003e true,"},{"line_number":43,"context_line":"      name      \u003d\u003e $::ovn::params::ovn_controller_service_name,"},{"line_number":44,"context_line":"      hasstatus \u003d\u003e $::ovn::params::ovn_controller_service_status,"},{"line_number":45,"context_line":"      pattern   \u003d\u003e $::ovn::params::ovn_controller_service_pattern,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba5201f7_a24a1c24","line":42,"updated":"2017-01-05 20:34:54.000000000","message":"Indentation is 4 spaces, should be only 2. I see this through out the file","commit_id":"2993274bca274988bd90a5888827ec3ec41776eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2a61ef6d26d85839c127354fce043d2f0089ffe2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      hasstatus \u003d\u003e $::ovn::params::ovn_controller_service_status,"},{"line_number":45,"context_line":"      pattern   \u003d\u003e $::ovn::params::ovn_controller_service_pattern,"},{"line_number":46,"context_line":"      enable    \u003d\u003e true,"},{"line_number":47,"context_line":"      require   \u003d\u003e Vs_config[\u0027external_ids:ovn-remote\u0027]"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  package { $::ovn::params::ovn_controller_package_name:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a71b18c_c64b002a","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":13},"updated":"2016-12-09 15:11:09.000000000","message":"this should be a subscribe if this should trigger a service restart","commit_id":"2993274bca274988bd90a5888827ec3ec41776eb"}],"manifests/controller/bridge.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"57eada1a0b95bf3b5fe54e4959c79ddb38f3244a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"define ovn::controller::bridge {"},{"line_number":3,"context_line":"  include ::vswitch::ovs"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a74a57a_d5fddc6f","line":1,"updated":"2016-11-22 21:54:58.000000000","message":"This needs class documentation, especially if there is a specific format for the name. My preference would be not to use a special format in the name and make the bridge as a parameter.","commit_id":"46f4934bffbc83dc07da1d81e4319f234228c2ae"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"6578eb5b90e46e1210b33ef4a7aadd9e0611c10f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"define ovn::controller::bridge {"},{"line_number":3,"context_line":"  include ::vswitch::ovs"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a74a57a_4603d273","line":1,"in_reply_to":"5a74a57a_d5fddc6f","updated":"2016-11-23 09:22:54.000000000","message":"Hi Alex, I agree. I have document the name in the next version. Since this definition will used with an array of such formatted names, it will be using the specially formatted name.","commit_id":"46f4934bffbc83dc07da1d81e4319f234228c2ae"}],"manifests/controller/port.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"57eada1a0b95bf3b5fe54e4959c79ddb38f3244a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"define ovn::controller::port {"},{"line_number":3,"context_line":"  include ::vswitch::ovs"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a74a57a_35f53083","line":1,"updated":"2016-11-22 21:54:58.000000000","message":"This needs class documentation, especially if there is a specific format for the name. My preference would be not to use a special format in the name and make the bridge and interfaces as  parameters.","commit_id":"46f4934bffbc83dc07da1d81e4319f234228c2ae"}]}
