)]}'
{"manifests/controller.pp":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6ec21f270334da2eded850a9d73e485ae7f03ab5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $datapath_type               \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_dpdk                 \u003d false,"},{"line_number":77,"context_line":"  $ovn_remote_probe_interval   \u003d 60000,"},{"line_number":78,"context_line":"  $ovn_openflow_probe_interval \u003d 5,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::ovn::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_c1e17e2c","line":78,"range":{"start_line":78,"start_character":33,"end_line":78,"end_character":34},"updated":"2019-09-20 08:31:50.000000000","message":"I believe we want this higher: 60s","commit_id":"49f810b0e3f58d6dfc64228b398e583e93040693"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"0204b9e89ccf4b83e2b6cf126becc26330d294e3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $datapath_type               \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_dpdk                 \u003d false,"},{"line_number":77,"context_line":"  $ovn_remote_probe_interval   \u003d 60000,"},{"line_number":78,"context_line":"  $ovn_openflow_probe_interval \u003d 5,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::ovn::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_e1211a4f","line":78,"range":{"start_line":78,"start_character":33,"end_line":78,"end_character":34},"in_reply_to":"3fa7e38b_c1e17e2c","updated":"2019-09-20 08:42:12.000000000","message":"Done","commit_id":"49f810b0e3f58d6dfc64228b398e583e93040693"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"12fed69efb92968f530f852a489228a3d75ae647","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#  (optional) The inactivity probe interval of the OpenFlow"},{"line_number":60,"context_line":"#  connection to the OpenvSwitch integration bridge, in"},{"line_number":61,"context_line":"#  seconds. If the value is zero, it disables the connection keepalive feature."},{"line_number":62,"context_line":"#  If the value is nonzero, then it will be forced to a value of at least 5s."},{"line_number":63,"context_line":"#  Defaults to 60"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"class ovn::controller("}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_cd120f59","line":62,"updated":"2019-09-20 12:09:14.000000000","message":"I wonder if we should be mentioning units whenever we mention timeouts. There is no precedent and I think seconds are a safe assumption though so ...","commit_id":"8dd1c1cd3bff8812401106581870e7fdf01e23fd"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"c708b875645bef85b89db25c72107dfeb8c6a92a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#  (optional) The inactivity probe interval of the OpenFlow"},{"line_number":60,"context_line":"#  connection to the OpenvSwitch integration bridge, in"},{"line_number":61,"context_line":"#  seconds. If the value is zero, it disables the connection keepalive feature."},{"line_number":62,"context_line":"#  If the value is nonzero, then it will be forced to a value of at least 5s."},{"line_number":63,"context_line":"#  Defaults to 60"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"class ovn::controller("}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_b816eff0","line":62,"in_reply_to":"3fa7e38b_cd120f59","updated":"2019-09-20 13:12:55.000000000","message":"It is mentioned above that thisvalue is in seconds: \nThe inactivity probe interval of the OpenFlow\n#  connection to the OpenvSwitch integration bridge, in\n#  seconds.","commit_id":"8dd1c1cd3bff8812401106581870e7fdf01e23fd"}],"releasenotes/notes/ovn_openflow_probe_interval-a465fbbde158c6b0.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"12fed69efb92968f530f852a489228a3d75ae647","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new param for puppet to set ovn_openflow_probe_interval which is inactivity probe interval of the OpenFlow"},{"line_number":5,"context_line":"    connection to the OpenvSwitch integration bridge, in seconds. If the value is zero, it disables the connection"},{"line_number":6,"context_line":"    keepalive feature, by default this value is set on 60s."},{"line_number":7,"context_line":"    If the value is nonzero, then it will be forced to a value of at least 5s."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ed3b4bc5","line":4,"updated":"2019-09-20 12:09:14.000000000","message":"question: do we have a line length recommendation for release notes? I wrap at commit msg line length but I cannot recall a style directive.","commit_id":"8dd1c1cd3bff8812401106581870e7fdf01e23fd"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"c708b875645bef85b89db25c72107dfeb8c6a92a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new param for puppet to set ovn_openflow_probe_interval which is inactivity probe interval of the OpenFlow"},{"line_number":5,"context_line":"    connection to the OpenvSwitch integration bridge, in seconds. If the value is zero, it disables the connection"},{"line_number":6,"context_line":"    keepalive feature, by default this value is set on 60s."},{"line_number":7,"context_line":"    If the value is nonzero, then it will be forced to a value of at least 5s."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_18286332","line":4,"in_reply_to":"3fa7e38b_ed3b4bc5","updated":"2019-09-20 13:12:55.000000000","message":"Done","commit_id":"8dd1c1cd3bff8812401106581870e7fdf01e23fd"}]}