)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"8064fee607bac1caba12280237fac0c6157cdcda","unresolved":true,"context_lines":[{"line_number":28,"context_line":"2) Deployed a master env with this patch with"},{"line_number":29,"context_line":"[\"provider1:br-ex\", \"provider2:br-ex\"] and obtained:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[root@ctrl-1-0 ~]# ovs-vsctl list open . |grep -o -P -e \u0027ovn-bridge-mappings\u003d.*?, \u0027"},{"line_number":32,"context_line":"ovn-bridge-mappings\u003d\"provider1:br-ex,provider2:br-ex\","},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I66d663971f087d019139b033c032a8e05f71a57a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5e16b2ae_21e9ff37","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":82},"updated":"2021-02-03 10:32:05.000000000","message":"nitnitnit: ovs-vsctl get open . external_ids:ovn-bridge-mappings should be easier :)","commit_id":"ab5516e3082f0508f05e2352b53127fcb34a462a"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"0867d8d525fc3cb7b81c00318ac85e95d0b7d583","unresolved":true,"context_lines":[{"line_number":28,"context_line":"2) Deployed a master env with this patch with"},{"line_number":29,"context_line":"[\"provider1:br-ex\", \"provider2:br-ex\"] and obtained:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[root@ctrl-1-0 ~]# ovs-vsctl list open . |grep -o -P -e \u0027ovn-bridge-mappings\u003d.*?, \u0027"},{"line_number":32,"context_line":"ovn-bridge-mappings\u003d\"provider1:br-ex,provider2:br-ex\","},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I66d663971f087d019139b033c032a8e05f71a57a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0ce35bec_309f51d0","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":82},"in_reply_to":"5e16b2ae_21e9ff37","updated":"2021-02-03 10:43:05.000000000","message":"Aha! Good to know, I had totally wasted 2 minutes figuring out how to do non-greedy regexes with grep ;)","commit_id":"ab5516e3082f0508f05e2352b53127fcb34a462a"}],"manifests/controller.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"98b072883c9b7982ce3be02ff881241fd82104b4","unresolved":true,"context_lines":[{"line_number":190,"context_line":"        # TODO(numans): Right now puppet-vswitch\u0027s vs_bridge doesn\u0027t support"},{"line_number":191,"context_line":"        # setting the column \u0027other-config\u0027 for the Bridge table."},{"line_number":192,"context_line":"        # Switch to using vs_bridge once the support is available."},{"line_number":193,"context_line":"        exec { $mappings:"},{"line_number":194,"context_line":"          command \u003d\u003e \"ovs-vsctl --timeout\u003d5 set Bridge ${br} other-config:mac-table-size\u003d${mac_table_size}\","},{"line_number":195,"context_line":"          unless  \u003d\u003e \"ovs-vsctl get bridge ${br} other-config:mac-table-size | grep -q -w ${mac_table_size}\","},{"line_number":196,"context_line":"          path    \u003d\u003e \u0027/usr/sbin:/usr/bin:/sbin:/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"b8c5c403_c5714ca2","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":25},"updated":"2021-02-23 13:03:50.000000000","message":"just wondering whether we can also use ensure_resource here instead of creating redundant resources.","commit_id":"1388d9eae38333bfdf998f2aa14be13f237705ad"}],"manifests/controller/bridge.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"98b072883c9b7982ce3be02ff881241fd82104b4","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# $name is OVN bridge-name. So if the mapping is in the format"},{"line_number":6,"context_line":"# network-name:bridge-name, we need to pass \u0027bridge-name\u0027 only"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"define ovn::controller::bridge {"},{"line_number":9,"context_line":"  $bridge \u003d $name"},{"line_number":10,"context_line":"  vs_bridge { $bridge:"},{"line_number":11,"context_line":"    ensure       \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"c29b98d0_1b3c34d8","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":30},"updated":"2021-02-23 13:03:50.000000000","message":"I don\u0027t know how many users are actually using this defined resource type directly, but I have a little concern with implementing a breaking change in its interface.\n\nDoes it make sense to add a compat logic so that the class also accepts network-name:bridge-name ? We can deprecate the previous format and remove support for it in next cycle.\n\nAlso, I think it\u0027s worth writing a release note to explain the change in interface.","commit_id":"1388d9eae38333bfdf998f2aa14be13f237705ad"}]}