)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"350dfdf1f62aeb550e7804323db5d888d0659115","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33dca1fc_b7060dfb","updated":"2022-11-28 15:38:21.000000000","message":"This looks nice. Thanks for working on it.\n\nLet me add a few comments before I leave.\n\nAlso we need the release note to document the new parameters.","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"803d9cb8232ad9c7240c59a1911110b7cca6c940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad042a70_b8287384","updated":"2022-11-29 06:05:55.000000000","message":"thanks for replying. one question - should I split this into two commits as it is two features, or is one commit ok? thinking about reno description...","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c769635ea004bb4ce4aa23353f41cdc812dc552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a4252e5_39886a8e","in_reply_to":"33dca1fc_b7060dfb","updated":"2022-12-01 04:53:24.000000000","message":"Done","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d119a08cc044e8ac317c9bc8d4cccc3ae5fd34e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc1dd932_ec5b5fbb","in_reply_to":"ad042a70_b8287384","updated":"2022-12-01 03:49:55.000000000","message":"I\u0027d prefer splitting this to two patches (and updated this change accordingly).","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"70d5d4fd8d2a6c67e31de9e0e22ace053fba90b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b2d02a81_2bde060b","updated":"2022-12-01 03:53:35.000000000","message":"Ugh. I modified the changes incorrectly. Let me fix it.","commit_id":"fb2726aef28584096277539d9261956101b987cc"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"cabf3274056acf01b01f3c5b11fa5e37263d3412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"73f5c5bf_f815f60f","updated":"2022-12-01 22:03:18.000000000","message":"thanks for merging this!\njust realised I did not catch an error in commit msg (should be tcp instead of ssl for address) but that is fine. \nonce again, thanks!","commit_id":"889de8b44dd24fae3c7942735a46e7a3d3aa9dbd"}],"manifests/northd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"350dfdf1f62aeb550e7804323db5d888d0659115","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  $ovn_northd_nb_db_opts \u003d $ovn_northd_nb_db ? {"},{"line_number":77,"context_line":"    String  \u003d\u003e [\"--ovn-northd-nb-db\u003d${ovn_northd_nb_db}\"],"},{"line_number":78,"context_line":"    default \u003d\u003e [],"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d7f20485_6b45e948","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":54},"updated":"2022-11-28 15:38:21.000000000","message":"According to the man page this can accept comma-separated list, so we probably want to accept Array as well.\n\nAlso, should we implement the validation or use undef/default to avoid ignoring the parameter in case a wrong parameter type is used ?","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"35060d28dddce4d0337ab92cdd2e312e6fced8e5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  $ovn_northd_nb_db_opts \u003d $ovn_northd_nb_db ? {"},{"line_number":77,"context_line":"    String  \u003d\u003e [\"--ovn-northd-nb-db\u003d${ovn_northd_nb_db}\"],"},{"line_number":78,"context_line":"    default \u003d\u003e [],"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b73ba6d3_7167bfc2","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":54},"in_reply_to":"d7f20485_6b45e948","updated":"2022-12-01 03:54:50.000000000","message":"Done","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"350dfdf1f62aeb550e7804323db5d888d0659115","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  } elsif ! ($ovn_northd_ssl_key or $ovn_northd_ssl_cert or $ovn_northd_ssl_ca_cert) {"},{"line_number":93,"context_line":"    $ovn_northd_ssl_opts \u003d []"},{"line_number":94,"context_line":"  } else {"},{"line_number":95,"context_line":"    fail(\u0027The ovn_northd_ssl_key, cert and ca-cert are required to use SSL.\u0027)"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  $ovn_northd_opts \u003d join($ovn_northd_opts_addr +"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ef3a6fed_9cc91eb2","line":95,"range":{"start_line":95,"start_character":43,"end_line":95,"end_character":50},"updated":"2022-11-28 15:38:21.000000000","message":"ca_cert ?","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"35060d28dddce4d0337ab92cdd2e312e6fced8e5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  } elsif ! ($ovn_northd_ssl_key or $ovn_northd_ssl_cert or $ovn_northd_ssl_ca_cert) {"},{"line_number":93,"context_line":"    $ovn_northd_ssl_opts \u003d []"},{"line_number":94,"context_line":"  } else {"},{"line_number":95,"context_line":"    fail(\u0027The ovn_northd_ssl_key, cert and ca-cert are required to use SSL.\u0027)"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  $ovn_northd_opts \u003d join($ovn_northd_opts_addr +"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9b4490c6_ebfd8580","line":95,"range":{"start_line":95,"start_character":43,"end_line":95,"end_character":50},"in_reply_to":"ef3a6fed_9cc91eb2","updated":"2022-12-01 03:54:50.000000000","message":"Done","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"}],"spec/classes/ovn_northd_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"350dfdf1f62aeb550e7804323db5d888d0659115","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        is_expected.to contain_augeas(\u0027config-ovn-northd\u0027).with({"},{"line_number":32,"context_line":"          :context \u003d\u003e platform_params[:ovn_northd_context],"},{"line_number":33,"context_line":"          :changes \u003d\u003e \"set \" + platform_params[:ovn_northd_option_name] + \" \u0027\\\"\" +"},{"line_number":34,"context_line":"                      \"--db-nb-addr\u003d0.0.0.0 --db-sb-addr\u003d0.0.0.0 --db-nb-create-insecure-remote\u003dyes --db-sb-create-insecure-remote\u003dyes\" + "},{"line_number":35,"context_line":"                      \" --ovn-northd-nb-db\u003dssl:192.0.2.1:6645,ssl:192.0.2.2:6645,ssl:192.0.2.3:6645 --ovn-northd-sb-db\u003dssl:192.0.2.1:6646,ssl:192.0.2.2:6646,ssl:192.0.2.3:6646\" +"},{"line_number":36,"context_line":"                      \" --ovn-northd-ssl-key\u003dkey.pem --ovn-northd-ssl-cert\u003dcert.pem --ovn-northd-ssl-ca-cert\u003dcacert.pem\" +"},{"line_number":37,"context_line":"                      \"\\\"\u0027\","}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9b7fc46e_cd7c7ebd","line":34,"range":{"start_line":34,"start_character":137,"end_line":34,"end_character":138},"updated":"2022-11-28 15:38:21.000000000","message":"remove this.","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c769635ea004bb4ce4aa23353f41cdc812dc552","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        is_expected.to contain_augeas(\u0027config-ovn-northd\u0027).with({"},{"line_number":32,"context_line":"          :context \u003d\u003e platform_params[:ovn_northd_context],"},{"line_number":33,"context_line":"          :changes \u003d\u003e \"set \" + platform_params[:ovn_northd_option_name] + \" \u0027\\\"\" +"},{"line_number":34,"context_line":"                      \"--db-nb-addr\u003d0.0.0.0 --db-sb-addr\u003d0.0.0.0 --db-nb-create-insecure-remote\u003dyes --db-sb-create-insecure-remote\u003dyes\" + "},{"line_number":35,"context_line":"                      \" --ovn-northd-nb-db\u003dssl:192.0.2.1:6645,ssl:192.0.2.2:6645,ssl:192.0.2.3:6645 --ovn-northd-sb-db\u003dssl:192.0.2.1:6646,ssl:192.0.2.2:6646,ssl:192.0.2.3:6646\" +"},{"line_number":36,"context_line":"                      \" --ovn-northd-ssl-key\u003dkey.pem --ovn-northd-ssl-cert\u003dcert.pem --ovn-northd-ssl-ca-cert\u003dcacert.pem\" +"},{"line_number":37,"context_line":"                      \"\\\"\u0027\","}],"source_content_type":"text/x-ruby","patch_set":1,"id":"915454d3_12a9c737","line":34,"range":{"start_line":34,"start_character":137,"end_line":34,"end_character":138},"in_reply_to":"9b7fc46e_cd7c7ebd","updated":"2022-12-01 04:53:24.000000000","message":"Done","commit_id":"d627dd377b271d3e433a7332415e6ead666e06fb"}]}