)]}'
{"id":"openstack%2Fpuppet-pacemaker~609351","triplet_id":"openstack%2Fpuppet-pacemaker~master~I5af578b5b838deec7beb2d5a9bb83fa6bb6293b7","project":"openstack/puppet-pacemaker","branch":"master","topic":"bug/1797041","hashtags":[],"change_id":"I5af578b5b838deec7beb2d5a9bb83fa6bb6293b7","subject":"Fix reconnect_interval parameter","status":"MERGED","created":"2018-10-10 10:46:10.000000000","updated":"2018-10-15 14:16:49.000000000","submitted":"2018-10-15 14:16:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"609351-1539613009992-256cf724","meta_rev_id":"bdef78efdd23668669d9f24b65b2d7c0b4cdf287","_number":609351,"virtual_id_number":609351,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-10-14 18:59:50.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2018-10-15 14:16:49.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-10-14 21:30:29.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2018-10-15 13:45:43.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2018-10-14 13:30:21.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2018-10-15 13:45:43.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-14 13:30:21.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-10-14 21:30:29.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-10-15 13:45:43.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2018-10-15 14:16:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6eba6edb4d34d58cd8dacdf7f84e6b88c7471777","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2018-10-10 10:46:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1247ede1774f5c07c70546e3e0ad56c0d8e97ee","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-10 11:13:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/51/609351/1/check/puppet-openstack-lint/5b5e519/ : SUCCESS in 5m 31s\n- puppet-openstack-syntax-4 http://logs.openstack.org/51/609351/1/check/puppet-openstack-syntax-4/ef016eb/ : SUCCESS in 4m 52s\n- puppet-openstack-syntax-5 http://logs.openstack.org/51/609351/1/check/puppet-openstack-syntax-5/b118853/ : SUCCESS in 4m 43s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/51/609351/1/check/puppet-openstack-unit-4.8-centos-7/9350a3d/ : SUCCESS in 10m 28s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/51/609351/1/check/puppet-openstack-unit-5.5-centos-7/a550c76/ : SUCCESS in 9m 36s\n- puppet-openstack-unit-latest-centos-7 http://logs.openstack.org/51/609351/1/check/puppet-openstack-unit-latest-centos-7/04b28a7/ : SUCCESS in 11m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"86c437c83ac24ee07bb33996ecaa4b3196be2cc3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2018-10-10 12:23:55.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/51/609351/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/fed520f/ : FAILURE in 1h 26m 54s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/51/609351/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/c098e88/ : FAILURE in 1h 25m 15s","accounts_in_message":[],"_revision_number":1},{"id":"edbcc93a160e454bbc3de9a4d170b2e38fcdeeea","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-10-14 13:30:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"868ea7f42ea02e983d78417b80aa8ee61186f5ad","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2018-10-14 18:59:50.000000000","message":"Patch Set 1:\n\ncheck-rdo","accounts_in_message":[],"_revision_number":1},{"id":"6849cc6887466a4e10d1bd4a3c587d166f7e53fa","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2018-10-14 21:30:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/51/609351/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/c4de5f2/ : SUCCESS in 2h 26m 16s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/51/609351/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/45935ae/ : SUCCESS in 2h 29m 56s","accounts_in_message":[],"_revision_number":1},{"id":"9ed6c9c46ae58e07f487c2ee7e0db53307da81bd","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-10-15 13:45:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b1fdce6fde02bb4dae3979a26672aa2f6d6241c4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-15 13:45:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"31a8913d39f184f8eaf544cd6c24ea207d56187a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-15 14:16:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1af8ed8fe0786a708e3bc7d7521e36f2a678f619","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-15 14:16:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/51/609351/1/gate/puppet-openstack-lint/0b41012/ : SUCCESS in 4m 23s\n- puppet-openstack-syntax-4 http://logs.openstack.org/51/609351/1/gate/puppet-openstack-syntax-4/dfa373f/ : SUCCESS in 4m 12s\n- puppet-openstack-syntax-5 http://logs.openstack.org/51/609351/1/gate/puppet-openstack-syntax-5/84b2907/ : SUCCESS in 4m 12s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/51/609351/1/gate/puppet-openstack-unit-4.8-centos-7/76002b4/ : SUCCESS in 10m 08s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/51/609351/1/gate/puppet-openstack-unit-5.5-centos-7/0afacfd/ : SUCCESS in 9m 29s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ece92d13af45a2f40fe58f1ee2a236e70b3fa9f2","revisions":{"ece92d13af45a2f40fe58f1ee2a236e70b3fa9f2":{"kind":"REWORK","_number":1,"created":"2018-10-10 10:46:10.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/51/609351/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-pacemaker","ref":"refs/changes/51/609351/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/51/609351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/51/609351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/51/609351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-pacemaker refs/changes/51/609351/1"}}},"commit":{"parents":[{"commit":"9a4bc2d3582b519953dff7caa1e1c0e32dc6731c","subject":"Dissuade .gitignore references to personal tools","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/9a4bc2d3582b519953dff7caa1e1c0e32dc6731c"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2018-10-10 10:43:27.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2018-10-10 10:43:27.000000000","tz":120},"subject":"Fix reconnect_interval parameter","message":"Fix reconnect_interval parameter\n\nThere is a typo in the logic around reconnect_intervl\nwhich makes it skip setting the interval.\n\nLet\u0027s fix that by making the code more explicit.\nTested with a custom reconnect interval set via:\nExtraConfig:\n  pacemaker_remote_reconnect_interval: 120\n\nAnd obtained the correct state of the remote resource:\n[root@controller-0 ~]# pcs resource show compute-0 |grep reconnect\n  Attributes: reconnect_interval\u003d120 server\u003d172.17.1.14\n\nBefore the fix there would be no reconnect_interval\nattribute.\n\nChange-Id: I5af578b5b838deec7beb2d5a9bb83fa6bb6293b7\nRelated-Bug: #1797041\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/ece92d13af45a2f40fe58f1ee2a236e70b3fa9f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/ece92d13af45a2f40fe58f1ee2a236e70b3fa9f2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}