)]}'
{"manifests/corosync.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"dcd58419401f6483752196f47c29a0c9b2db6c32","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      require   \u003d\u003e Class[\u0027::pacemaker::install\u0027],"},{"line_number":263,"context_line":"    }"},{"line_number":264,"context_line":"    -\u003e"},{"line_number":265,"context_line":"    if $enable_sbd {"},{"line_number":266,"context_line":"      exec {\u0027Enable SBD\u0027:"},{"line_number":267,"context_line":"        unless  \u003d\u003e \"${::pacemaker::pcs_bin} status | grep -q \u0027sbd: active/enabled\u0027 \u003e /dev/null 2\u003e\u00261\","},{"line_number":268,"context_line":"        command \u003d\u003e \"${::pacemaker::pcs_bin} stonith sbd enable SBD_WATCHDOG_TIMEOUT\u003d${sbd_watchdog_timeout}\","},{"line_number":269,"context_line":"        require \u003d\u003e Exec[\"Create Cluster ${cluster_name}\"],"},{"line_number":270,"context_line":"      }"},{"line_number":271,"context_line":"      -\u003e"},{"line_number":272,"context_line":"      exec {\"Start Cluster ${cluster_name}\":"},{"line_number":273,"context_line":"        unless    \u003d\u003e \"${::pacemaker::pcs_bin} status \u003e/dev/null 2\u003e\u00261\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_53b59aed","line":270,"range":{"start_line":265,"start_character":0,"end_line":270,"end_character":7},"updated":"2019-06-03 13:20:25.000000000","message":"you can just leave this exec by itself under if $enable_sbd and remove the require. And add\nExec\u003c| title \u003d\u003d \u0027Enable SBD\u0027 |\u003e -\u003e Exec \u003c|title \u003d\u003d \"Create Cluster ${cluster_name}\"|\u003e\n\nThat way you avoid the duplicated exec {\"Start Cluster...\"} inside the if and the else.","commit_id":"ea1d82876704575f3a48125b30cb224e3b2ad3a3"}],"manifests/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b4507560759a2efdaf0d16230130abfe7e84470","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      if $::operatingsystemrelease \u003d~ /7\\.[012]*$/ {"},{"line_number":49,"context_line":"        $pcmk_remote_package_list \u003d [\u0027pacemaker\u0027,\u0027pcs\u0027,\u0027fence-agents-all\u0027,\u0027pacemaker-libs\u0027]"},{"line_number":50,"context_line":"      } else {"},{"line_number":51,"context_line":"        if $::enable_sbd {"},{"line_number":52,"context_line":"          $pcmk_remote_package_list \u003d [\u0027pacemaker\u0027,\u0027pcs\u0027,\u0027fence-agents-all\u0027,\u0027pacemaker-libs\u0027, \u0027pacemaker-remote\u0027, \u0027sbd\u0027]"},{"line_number":53,"context_line":"        } else {"},{"line_number":54,"context_line":"          $pcmk_remote_package_list \u003d [\u0027pacemaker\u0027,\u0027pcs\u0027,\u0027fence-agents-all\u0027,\u0027pacemaker-libs\u0027, \u0027pacemaker-remote\u0027]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_80148ea1","line":51,"updated":"2019-07-31 20:17:25.000000000","message":"$::enable_sbd means a global var which I don\u0027t think is correct in this context. It\u0027s likely that we should be providing a $pcmk_remote_package_list and just including sbd as a standalone if $enable_sbd is set for the corosync class or whereever that\u0027s handled","commit_id":"ecd9e2a1392cfbe18352c380976ff403d8916dd9"}]}