)]}'
{"agent_generator/agent_generator.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"11029196b70c7945df593bd1dc693411d8645614","unresolved":false,"context_lines":[{"line_number":123,"context_line":"define pacemaker::stonith::#{@parser.getAgentName} ("},{"line_number":124,"context_line":"#{getManifestParameters}"},{"line_number":125,"context_line":"  $deep_compare       \u003d hiera(\u0027pacemaker::stonith::deep_compare\u0027, false),"},{"line_number":126,"context_line":"  $update_settle_secs \u003d hiera(\u0027pacemaker::stonith::update_settle_secs\u0027, 600),"},{"line_number":127,"context_line":") {"},{"line_number":128,"context_line":"#{getVariableValues}"},{"line_number":129,"context_line":"  $pcmk_host_value_chunk \u003d $pcmk_host_list ? {"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"7faddb67_0245f043","line":126,"updated":"2019-09-03 15:47:39.000000000","message":"we traditionally do not do hiera lookups in these modules as this type of syntax tends to be a tripleo-ism. Can we get away without doing this hiera lookup here?","commit_id":"bb302302b94b10a626bb7525d34d549ee588a627"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"9a1ff05c6f779ec94927d633ef47d955d29d0bcc","unresolved":false,"context_lines":[{"line_number":123,"context_line":"define pacemaker::stonith::#{@parser.getAgentName} ("},{"line_number":124,"context_line":"#{getManifestParameters}"},{"line_number":125,"context_line":"  $deep_compare       \u003d hiera(\u0027pacemaker::stonith::deep_compare\u0027, false),"},{"line_number":126,"context_line":"  $update_settle_secs \u003d hiera(\u0027pacemaker::stonith::update_settle_secs\u0027, 600),"},{"line_number":127,"context_line":") {"},{"line_number":128,"context_line":"#{getVariableValues}"},{"line_number":129,"context_line":"  $pcmk_host_value_chunk \u003d $pcmk_host_list ? {"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"7faddb67_b2fd4b09","line":126,"in_reply_to":"7faddb67_0245f043","updated":"2019-09-03 18:03:08.000000000","message":"I just copy/pasted from the other resources (for example https://github.com/openstack/puppet-pacemaker/blob/8b30131ef70007a050f9f1aafd7cb695bae7a72a/manifests/resource/ocf.pp#L129).\nIs there any example I can refer to in order to improve my current approach?","commit_id":"bb302302b94b10a626bb7525d34d549ee588a627"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6b648abbe6cf69627531cb6e287fe4933f0366c7","unresolved":false,"context_lines":[{"line_number":123,"context_line":"define pacemaker::stonith::#{@parser.getAgentName} ("},{"line_number":124,"context_line":"#{getManifestParameters}"},{"line_number":125,"context_line":"  $deep_compare       \u003d hiera(\u0027pacemaker::stonith::deep_compare\u0027, false),"},{"line_number":126,"context_line":"  $update_settle_secs \u003d hiera(\u0027pacemaker::stonith::update_settle_secs\u0027, 600),"},{"line_number":127,"context_line":") {"},{"line_number":128,"context_line":"#{getVariableValues}"},{"line_number":129,"context_line":"  $pcmk_host_value_chunk \u003d $pcmk_host_list ? {"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"7faddb67_fed85e52","line":126,"in_reply_to":"7faddb67_27d3503a","updated":"2019-09-04 14:26:07.000000000","message":"That\u0027s kinda the point for puppet-pacemaker usage. You can do this by default in puppet-tripleo instead so you get that all or nothing logic. I think  the hiera call is appropriate in puppet-tripleo (as that\u0027s a tripleoism) and not in puppet-pacemaker.","commit_id":"bb302302b94b10a626bb7525d34d549ee588a627"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"f0785ba5efb621338680a552949ab6a7d60a06fd","unresolved":false,"context_lines":[{"line_number":123,"context_line":"define pacemaker::stonith::#{@parser.getAgentName} ("},{"line_number":124,"context_line":"#{getManifestParameters}"},{"line_number":125,"context_line":"  $deep_compare       \u003d hiera(\u0027pacemaker::stonith::deep_compare\u0027, false),"},{"line_number":126,"context_line":"  $update_settle_secs \u003d hiera(\u0027pacemaker::stonith::update_settle_secs\u0027, 600),"},{"line_number":127,"context_line":") {"},{"line_number":128,"context_line":"#{getVariableValues}"},{"line_number":129,"context_line":"  $pcmk_host_value_chunk \u003d $pcmk_host_list ? {"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"7faddb67_27d3503a","line":126,"in_reply_to":"7faddb67_32687bb8","updated":"2019-09-04 07:52:39.000000000","message":"sure that would work, the drawback is that we would have to set deep_compare\u003dtrue for each individual stonith resource vs setting it once (like I am doing here). \nIf you prefer this approach maybe we can set deep_compare\u003dtrue by default so to avoid having to deal with each agent individually?","commit_id":"bb302302b94b10a626bb7525d34d549ee588a627"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce5b694977469c6dae1825c4795ffe19c0b3b79b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"define pacemaker::stonith::#{@parser.getAgentName} ("},{"line_number":124,"context_line":"#{getManifestParameters}"},{"line_number":125,"context_line":"  $deep_compare       \u003d hiera(\u0027pacemaker::stonith::deep_compare\u0027, false),"},{"line_number":126,"context_line":"  $update_settle_secs \u003d hiera(\u0027pacemaker::stonith::update_settle_secs\u0027, 600),"},{"line_number":127,"context_line":") {"},{"line_number":128,"context_line":"#{getVariableValues}"},{"line_number":129,"context_line":"  $pcmk_host_value_chunk \u003d $pcmk_host_list ? {"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"7faddb67_32687bb8","line":126,"in_reply_to":"7faddb67_b2fd4b09","updated":"2019-09-03 18:08:38.000000000","message":"I would just leave it with non-hieradata defaults for this. Since this is a resource, the code that calls this should provide the actual values if we want to override","commit_id":"bb302302b94b10a626bb7525d34d549ee588a627"}],"manifests/stonith/fence_ipmilan.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"6f7290cee59f657984a7cb8ce1e6547d123edaf1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# [*meta_attr*]"},{"line_number":71,"context_line":"#   (optional) String of meta attributes"},{"line_number":72,"context_line":"#   Defaults to undef"},{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*deep_compare*]"},{"line_number":75,"context_line":"#   (optional) Enable deep comparing of resources and bundles"},{"line_number":76,"context_line":"#   When set to true a resource will be compared in full (options, meta parameters,..)"},{"line_number":77,"context_line":"#   to the existing one and in case of difference it will be repushed to the CIB"},{"line_number":78,"context_line":"#   Defaults to false"},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*update_settle_secs*]"},{"line_number":81,"context_line":"#   (optional) When deep_compare is enabled and puppet updates a resource, this"},{"line_number":82,"context_line":"#   parameter represents the number (in seconds) to wait for the cluster to settle"},{"line_number":83,"context_line":"#   after the resource update."},{"line_number":84,"context_line":"#   Defaults to hiera(\u0027pacemaker::resource::filesystem::update_settle_secs\u0027, 600) (seconds)"},{"line_number":85,"context_line":"# \u003d\u003d\u003d Dependencies"},{"line_number":86,"context_line":"#  None"},{"line_number":87,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_736867b9","line":84,"range":{"start_line":73,"start_character":1,"end_line":84,"end_character":91},"updated":"2019-08-30 10:08:06.000000000","message":"so this change needs to go under agent_generator/agent_generator.rb and then we need to regenerate all the fence agent manifest","commit_id":"911a8506f7db82a1c75c6585198ab16c8a88bd94"}]}