)]}'
{"id":"openstack%2Fpuppet-pacemaker~697171","triplet_id":"openstack%2Fpuppet-pacemaker~master~Ibb87428fce4026b21032f874feb09104cca0db52","project":"openstack/puppet-pacemaker","branch":"master","hashtags":[],"change_id":"Ibb87428fce4026b21032f874feb09104cca0db52","subject":"Fix missing deep_compare for fence_redfish","status":"MERGED","created":"2019-12-03 19:53:34.000000000","updated":"2019-12-04 13:28:30.000000000","submitted":"2019-12-04 13:11:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697171-1575465116661-0f63802f","meta_rev_id":"511541df5fe739a2779559520d6e4d62410fcf03","_number":697171,"virtual_id_number":697171,"owner":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-04 13:11:56.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"date":"2019-12-04 11:05:15.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-04 08:20:38.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-04 12:47:33.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-04 12:47:57.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-04 08:20:38.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-12-04 11:05:15.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-04 12:47:57.000000000","updated_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"reviewer":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"state":"REVIEWER"},{"updated":"2019-12-04 13:11:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"57e21a51cbef276f3760446a9b6db5fe50f800c1","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2019-12-03 19:53:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ca2c3c74a53aeb9a0b1a4c5ca83ae6a7c2c5e84","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-03 20:08:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ec9bf1083d2d4a3fb1fe2e2da8ce3ffb : SUCCESS in 4m 43s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c2989d13d15b47ca9d23eb2cf842c250 : SUCCESS in 5m 02s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/19266405bc8141fe90caf9812ecabfc5 : SUCCESS in 6m 24s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/dc2387f5728c4f48ba8a65d64bb9a2ab : SUCCESS in 10m 11s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8905367a466f4267b867fefa8d7988d2 : SUCCESS in 9m 06s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f78b2d6ce6734773bffbec0f8568f359 : SUCCESS in 9m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"17a7f1456d1e96cd1b16d325aea8226caaa5b7f3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-12-03 22:13:28.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/71/697171/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/dbbf10c/ : FAILURE in 2h 14m 15s","accounts_in_message":[],"_revision_number":1},{"id":"88bd33c2ff500fbef410a48c73f6ff16b875430c","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-12-04 07:31:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"db9cb6b1b900ca0019252fd661ea946c9d22c316","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2019-12-04 08:18:13.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ce6dfa6d25a9b628068ffd9326af290bb68a70e6","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-12-04 08:20:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8af8016b1f6ed1889af2c0c571516fb67a3aa191","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 08:42:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4fe3058cc6a14d0b9e9f555126133449 : SUCCESS in 4m 29s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7ce3529afd5a4918960e1a39caa840e3 : SUCCESS in 6m 38s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9b2e4365b06749e29acc17f27e2b70b9 : SUCCESS in 5m 27s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/856efa7514c243b387c10d5703ec6ce8 : SUCCESS in 11m 42s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c5a36c97f0394b9fb2e6ea320442aa26 : SUCCESS in 10m 04s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/77b3dbb1c33a45b1b3499c65ffc588de : SUCCESS in 7m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"53f257621d3b6f9fb343324b4903f749783e6da1","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-12-04 11:05:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/71/697171/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/9cc7373/ : SUCCESS in 2h 44m 49s","accounts_in_message":[],"_revision_number":2},{"id":"3fecccfc3935f41ca04b587cf708bd83318c55ef","author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"date":"2019-12-04 12:47:33.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"98c10c12db0718c61716cae344ba28ebf95b3410","author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"date":"2019-12-04 12:47:57.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e090100477f4126e238cd9bc2303388a8e59153a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 12:48:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b83328b0a678370d49846ecc3f5a6d343fa70599","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 13:11:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1c7a77c156874b2091fc1a18daceeed5 : SUCCESS in 7m 45s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/27b4bab640134c9d914c1e521c51b812 : SUCCESS in 7m 02s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a6e5296611bf4e02a3d51b074751541b : SUCCESS in 5m 22s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/d0e24c7ba76547699a0a11a40d1bba01 : SUCCESS in 14m 38s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0728e481c9aa468dbd54d4a156c5e923 : SUCCESS in 11m 14s","accounts_in_message":[],"_revision_number":2},{"id":"44e7b0d09e34b5f49b8720b98caccd685f79e649","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 13:11:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"511541df5fe739a2779559520d6e4d62410fcf03","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2019-12-04 13:28:30.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/0.7.x as commit 71c73442a9e20b94df008fbff3fb6d979d3cdae2","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"635aee9afd4010507498020ab6ea54e4430913e6","revisions":{"6676dcaa8e737718c814b456b7144d7ee7fd6658":{"kind":"REWORK","_number":1,"created":"2019-12-03 19:53:34.000000000","uploader":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"ref":"refs/changes/71/697171/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-pacemaker","ref":"refs/changes/71/697171/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/1"}}},"commit":{"parents":[{"commit":"b6174b3642d266b390ac94bd948dfdafed605f13","subject":"Merge \"Allow updating stonith levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/b6174b3642d266b390ac94bd948dfdafed605f13"}]}],"author":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2019-12-03 19:50:13.000000000","tz":60},"committer":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2019-12-03 19:53:31.000000000","tz":60},"subject":"Fix missing deep_compare for fence_redfish","message":"Fix missing deep_compare for fence_redfish\n\nAgent generator doesn\u0027t seem to work for fence_redfish, so this\nwas missing in https://review.opendev.org/#/c/679407/.\n\nThis commit adds deep_compare and update_settle_secs.\n\nChange-Id: Ibb87428fce4026b21032f874feb09104cca0db52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/6676dcaa8e737718c814b456b7144d7ee7fd6658"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/6676dcaa8e737718c814b456b7144d7ee7fd6658"}]},"branch":"refs/heads/master"},"635aee9afd4010507498020ab6ea54e4430913e6":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-12-04 08:18:13.000000000","uploader":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"ref":"refs/changes/71/697171/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-pacemaker","ref":"refs/changes/71/697171/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-pacemaker refs/changes/71/697171/2"}}},"commit":{"parents":[{"commit":"b6174b3642d266b390ac94bd948dfdafed605f13","subject":"Merge \"Allow updating stonith levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/b6174b3642d266b390ac94bd948dfdafed605f13"}]}],"author":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2019-12-03 19:50:13.000000000","tz":60},"committer":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2019-12-04 08:18:09.000000000","tz":0},"subject":"Fix missing deep_compare for fence_redfish","message":"Fix missing deep_compare for fence_redfish\n\nFence_redfish was blacklisted from the automatic agent generation by:\n\nhttps://review.opendev.org/#/c/636886/\n\nand unfortunately https://review.opendev.org/#/c/679407/ did not take\nthat into account.\n\nThis commit adds deep_compare and update_settle_secs manually until we\ncan revert that change.\n\nResolves: rhbz#1699449\n\nChange-Id: Ibb87428fce4026b21032f874feb09104cca0db52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/635aee9afd4010507498020ab6ea54e4430913e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-pacemaker/commit/635aee9afd4010507498020ab6ea54e4430913e6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}