)]}'
{"manifests/api.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d61577d096e34726368c477dea2f90eaccdd0338","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   Defaults to false"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# [*auth_strategy*]"},{"line_number":48,"context_line":"#   (optional) Configure panko authentication. "},{"line_number":49,"context_line":"#   Can be set to noauth and keystone."},{"line_number":50,"context_line":"#   Defaults to \u0027keystone\u0027."},{"line_number":51,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_d7c0e252","line":48,"range":{"start_line":48,"start_character":46,"end_line":48,"end_character":47},"updated":"2016-08-29 18:17:49.000000000","message":"please remove the space","commit_id":"5dc7dd3b1a68abbddd4571427b7a08bdd8295eeb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d61577d096e34726368c477dea2f90eaccdd0338","unresolved":false,"context_lines":[{"line_number":49,"context_line":"#   Can be set to noauth and keystone."},{"line_number":50,"context_line":"#   Defaults to \u0027keystone\u0027."},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# \u003d DEPRECATED PARAMETERS"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*keystone_user*]"},{"line_number":55,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::username instead."},{"line_number":56,"context_line":"#   Defaults to undef"},{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*keystone_tenant*]"},{"line_number":59,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::project_name"},{"line_number":60,"context_line":"#   instead."},{"line_number":61,"context_line":"#   Defaults to undef"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keystone_password*]"},{"line_number":64,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::password instead."},{"line_number":65,"context_line":"#   Defaults to undef"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# [*keystone_auth_uri*]"},{"line_number":68,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::auth_uri instead."},{"line_number":69,"context_line":"#   Defaults to undef"},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"# [*keystone_identity_uri*]"},{"line_number":72,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::auth_url instead."},{"line_number":73,"context_line":"#   Defaults to undef"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"class panko::api ("},{"line_number":76,"context_line":"  $manage_service        \u003d true,"},{"line_number":77,"context_line":"  $enabled               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_d7d9c258","line":74,"range":{"start_line":52,"start_character":0,"end_line":74,"end_character":1},"updated":"2016-08-29 18:17:49.000000000","message":"why this? the module is new and all parameters are in the authtoken class.\n\nI think you don\u0027t need \u003d)","commit_id":"5dc7dd3b1a68abbddd4571427b7a08bdd8295eeb"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"aa0ce39a1f7e8cfa91b6d8bd23f564a6ddae75e0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"#   Can be set to noauth and keystone."},{"line_number":50,"context_line":"#   Defaults to \u0027keystone\u0027."},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# \u003d DEPRECATED PARAMETERS"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*keystone_user*]"},{"line_number":55,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::username instead."},{"line_number":56,"context_line":"#   Defaults to undef"},{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*keystone_tenant*]"},{"line_number":59,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::project_name"},{"line_number":60,"context_line":"#   instead."},{"line_number":61,"context_line":"#   Defaults to undef"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keystone_password*]"},{"line_number":64,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::password instead."},{"line_number":65,"context_line":"#   Defaults to undef"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# [*keystone_auth_uri*]"},{"line_number":68,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::auth_uri instead."},{"line_number":69,"context_line":"#   Defaults to undef"},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"# [*keystone_identity_uri*]"},{"line_number":72,"context_line":"#   (optional) DEPRECATED. Use panko::keystone::authtoken::auth_url instead."},{"line_number":73,"context_line":"#   Defaults to undef"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"class panko::api ("},{"line_number":76,"context_line":"  $manage_service        \u003d true,"},{"line_number":77,"context_line":"  $enabled               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa7ab95a_77e396a4","line":74,"range":{"start_line":52,"start_character":0,"end_line":74,"end_character":1},"in_reply_to":"fa7ab95a_d7d9c258","updated":"2016-08-29 18:22:07.000000000","message":"agreed. Will remove them","commit_id":"5dc7dd3b1a68abbddd4571427b7a08bdd8295eeb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b8b6d93576930482d249712917eac81ceff226a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":56,"context_line":"  $host                  \u003d \u00270.0.0.0\u0027,"},{"line_number":57,"context_line":"  $port                  \u003d \u00278779\u0027,"},{"line_number":58,"context_line":"  $workers               \u003d $::processorcount,"},{"line_number":59,"context_line":"  $max_limit             \u003d 1000,"},{"line_number":60,"context_line":"  $service_name          \u003d $::panko::params::api_service_name,"},{"line_number":61,"context_line":"  $sync_db               \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_fde70a44","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":44},"updated":"2016-09-19 20:44:43.000000000","message":"Is this a sane default? I know on physical servers this can be large so is there a cap we should put on this for panko?","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"69bbc27c0d08e0f5a171a7c008b68fedeffff44c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":56,"context_line":"  $host                  \u003d \u00270.0.0.0\u0027,"},{"line_number":57,"context_line":"  $port                  \u003d \u00278779\u0027,"},{"line_number":58,"context_line":"  $workers               \u003d $::processorcount,"},{"line_number":59,"context_line":"  $max_limit             \u003d 1000,"},{"line_number":60,"context_line":"  $service_name          \u003d $::panko::params::api_service_name,"},{"line_number":61,"context_line":"  $sync_db               \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_a2139a0c","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":44},"in_reply_to":"7a8ec9b2_fde70a44","updated":"2016-09-19 21:41:12.000000000","message":"This seems to be the standard default for most services. We changed this for gnocchi as gnocchi does some extensive metric processing. Panko is mostly just an event storage with api exposed. So the default should be fine to start with i believe. In devstack gate we just set it to 2. So we dont do the math we do for gnocchi. I say we just leave this as is for now and revisit this later.","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"}],"manifests/db/sync.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b8b6d93576930482d249712917eac81ceff226a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027panko-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"panko-dbsync --config-file /etc/panko/panko.conf ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027panko\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_1d0916de","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":68},"updated":"2016-09-19 20:44:43.000000000","message":"I have a feeling this should be configurable but I\u0027m torn because we do it so many different ways in each project. Some it\u0027s hard coded and some  it\u0027s in $extra_params.","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"69bbc27c0d08e0f5a171a7c008b68fedeffff44c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027panko-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"panko-dbsync --config-file /etc/panko/panko.conf ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027panko\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_6230b29f","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":68},"in_reply_to":"7a8ec9b2_1d0916de","updated":"2016-09-19 21:41:12.000000000","message":"i dont think we will ever change the conf location. Since this is a pattern in many services, I\u0027m inclined to leave it as is.","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9edf3fef3f629a7d4173558126ac9245b47b0a14","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027panko\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":19,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  Package\u003c| tag \u003d\u003d \u0027panko-package\u0027 |\u003e ~\u003e Exec[\u0027panko-db-sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_fd41873a","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":29},"updated":"2016-09-20 20:47:48.000000000","message":"should be wrapped in single quotes","commit_id":"420a26e5833a34accdaa9d309cf150c91f8a9857"}],"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a9b7ac1e5f456306ca1d7aeef9fd0b524c78eca2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   in the panko config."},{"line_number":40,"context_line":"#   Defaults to false."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*verbose*]"},{"line_number":45,"context_line":"#   (optional) Deprecated. Set log output to verbose output."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_56a842db","line":42,"updated":"2016-08-30 01:28:42.000000000","message":"don\u0027t add deprecated parameters, it\u0027s a new module !","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c39473548157aef92780196999cfec6388931c23","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   in the panko config."},{"line_number":40,"context_line":"#   Defaults to false."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*verbose*]"},{"line_number":45,"context_line":"#   (optional) Deprecated. Set log output to verbose output."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_8006b583","line":42,"in_reply_to":"fa7ab95a_56a842db","updated":"2016-08-30 22:28:41.000000000","message":"Done","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d3589641de08eb4dc6533b5f8c167b5024c9aab6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"class panko ("},{"line_number":43,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":44,"context_line":"  $debug               \u003d undef,"},{"line_number":45,"context_line":"  $use_syslog          \u003d undef,"},{"line_number":46,"context_line":"  $use_stderr          \u003d undef,"},{"line_number":47,"context_line":"  $log_dir             \u003d undef,"},{"line_number":48,"context_line":"  $log_facility        \u003d undef,"},{"line_number":49,"context_line":"  $database_connection \u003d undef,"},{"line_number":50,"context_line":"  $purge_config        \u003d false,"},{"line_number":51,"context_line":") inherits panko::params {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_7535ccf5","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":31},"updated":"2016-09-09 12:20:10.000000000","message":"this is in the logging class no? If you want to have here you need to update the logging class to use pick, otherwise this parameters are useless.","commit_id":"c2e253920ac69674cf8d14d22bc6b3fbfd5532d4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d3589641de08eb4dc6533b5f8c167b5024c9aab6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $use_stderr          \u003d undef,"},{"line_number":47,"context_line":"  $log_dir             \u003d undef,"},{"line_number":48,"context_line":"  $log_facility        \u003d undef,"},{"line_number":49,"context_line":"  $database_connection \u003d undef,"},{"line_number":50,"context_line":"  $purge_config        \u003d false,"},{"line_number":51,"context_line":") inherits panko::params {"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_f0364ae6","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":31},"updated":"2016-09-09 12:20:10.000000000","message":"this is in db.pp you need to update db class with pick","commit_id":"c2e253920ac69674cf8d14d22bc6b3fbfd5532d4"}],"manifests/keystone/authtoken.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b2b5eda42b9e0eb231b10f5abdbbe9fd158f7edd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"#  Defaults to $::os_service_default."},{"line_number":191,"context_line":"#"},{"line_number":192,"context_line":"class panko::keystone::authtoken("},{"line_number":193,"context_line":"  $password                       \u003d $::os_service_default,"},{"line_number":194,"context_line":"  $username                       \u003d \u0027panko\u0027,"},{"line_number":195,"context_line":"  $auth_url                       \u003d \u0027http://localhost:35357\u0027,"},{"line_number":196,"context_line":"  $project_name                   \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_b6efcee7","line":193,"range":{"start_line":193,"start_character":34,"end_line":193,"end_character":57},"updated":"2016-08-30 01:34:08.000000000","message":"this was required and you are using $::os_service_default, you can let the way it was before","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c39473548157aef92780196999cfec6388931c23","unresolved":false,"context_lines":[{"line_number":190,"context_line":"#  Defaults to $::os_service_default."},{"line_number":191,"context_line":"#"},{"line_number":192,"context_line":"class panko::keystone::authtoken("},{"line_number":193,"context_line":"  $password                       \u003d $::os_service_default,"},{"line_number":194,"context_line":"  $username                       \u003d \u0027panko\u0027,"},{"line_number":195,"context_line":"  $auth_url                       \u003d \u0027http://localhost:35357\u0027,"},{"line_number":196,"context_line":"  $project_name                   \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_00d465e9","line":193,"range":{"start_line":193,"start_character":34,"end_line":193,"end_character":57},"in_reply_to":"fa7ab95a_b6efcee7","updated":"2016-08-30 22:28:41.000000000","message":"We seem to be doing this for other services by making this param optional, hence i did the same.","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b8b6d93576930482d249712917eac81ceff226a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027panko\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*password*]"},{"line_number":12,"context_line":"#   (Optional) Password to create for the service user"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# [*auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The URL to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_fdd1ca30","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":37},"updated":"2016-09-19 20:44:43.000000000","message":"Pretty sure this should remain required. If this gets pulled in you nee the password","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c87c72409daa10955c70d5b7ce851a284445d2b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027panko\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*password*]"},{"line_number":12,"context_line":"#   (Optional) Password to create for the service user"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# [*auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The URL to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_8556a804","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"7a8ec9b2_022feea1","updated":"2016-09-19 22:02:07.000000000","message":"ah understood, ok i\u0027ll look into it. Thanks for the info","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ab01e4dfe364a739e9234460e3b4dce1ee400d40","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027panko\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*password*]"},{"line_number":12,"context_line":"#   (Optional) Password to create for the service user"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# [*auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The URL to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_022feea1","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"7a8ec9b2_22aa2a71","updated":"2016-09-19 21:58:31.000000000","message":"For backwards compatibility. For those services previously it was set elsewhere so there is a check in the class to use the old setting. Any new service going forward should have this be required as it\u0027s required for the keystone authtoken middleware to properly work.\n\nhttps://github.com/openstack/puppet-aodh/blob/master/manifests/keystone/authtoken.pp#L226-L231\nhttps://github.com/openstack/puppet-gnocchi/blob/master/manifests/keystone/authtoken.pp#L226-L231","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c15794b58fe13e347e780cd2caffc5d3e3d8632e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027panko\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*password*]"},{"line_number":12,"context_line":"#   (Optional) Password to create for the service user"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# [*auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The URL to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_22aa2a71","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"7a8ec9b2_c21fc607","updated":"2016-09-19 21:44:39.000000000","message":"actually, looking at other services eg: aodh/gnocchi this is an optional param. Any reason this should be different from them?","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"69bbc27c0d08e0f5a171a7c008b68fedeffff44c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027panko\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*password*]"},{"line_number":12,"context_line":"#   (Optional) Password to create for the service user"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# [*auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The URL to use for authentication."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_c21fc607","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"7a8ec9b2_fdd1ca30","updated":"2016-09-19 21:41:12.000000000","message":"agreed.","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a9b7ac1e5f456306ca1d7aeef9fd0b524c78eca2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#   [*port*]"},{"line_number":29,"context_line":"#     The port."},{"line_number":30,"context_line":"#     Optional. Defaults to 8041"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"#   [*bind_host*]"},{"line_number":33,"context_line":"#     The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_76b1c646","line":30,"updated":"2016-08-30 01:28:42.000000000","message":"wrong port","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c39473548157aef92780196999cfec6388931c23","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#   [*port*]"},{"line_number":29,"context_line":"#     The port."},{"line_number":30,"context_line":"#     Optional. Defaults to 8041"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"#   [*bind_host*]"},{"line_number":33,"context_line":"#     The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_20cc0988","line":30,"in_reply_to":"fa7ab95a_76b1c646","updated":"2016-08-30 22:28:41.000000000","message":"Done","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b2b5eda42b9e0eb231b10f5abdbbe9fd158f7edd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#     (optional) The number of threads for the vhost."},{"line_number":54,"context_line":"#     Defaults to $::processorcount"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"#   [*ssl_cert*]"},{"line_number":57,"context_line":"#   [*ssl_key*]"},{"line_number":58,"context_line":"#   [*ssl_chain*]"},{"line_number":59,"context_line":"#   [*ssl_ca*]"},{"line_number":60,"context_line":"#   [*ssl_crl_path*]"},{"line_number":61,"context_line":"#   [*ssl_crl*]"},{"line_number":62,"context_line":"#   [*ssl_certs_dir*]"},{"line_number":63,"context_line":"#     apache::vhost ssl parameters."},{"line_number":64,"context_line":"#     Optional. Default to apache::vhost \u0027ssl_*\u0027 defaults."},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# \u003d\u003d Dependencies"},{"line_number":67,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_f63876a2","line":64,"range":{"start_line":56,"start_character":0,"end_line":64,"end_character":58},"updated":"2016-08-30 01:34:08.000000000","message":"I think you should add description","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c39473548157aef92780196999cfec6388931c23","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#     (optional) The number of threads for the vhost."},{"line_number":54,"context_line":"#     Defaults to $::processorcount"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"#   [*ssl_cert*]"},{"line_number":57,"context_line":"#   [*ssl_key*]"},{"line_number":58,"context_line":"#   [*ssl_chain*]"},{"line_number":59,"context_line":"#   [*ssl_ca*]"},{"line_number":60,"context_line":"#   [*ssl_crl_path*]"},{"line_number":61,"context_line":"#   [*ssl_crl*]"},{"line_number":62,"context_line":"#   [*ssl_certs_dir*]"},{"line_number":63,"context_line":"#     apache::vhost ssl parameters."},{"line_number":64,"context_line":"#     Optional. Default to apache::vhost \u0027ssl_*\u0027 defaults."},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# \u003d\u003d Dependencies"},{"line_number":67,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_20f6c98e","line":64,"range":{"start_line":56,"start_character":0,"end_line":64,"end_character":58},"in_reply_to":"fa7ab95a_f63876a2","updated":"2016-08-30 22:28:41.000000000","message":"This stuff was auto generated by cookie cutter","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a9b7ac1e5f456306ca1d7aeef9fd0b524c78eca2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"class panko::wsgi::apache ("},{"line_number":77,"context_line":"  $servername    \u003d $::fqdn,"},{"line_number":78,"context_line":"  $port          \u003d 8041,"},{"line_number":79,"context_line":"  $bind_host     \u003d undef,"},{"line_number":80,"context_line":"  $path          \u003d \u0027/\u0027,"},{"line_number":81,"context_line":"  $ssl           \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_96ae4ae4","line":78,"updated":"2016-08-30 01:28:42.000000000","message":"wrong port","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c39473548157aef92780196999cfec6388931c23","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"class panko::wsgi::apache ("},{"line_number":77,"context_line":"  $servername    \u003d $::fqdn,"},{"line_number":78,"context_line":"  $port          \u003d 8041,"},{"line_number":79,"context_line":"  $bind_host     \u003d undef,"},{"line_number":80,"context_line":"  $path          \u003d \u0027/\u0027,"},{"line_number":81,"context_line":"  $ssl           \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_60be11af","line":78,"in_reply_to":"fa7ab95a_96ae4ae4","updated":"2016-08-30 22:28:41.000000000","message":"Done","commit_id":"9fb27de9e23d1daa5e7c7bcc996a5975adf81ec6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b8b6d93576930482d249712917eac81ceff226a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $bind_host     \u003d undef,"},{"line_number":80,"context_line":"  $path          \u003d \u0027/\u0027,"},{"line_number":81,"context_line":"  $ssl           \u003d true,"},{"line_number":82,"context_line":"  $workers       \u003d 1,"},{"line_number":83,"context_line":"  $ssl_cert      \u003d undef,"},{"line_number":84,"context_line":"  $ssl_key       \u003d undef,"},{"line_number":85,"context_line":"  $ssl_chain     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_ddc40e61","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":21},"updated":"2016-09-19 20:44:43.000000000","message":"this workers and threads is another one where is there a sane default we should be doing? I know for some services you should have multiple workers and one or more threads.  Which way does panko work best with?","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"69bbc27c0d08e0f5a171a7c008b68fedeffff44c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $bind_host     \u003d undef,"},{"line_number":80,"context_line":"  $path          \u003d \u0027/\u0027,"},{"line_number":81,"context_line":"  $ssl           \u003d true,"},{"line_number":82,"context_line":"  $workers       \u003d 1,"},{"line_number":83,"context_line":"  $ssl_cert      \u003d undef,"},{"line_number":84,"context_line":"  $ssl_key       \u003d undef,"},{"line_number":85,"context_line":"  $ssl_chain     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_82dcde47","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":21},"in_reply_to":"7a8ec9b2_ddc40e61","updated":"2016-09-19 21:41:12.000000000","message":"same comment here too. For now i think this default is fine, we can revisit this value as we start using panko.","commit_id":"3f64bf60e8201d6adfbb6519c7788151144762e6"}],"spec/acceptance/basic_panko_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d3589641de08eb4dc6533b5f8c167b5024c9aab6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \u0027RedHat\u0027: {"},{"line_number":25,"context_line":"          class { \u0027::panko\u0027:"},{"line_number":26,"context_line":"            debug               \u003d\u003e true,"},{"line_number":27,"context_line":"            database_connection \u003d\u003e \u0027mysql+pymysql://panko:a_big_secret@127.0.0.1/panko?charset\u003dutf8\u0027,"},{"line_number":28,"context_line":"          }"},{"line_number":29,"context_line":"          class { \u0027::panko::keystone::authtoken\u0027:"},{"line_number":30,"context_line":"            password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a89bdaa_d0aea6e6","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":101},"updated":"2016-09-09 12:20:10.000000000","message":"this parameters does not configure the database connection because the db class does not have pick to use this value","commit_id":"c2e253920ac69674cf8d14d22bc6b3fbfd5532d4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d526c6751fb88e4071582fab5590763f662f5486","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      class { \u0027::panko::db::mysql\u0027:"},{"line_number":15,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":16,"context_line":"      }"},{"line_number":17,"context_line":"      class { \u0027::gnocchi::keystone::auth\u0027:"},{"line_number":18,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7a8ec9b2_13cf5eb1","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"updated":"2016-09-13 19:46:52.000000000","message":"panko no?","commit_id":"22f57b5e0f65423e7c289f54167a3008b7edfcc3"}]}