)]}'
{"manifests/expirer.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfe652479bb13c391436a1614b0ccba8e8671f98","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  $month       \u003d \u0027*\u0027,"},{"line_number":50,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":51,"context_line":"  $maxdelay    \u003d 0,"},{"line_number":52,"context_line":"  $maxsize     \u003d 500,"},{"line_number":53,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":54,"context_line":"  $enable_cron \u003d undef,"},{"line_number":55,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_f61bb5c7","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":21},"updated":"2020-09-23 13:49:01.000000000","message":"I think it\u0027s better to use the original parameter name, events_delete_batch_size instead, so that we can keep consistencies even if a new parameter is added in a future.\n\nAlso, it\u0027s better to use $::os_service_default instead of overriding the default here.","commit_id":"1ffbc29ab2ed4c53b71599d4596d7e19d95e3b08"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"885c51fc7fbe7c7bf6e5b1ce12c430a19207c5ca","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#    all cron jobs at the same time on all hosts this job is configured."},{"line_number":31,"context_line":"#    Defaults to 0."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"#  [*maxsize*]"},{"line_number":34,"context_line":"#    (optional) Limit number of deleted events in single purge run."},{"line_number":35,"context_line":"#    Defaults to 500."},{"line_number":36,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f560f44_52653f44","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":12},"updated":"2020-09-23 23:12:40.000000000","message":"This should be updated, too","commit_id":"9636a23ffd6b6377939cba79ef5b3d43d2e13ee0"}],"spec/classes/panko_expirer_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e4682c4f021705685bd2edf60f77dbde482005be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    context \u0027with default\u0027 do"},{"line_number":10,"context_line":"      it { is_expected.to contain_class(\u0027panko::deps\u0027) }"},{"line_number":11,"context_line":"      it { is_expected.to contain_class(\u0027panko::params\u0027) }"},{"line_number":12,"context_line":"      it { is_expected.to contain_panko_config(\u0027database/events_delete_batch_size\u0027) }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"      it { is_expected.to contain_cron(\u0027panko-expirer\u0027).with("},{"line_number":15,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_af7d5b6e","line":12,"updated":"2020-09-23 17:00:43.000000000","message":".with_value(\u0027\u003cOS SERVICE DEFAULT\u003e\u0027)","commit_id":"9636a23ffd6b6377939cba79ef5b3d43d2e13ee0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"885c51fc7fbe7c7bf6e5b1ce12c430a19207c5ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":29,"context_line":"      before do"},{"line_number":30,"context_line":"        params.merge!("},{"line_number":31,"context_line":"          :ensure   \u003d\u003e \u0027absent\u0027,"},{"line_number":32,"context_line":"          :maxdelay \u003d\u003e 300,"},{"line_number":33,"context_line":"          :events_delete_batch_size \u003d\u003e 500"},{"line_number":34,"context_line":"        )"},{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_b2565b5d","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":42},"updated":"2020-09-23 23:12:40.000000000","message":"Please align \"\u003d\u003e\"","commit_id":"9636a23ffd6b6377939cba79ef5b3d43d2e13ee0"}]}