)]}'
{"Gemfile":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b9787d7f56e8c52a8197b414d8a0ae5584aab274","unresolved":false,"context_lines":[{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027,"},{"line_number":5,"context_line":"      :git     \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027,"},{"line_number":6,"context_line":"      :branch  \u003d\u003e \u0027stable/ocata\u0027,"},{"line_number":7,"context_line":"      :require \u003d\u003e false"},{"line_number":8,"context_line":"end"},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f79a3b5_dac45363","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":33},"updated":"2018-09-24 11:49:50.000000000","message":"remove line","commit_id":"1bde1b1558a3e2a94cf1c700150530edc9a22da3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0478d1220a007dc9b55371ef76ebedf38953d60b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027,"},{"line_number":5,"context_line":"      :git     \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027,"},{"line_number":6,"context_line":"      :branch  \u003d\u003e \u0027stable/ocata\u0027,"},{"line_number":7,"context_line":"      :require \u003d\u003e false"},{"line_number":8,"context_line":"end"},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f79a3b5_e1607fa7","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":33},"in_reply_to":"3f79a3b5_dac45363","updated":"2018-09-24 16:44:34.000000000","message":"Done","commit_id":"1bde1b1558a3e2a94cf1c700150530edc9a22da3"}],"functions":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# functions - puppet-openstack_spec_helper specific functions"},{"line_number":4,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":34,"id":"3f79a3b5_48518164","line":1,"updated":"2018-12-11 09:43:58.000000000","message":"This is some leftover right?","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/config.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a166fd7b79f934425ef04a9de705c14a13966fe2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027placement/project_name\u0027:        value \u003d\u003e $project_name;"},{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/os_region_name\u0027:      value \u003d\u003e $os_region_name;"},{"line_number":73,"context_line":"    \u0027placement/os_interface\u0027:        value \u003d\u003e $os_interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_cf2ed741","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":29},"updated":"2018-09-24 11:02:26.000000000","message":"IIRC this might be region_name and os_region_name being deprecated, need to check","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027placement/project_name\u0027:        value \u003d\u003e $project_name;"},{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/os_region_name\u0027:      value \u003d\u003e $os_region_name;"},{"line_number":73,"context_line":"    \u0027placement/os_interface\u0027:        value \u003d\u003e $os_interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_e1371faf","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":29},"in_reply_to":"3f79a3b5_cf2ed741","updated":"2018-09-24 16:44:12.000000000","message":"Done","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a166fd7b79f934425ef04a9de705c14a13966fe2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/os_region_name\u0027:      value \u003d\u003e $os_region_name;"},{"line_number":73,"context_line":"    \u0027placement/os_interface\u0027:        value \u003d\u003e $os_interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_6f23035a","line":73,"range":{"start_line":73,"start_character":15,"end_line":73,"end_character":27},"updated":"2018-09-24 11:02:26.000000000","message":"same here os_interface or just interface","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/os_region_name\u0027:      value \u003d\u003e $os_region_name;"},{"line_number":73,"context_line":"    \u0027placement/os_interface\u0027:        value \u003d\u003e $os_interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_a141270d","line":73,"range":{"start_line":73,"start_character":15,"end_line":73,"end_character":27},"in_reply_to":"3f79a3b5_6f23035a","updated":"2018-09-24 16:44:12.000000000","message":"Done","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d62d59f052d2264b3e0aea969623330c6e75ea51","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $password            \u003d false,"},{"line_number":53,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":54,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":55,"context_line":"  $os_region_name      \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_interface        \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":58,"context_line":"  $project_name        \u003d \u0027services\u0027,"},{"line_number":59,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_29f96e4d","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":47},"updated":"2018-09-25 13:05:40.000000000","message":"rename them to the proper ones region_name and interface","commit_id":"c37f0b105ea672ed1a14b418c257b6fc39d4490b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"65fcc3c80ad1fef3f3346a84ce90499d175b539d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $password            \u003d false,"},{"line_number":53,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":54,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":55,"context_line":"  $os_region_name      \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_interface        \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":58,"context_line":"  $project_name        \u003d \u0027services\u0027,"},{"line_number":59,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_4a2a992f","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":47},"in_reply_to":"3f79a3b5_29f96e4d","updated":"2018-09-25 14:03:23.000000000","message":"Done","commit_id":"c37f0b105ea672ed1a14b418c257b6fc39d4490b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $password            \u003d false,"},{"line_number":53,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":54,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":55,"context_line":"  $region_name      \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $valid_interfaces        \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":58,"context_line":"  $project_name        \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_2ae87db1","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":21},"updated":"2018-09-25 14:12:22.000000000","message":"align \u003d","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":54,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":55,"context_line":"  $region_name      \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $valid_interfaces        \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":58,"context_line":"  $project_name        \u003d \u0027services\u0027,"},{"line_number":59,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_eac92551","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":28},"updated":"2018-09-25 14:12:22.000000000","message":"align \u003d","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027placement/project_name\u0027:        value \u003d\u003e $project_name;"},{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/region_name\u0027:      value \u003d\u003e $region_name;"},{"line_number":73,"context_line":"    \u0027placement/interface\u0027:        value \u003d\u003e $interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_0afca170","line":72,"range":{"start_line":72,"start_character":34,"end_line":72,"end_character":39},"updated":"2018-09-25 14:12:22.000000000","message":"align: value","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/region_name\u0027:      value \u003d\u003e $region_name;"},{"line_number":73,"context_line":"    \u0027placement/interface\u0027:        value \u003d\u003e $interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_caf54986","line":73,"range":{"start_line":73,"start_character":34,"end_line":73,"end_character":39},"updated":"2018-09-25 14:12:22.000000000","message":"align: value","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/region_name\u0027:      value \u003d\u003e $region_name;"},{"line_number":73,"context_line":"    \u0027placement/interface\u0027:        value \u003d\u003e $interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_6a075583","line":73,"range":{"start_line":73,"start_character":44,"end_line":73,"end_character":53},"updated":"2018-09-25 14:12:22.000000000","message":"valid_interfaces","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0a23dc294dbe747b2968f918231ec33fcd8bbcb4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027placement/user_domain_name\u0027:    value \u003d\u003e $user_domain_name;"},{"line_number":71,"context_line":"    \u0027placement/username\u0027:            value \u003d\u003e $username;"},{"line_number":72,"context_line":"    \u0027placement/region_name\u0027:      value \u003d\u003e $region_name;"},{"line_number":73,"context_line":"    \u0027placement/interface\u0027:        value \u003d\u003e $interface;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f79a3b5_aad32d01","line":73,"range":{"start_line":73,"start_character":15,"end_line":73,"end_character":24},"updated":"2018-09-25 14:12:22.000000000","message":"valid_interfaces","commit_id":"5b6267b8a7ae6af2c9dbe2a4f53cf2e2b8fceeb9"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*password*]"},{"line_number":8,"context_line":"#   (required) Password for connecting to Nova Placement API service in"},{"line_number":9,"context_line":"#   admin context through the OpenStack Identity service."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*auth_type*]"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_0ccc7994","line":8,"range":{"start_line":8,"start_character":42,"end_line":8,"end_character":46},"updated":"2018-11-20 20:28:48.000000000","message":"I assume this can go at some point. No big deal, just noticed it.","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f523d7b60195981920d421fbd8f05b94d4827e98","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   (optional) Points to the OpenStack Identity server IP and port."},{"line_number":47,"context_line":"#   This is the Identity (keystone) admin API server IP and port value,"},{"line_number":48,"context_line":"#   and not the Identity service API IP and port."},{"line_number":49,"context_line":"#   Defaults to \u0027http://127.0.0.1:35357/v3\u0027"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"class placement::config("},{"line_number":52,"context_line":"  $password            \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_67ef3cfa","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":39},"updated":"2018-11-21 10:36:02.000000000","message":"5000","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   (optional) Points to the OpenStack Identity server IP and port."},{"line_number":47,"context_line":"#   This is the Identity (keystone) admin API server IP and port value,"},{"line_number":48,"context_line":"#   and not the Identity service API IP and port."},{"line_number":49,"context_line":"#   Defaults to \u0027http://127.0.0.1:35357/v3\u0027"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"class placement::config("},{"line_number":52,"context_line":"  $password            \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_8cc88976","line":49,"updated":"2018-11-20 20:28:48.000000000","message":"Not that it matters at this stage, but isnt auth_url deprecated in favor of www_authenticate_uri?\n\n(acknowledging that this is a puppet value not yet a conf value, but it triggered my brain)\n\n[later]\n\nOh, I think I may be confused. These are for the [placement] section of the config? If that\u0027s the case, then these stay in nova where they are keystoneauth options for talking to placement from nova.\n\nPlacement itself has a placement group, but only a small number of options in it: https://git.openstack.org/cgit/openstack/placement/tree/placement/conf/placement.py","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f523d7b60195981920d421fbd8f05b94d4827e98","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class placement::config("},{"line_number":52,"context_line":"  $password            \u003d false,"},{"line_number":53,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":54,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":55,"context_line":"  $region_name         \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $valid_interfaces    \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_07f8c8bf","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":48},"updated":"2018-11-21 10:36:02.000000000","message":"5000","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9740475ec8336600e6b3a949e9bc8252b27b9336","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*auth_url*]"},{"line_number":46,"context_line":"#   (optional) Points to the OpenStack Identity server IP and port."},{"line_number":47,"context_line":"#   This is the Identity (keystone) admin API server IP and port value,"},{"line_number":48,"context_line":"#   and not the Identity service API IP and port."},{"line_number":49,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000/v3\u0027"},{"line_number":50,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3f79a3b5_17510b32","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":70},"updated":"2018-12-03 18:40:06.000000000","message":"I thought distinguishing this was passe?\n\n(probably a cookiecutter artifact, but happened to notice)","commit_id":"a7907eb064d222ec4d3b182fb3194aac3afc5e74"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"},{"line_number":60,"context_line":"  $username            \u003d \u0027placement\u0027,"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":"  include ::placement::deps"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  placement_config {"},{"line_number":65,"context_line":"    \u0027placement/auth_type\u0027:           value \u003d\u003e $auth_type;"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_c844b1a2","line":62,"updated":"2018-12-11 09:43:58.000000000","message":"nit: should be a blank line before this include","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/db.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9740475ec8336600e6b3a949e9bc8252b27b9336","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement::db ("},{"line_number":16,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":17,"context_line":"  $database_slave_connection    \u003d $::os_service_default,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3f79a3b5_1726ebcd","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":80},"updated":"2018-12-03 18:40:06.000000000","message":"I assume this is always overridden? Placement doesn\u0027t do well when using sqlite on disk (it\u0027s okay in RAM, but also useless then).","commit_id":"a7907eb064d222ec4d3b182fb3194aac3afc5e74"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"168168ed9136c39eb572142046ee2881c3284db7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement::db ("},{"line_number":16,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":17,"context_line":"  $database_slave_connection    \u003d $::os_service_default,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3f79a3b5_7aaff47e","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":80},"in_reply_to":"3f79a3b5_1726ebcd","updated":"2018-12-04 13:52:47.000000000","message":"Yes AFAIK this is never actually used and something inherited from the cookiecutter template.","commit_id":"a7907eb064d222ec4d3b182fb3194aac3afc5e74"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# [*database_connection*]"},{"line_number":8,"context_line":"#   (Optional) Url used to connect to database."},{"line_number":9,"context_line":"#   Defaults to \u0027sqlite:////var/lib/placement/placement.sqlite\u0027."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class placement::db ("},{"line_number":12,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":13,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_c8a0313a","line":10,"updated":"2018-12-11 09:43:58.000000000","message":"missing a #","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# [*database_connection*]"},{"line_number":8,"context_line":"#   (Optional) Url used to connect to database."},{"line_number":9,"context_line":"#   Defaults to \u0027sqlite:////var/lib/placement/placement.sqlite\u0027."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class placement::db ("},{"line_number":12,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":13,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_6baa376c","line":10,"in_reply_to":"3f79a3b5_c8a0313a","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027sqlite:////var/lib/placement/placement.sqlite\u0027."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class placement::db ("},{"line_number":12,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_68b0fd8c","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":32},"updated":"2018-12-11 09:43:58.000000000","message":"nit: spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to \u0027sqlite:////var/lib/placement/placement.sqlite\u0027."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class placement::db ("},{"line_number":12,"context_line":"  $database_connection          \u003d \u0027sqlite:////var/lib/placement/placement.sqlite\u0027,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_0bc5c33d","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":32},"in_reply_to":"3f79a3b5_68b0fd8c","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  placement_config {"},{"line_number":22,"context_line":"    \u0027placement_database/connection\u0027:        value \u003d\u003e $database_connection;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_a8ba956c","line":22,"range":{"start_line":22,"start_character":37,"end_line":22,"end_character":44},"updated":"2018-12-11 09:43:58.000000000","message":"nit: spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  placement_config {"},{"line_number":22,"context_line":"    \u0027placement_database/connection\u0027:        value \u003d\u003e $database_connection;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_2bc0bf2b","line":22,"range":{"start_line":22,"start_character":37,"end_line":22,"end_character":44},"in_reply_to":"3f79a3b5_a8ba956c","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/db/mysql.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    allowed_hosts \u003d\u003e $allowed_hosts,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  ::Openstacklib::Db::Mysql[\u0027placement\u0027] ~\u003e Exec\u003c| title \u003d\u003d \u0027placement-manage db_sync\u0027 |\u003e"},{"line_number":70,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_4c703142","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":85},"updated":"2018-11-20 20:28:48.000000000","message":"It\u0027s going to be placement-manage db sync (space not underscore): See https://review.openstack.org/#/c/600161/ which just merged","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"}],"manifests/db/postgresql.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    privileges    \u003d\u003e $privileges,"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  ::Openstacklib::Db::Postgresql[\u0027placement\u0027] ~\u003e Exec\u003c| title \u003d\u003d \u0027placement-manage db_sync\u0027 |\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_acc4653a","line":55,"range":{"start_line":55,"start_character":66,"end_line":55,"end_character":91},"updated":"2018-11-20 20:28:48.000000000","message":"ditto","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"}],"manifests/db/sync.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Class to execute placement-manage db_sync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# \u003d\u003d Parameters"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# [*extra_params*]"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_6cce4d59","line":3,"range":{"start_line":2,"start_character":20,"end_line":3,"end_character":1},"updated":"2018-11-20 20:28:48.000000000","message":"ditto","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"46a119ffa3b0d5ba929776e4fdeaa7cb247cf61b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    subscribe   \u003d\u003e ["},{"line_number":26,"context_line":"      Anchor[\u0027placement::install::end\u0027],"},{"line_number":27,"context_line":"      Anchor[\u0027placement::config::end\u0027],"},{"line_number":28,"context_line":"      Anchor[\u0027placement::db::end\u0027]"},{"line_number":29,"context_line":"      Anchor[\u0027placement::dbsync::begin\u0027]"},{"line_number":30,"context_line":"    ],"},{"line_number":31,"context_line":"    notify      \u003d\u003e Anchor[\u0027placement::dbsync::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_aa3270be","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":34},"updated":"2018-11-29 14:44:32.000000000","message":"missing ,","commit_id":"f431e4f5cfc7970a5d922cd3967adc1198982b91"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9740475ec8336600e6b3a949e9bc8252b27b9336","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage db sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, ],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":22,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3f79a3b5_12b03941","line":19,"updated":"2018-12-03 18:40:06.000000000","message":"depending on who or what is doing the install I often see it in /usr/local/bin","commit_id":"a7907eb064d222ec4d3b182fb3194aac3afc5e74"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"168168ed9136c39eb572142046ee2881c3284db7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage db sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, ],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":22,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"3f79a3b5_1a312057","line":19,"in_reply_to":"3f79a3b5_12b03941","updated":"2018-12-04 13:52:47.000000000","message":"Thanks, I\u0027ll add that to the list but for now for CentOS it\u0027s in /usr/bin.","commit_id":"a7907eb064d222ec4d3b182fb3194aac3afc5e74"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to undef"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class placement::db::sync("},{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") inherits placement::params {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_a8ecd590","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":17},"updated":"2018-12-11 09:43:58.000000000","message":"nit: spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to undef"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class placement::db::sync("},{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") inherits placement::params {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_ebb5e7c9","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":17},"in_reply_to":"3f79a3b5_a8ecd590","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class placement::db::sync("},{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") inherits placement::params {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_48df41d2","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":28},"updated":"2018-12-11 09:43:58.000000000","message":"nit: not really used but probably in the cookiecutter template","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class placement::db::sync("},{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") inherits placement::params {"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_8bd6b3f7","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":28},"in_reply_to":"3f79a3b5_48df41d2","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_489421e6","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":60},"updated":"2018-12-11 09:43:58.000000000","message":"have we verified that extra_params should be passed after \"db sync\" or after \"placement-manage\" command? Maybe Chris wrote something about that earlier.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ea025d96495787b52480f31374897116c5c4bac9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_31feec02","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":60},"in_reply_to":"3f79a3b5_16540622","updated":"2018-12-11 11:13:30.000000000","message":"I wasn\u0027t really asking in terms of immediate use or changing how puppet does things, more just a general query about the usefulness of such a thing.\n\nI haven\u0027t proved it yet, but I\u0027m pretty sure that alembic is supposed to try really hard to protect against races when multiple things are trying to do the sync.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_abd92f27","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":60},"in_reply_to":"3f79a3b5_489421e6","updated":"2018-12-11 10:17:28.000000000","message":"Yeah there\u0027s no support for additional params at the moment so I\u0027ve dropped this.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d1eecec9dcf2b2b54910b78aa56a69a84055808b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_f6c4ea43","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":60},"in_reply_to":"3f79a3b5_abd92f27","updated":"2018-12-11 10:45:30.000000000","message":"That\u0027s right. And for the time being we aren\u0027t expecting there to be any additional parameters. Or maybe that\u0027s just a hope, but it is an earnest hope.\n\nRelated to this, from a deployers and deployment tools standpoint, what\u0027s the feeling for things like this: https://review.openstack.org/#/c/619050/","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6e79355cbdf88500e6961642c396e5b1923ad141","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  include ::placement::deps"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_16540622","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":60},"in_reply_to":"3f79a3b5_f6c4ea43","updated":"2018-12-11 11:07:27.000000000","message":"It could potentially be useful but we would need to rework how we deploy placement-api entirely to only start the service on a single node first, avoiding any races syncing the DB. At the moment we sync on a single node and then start the service across all controllers at the same time.\n\nGiven it\u0027s off by default and has use in upstream CI I wouldn\u0027t be opposed to seeing it land either way tbh.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":22,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_0882a9a6","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":21},"updated":"2018-12-11 09:43:58.000000000","message":"nit: spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  exec { \u0027placement-manage-db-sync\u0027:"},{"line_number":18,"context_line":"    command     \u003d\u003e \"placement-manage db sync ${extra_params}\","},{"line_number":19,"context_line":"    path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, \u0027/usr/local/bin\u0027],"},{"line_number":20,"context_line":"    user        \u003d\u003e \u0027placement\u0027,"},{"line_number":21,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":22,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_4bdc1b15","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":21},"in_reply_to":"3f79a3b5_0882a9a6","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/deps.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ed9f5934ef1f7fa86934ac5020be51eec0ec0c05","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  ~\u003e anchor { \u0027placement::config::end\u0027: }"},{"line_number":19,"context_line":"  -\u003e anchor { \u0027placement::db::begin\u0027: }"},{"line_number":20,"context_line":"  -\u003e anchor { \u0027placement::db::end\u0027: }"},{"line_number":21,"context_line":"  -\u003e anchor { \u0027placement::dbsync::begin\u0027: }"},{"line_number":22,"context_line":"  -\u003e anchor { \u0027placement::dbsync::end\u0027: }"},{"line_number":23,"context_line":"  ~\u003e anchor { \u0027placement::service::begin\u0027: }"},{"line_number":24,"context_line":"  ~\u003e Service\u003c| tag \u003d\u003d \u0027placement-service\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"3f79a3b5_35a666c1","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":4},"updated":"2018-12-04 15:33:10.000000000","message":"shouldn\u0027t this be ~\u003e?","commit_id":"04a8efc81d3f43a8a5c94911bc7d568c84fc2f00"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a3fcec90d04bd777a5863eed642e4f2c65024546","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  ~\u003e anchor { \u0027placement::config::end\u0027: }"},{"line_number":19,"context_line":"  -\u003e anchor { \u0027placement::db::begin\u0027: }"},{"line_number":20,"context_line":"  -\u003e anchor { \u0027placement::db::end\u0027: }"},{"line_number":21,"context_line":"  -\u003e anchor { \u0027placement::dbsync::begin\u0027: }"},{"line_number":22,"context_line":"  -\u003e anchor { \u0027placement::dbsync::end\u0027: }"},{"line_number":23,"context_line":"  ~\u003e anchor { \u0027placement::service::begin\u0027: }"},{"line_number":24,"context_line":"  ~\u003e Service\u003c| tag \u003d\u003d \u0027placement-service\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"3f79a3b5_75261e24","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":4},"in_reply_to":"3f79a3b5_35a666c1","updated":"2018-12-04 15:38:01.000000000","message":"Yeah, pretty sure I\u0027ve tried both ways and it still fails but I\u0027ll change this now.","commit_id":"04a8efc81d3f43a8a5c94911bc7d568c84fc2f00"}],"manifests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to true"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_683ebde2","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":40},"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to true"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_6bdf9709","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":40},"in_reply_to":"3f79a3b5_683ebde2","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_882a3994","line":17,"range":{"start_line":17,"start_character":18,"end_line":17,"end_character":40},"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_0bcaa345","line":17,"range":{"start_line":17,"start_character":18,"end_line":17,"end_character":40},"in_reply_to":"3f79a3b5_882a3994","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_483bc1f1","line":18,"updated":"2018-12-11 09:43:58.000000000","message":"remove new line","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class placement("},{"line_number":16,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":17,"context_line":"  $sync_db                              \u003d true,"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":") inherits placement::params {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  include ::placement::deps"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_2bc51f35","line":18,"in_reply_to":"3f79a3b5_483bc1f1","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    include ::placement::db::sync"},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_c82351bb","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":19},"updated":"2018-12-11 09:43:58.000000000","message":"don\u0027t we need py3 check here? or perhaps the conversion is not done yet","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    include ::placement::db::sync"},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_8bff9367","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":19},"in_reply_to":"3f79a3b5_c82351bb","updated":"2018-12-11 10:17:28.000000000","message":"Already handled in params and used below:\n\nhttps://review.openstack.org/#/c/604182/34/manifests/params.pp","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_a82db5ad","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":12},"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_ab028f6f","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":12},"in_reply_to":"3f79a3b5_a82db5ad","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_68331d12","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":12},"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_4bf5fb84","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":12},"in_reply_to":"3f79a3b5_68331d12","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { \u0027placement-common\u0027:"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_2819a589","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":12},"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  package { \u0027python-placement\u0027:"},{"line_number":28,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":29,"context_line":"    name    \u003d\u003e $::placement::params::python_package_name,"},{"line_number":30,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { \u0027placement-common\u0027:"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_6bf8f77b","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":12},"in_reply_to":"3f79a3b5_2819a589","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  package { \u0027placement-common\u0027:"},{"line_number":34,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":35,"context_line":"    name    \u003d\u003e $::placement::params::common_package_name,"},{"line_number":36,"context_line":"    require \u003d\u003e Package[\u0027python-placement\u0027],"},{"line_number":37,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_a8161556","line":36,"range":{"start_line":36,"start_character":24,"end_line":36,"end_character":30},"updated":"2018-12-11 09:43:58.000000000","message":"same as above","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  package { \u0027placement-common\u0027:"},{"line_number":34,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":35,"context_line":"    name    \u003d\u003e $::placement::params::common_package_name,"},{"line_number":36,"context_line":"    require \u003d\u003e Package[\u0027python-placement\u0027],"},{"line_number":37,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027placement-package\u0027],"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_0bf383a1","line":36,"range":{"start_line":36,"start_character":24,"end_line":36,"end_character":30},"in_reply_to":"3f79a3b5_a8161556","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"be7a36232752e0200be363172cf3a5ebb19c1adb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*service_type*]"},{"line_number":34,"context_line":"#   Type of service. Defaults to \u0027key-manager\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*region*]"},{"line_number":37,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_cb934b59","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":47},"updated":"2018-12-11 09:53:08.000000000","message":"this one is wrong as well","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*service_type*]"},{"line_number":34,"context_line":"#   Type of service. Defaults to \u0027key-manager\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*region*]"},{"line_number":37,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_ab160f56","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":47},"in_reply_to":"3f79a3b5_cb934b59","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/keystone/authtoken.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (Optional) Required if identity server requires client certificate"},{"line_number":63,"context_line":"#   Defaults to $::os_service_default."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*check_revocations_for_cached*]"},{"line_number":66,"context_line":"#   (Optional) If true, the revocation list will be checked for cached tokens."},{"line_number":67,"context_line":"#   This requires that PKI tokens are configured on the identity server."},{"line_number":68,"context_line":"#   boolean value."},{"line_number":69,"context_line":"#   Defaults to $::os_service_default."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"# [*delay_auth_decision*]"},{"line_number":72,"context_line":"#   (Optional) Do not handle authorization requests within the middleware, but"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_4bfe5b03","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":38},"updated":"2018-12-11 09:43:58.000000000","message":"remove","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#   must be present in tokens. String value."},{"line_number":85,"context_line":"#   Defaults to $::os_service_default."},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"# [*hash_algorithms*]"},{"line_number":88,"context_line":"#   (Optional) Hash algorithms to use for hashing PKI tokens. This may be a"},{"line_number":89,"context_line":"#   single algorithm or multiple. The algorithms are those supported by Python"},{"line_number":90,"context_line":"#   standard hashlib.new(). The hashes will be tried in the order given, so put"},{"line_number":91,"context_line":"#   the preferred one first for performance. The result of the first hash will"},{"line_number":92,"context_line":"#   be stored in the cache. This will typically be set to multiple values only"},{"line_number":93,"context_line":"#   while migrating from a less secure algorithm to a more secure one. Once all"},{"line_number":94,"context_line":"#   the old tokens are expired this option should be set to a single value for"},{"line_number":95,"context_line":"#   better performance. List value."},{"line_number":96,"context_line":"#   Defaults to $::os_service_default."},{"line_number":97,"context_line":"#"},{"line_number":98,"context_line":"# [*http_connect_timeout*]"},{"line_number":99,"context_line":"#   (Optional) Request timeout value for communicating with Identity API"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_abfb6f11","line":96,"range":{"start_line":87,"start_character":0,"end_line":96,"end_character":38},"updated":"2018-12-11 09:43:58.000000000","message":"remove","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  $cache                          \u003d $::os_service_default,"},{"line_number":193,"context_line":"  $cafile                         \u003d $::os_service_default,"},{"line_number":194,"context_line":"  $certfile                       \u003d $::os_service_default,"},{"line_number":195,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":196,"context_line":"  $delay_auth_decision            \u003d $::os_service_default,"},{"line_number":197,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":198,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_e8f72d28","line":195,"range":{"start_line":195,"start_character":2,"end_line":195,"end_character":58},"updated":"2018-12-11 09:43:58.000000000","message":"remove this, we deprecated this in Stein cycle so no need to add it in since it doesn\u0027t have any effect.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  $cache                          \u003d $::os_service_default,"},{"line_number":193,"context_line":"  $cafile                         \u003d $::os_service_default,"},{"line_number":194,"context_line":"  $certfile                       \u003d $::os_service_default,"},{"line_number":195,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":196,"context_line":"  $delay_auth_decision            \u003d $::os_service_default,"},{"line_number":197,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":198,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_cb3d8b2a","line":195,"range":{"start_line":195,"start_character":2,"end_line":195,"end_character":58},"in_reply_to":"3f79a3b5_e8f72d28","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":196,"context_line":"  $delay_auth_decision            \u003d $::os_service_default,"},{"line_number":197,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":198,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"},{"line_number":199,"context_line":"  $http_connect_timeout           \u003d $::os_service_default,"},{"line_number":200,"context_line":"  $http_request_max_retries       \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $include_service_catalog        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_8bf8f317","line":198,"range":{"start_line":198,"start_character":2,"end_line":198,"end_character":58},"updated":"2018-12-11 09:43:58.000000000","message":"same as above","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  $check_revocations_for_cached   \u003d $::os_service_default,"},{"line_number":196,"context_line":"  $delay_auth_decision            \u003d $::os_service_default,"},{"line_number":197,"context_line":"  $enforce_token_bind             \u003d $::os_service_default,"},{"line_number":198,"context_line":"  $hash_algorithms                \u003d $::os_service_default,"},{"line_number":199,"context_line":"  $http_connect_timeout           \u003d $::os_service_default,"},{"line_number":200,"context_line":"  $http_request_max_retries       \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $include_service_catalog        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_eb388739","line":198,"range":{"start_line":198,"start_character":2,"end_line":198,"end_character":58},"in_reply_to":"3f79a3b5_8bf8f317","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cache                          \u003d\u003e $cache,"},{"line_number":232,"context_line":"    cafile                         \u003d\u003e $cafile,"},{"line_number":233,"context_line":"    certfile                       \u003d\u003e $certfile,"},{"line_number":234,"context_line":"    check_revocations_for_cached   \u003d\u003e $check_revocations_for_cached,"},{"line_number":235,"context_line":"    delay_auth_decision            \u003d\u003e $delay_auth_decision,"},{"line_number":236,"context_line":"    enforce_token_bind             \u003d\u003e $enforce_token_bind,"},{"line_number":237,"context_line":"    hash_algorithms                \u003d\u003e $hash_algorithms,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_cb110b53","line":234,"range":{"start_line":234,"start_character":4,"end_line":234,"end_character":68},"updated":"2018-12-11 09:43:58.000000000","message":"remove","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cache                          \u003d\u003e $cache,"},{"line_number":232,"context_line":"    cafile                         \u003d\u003e $cafile,"},{"line_number":233,"context_line":"    certfile                       \u003d\u003e $certfile,"},{"line_number":234,"context_line":"    check_revocations_for_cached   \u003d\u003e $check_revocations_for_cached,"},{"line_number":235,"context_line":"    delay_auth_decision            \u003d\u003e $delay_auth_decision,"},{"line_number":236,"context_line":"    enforce_token_bind             \u003d\u003e $enforce_token_bind,"},{"line_number":237,"context_line":"    hash_algorithms                \u003d\u003e $hash_algorithms,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_ab104fab","line":234,"range":{"start_line":234,"start_character":4,"end_line":234,"end_character":68},"in_reply_to":"3f79a3b5_cb110b53","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    check_revocations_for_cached   \u003d\u003e $check_revocations_for_cached,"},{"line_number":235,"context_line":"    delay_auth_decision            \u003d\u003e $delay_auth_decision,"},{"line_number":236,"context_line":"    enforce_token_bind             \u003d\u003e $enforce_token_bind,"},{"line_number":237,"context_line":"    hash_algorithms                \u003d\u003e $hash_algorithms,"},{"line_number":238,"context_line":"    http_connect_timeout           \u003d\u003e $http_connect_timeout,"},{"line_number":239,"context_line":"    http_request_max_retries       \u003d\u003e $http_request_max_retries,"},{"line_number":240,"context_line":"    include_service_catalog        \u003d\u003e $include_service_catalog,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_eb0c0738","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":55},"updated":"2018-12-11 09:43:58.000000000","message":"remove","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    check_revocations_for_cached   \u003d\u003e $check_revocations_for_cached,"},{"line_number":235,"context_line":"    delay_auth_decision            \u003d\u003e $delay_auth_decision,"},{"line_number":236,"context_line":"    enforce_token_bind             \u003d\u003e $enforce_token_bind,"},{"line_number":237,"context_line":"    hash_algorithms                \u003d\u003e $hash_algorithms,"},{"line_number":238,"context_line":"    http_connect_timeout           \u003d\u003e $http_connect_timeout,"},{"line_number":239,"context_line":"    http_request_max_retries       \u003d\u003e $http_request_max_retries,"},{"line_number":240,"context_line":"    include_service_catalog        \u003d\u003e $include_service_catalog,"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_4b03bb64","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":55},"in_reply_to":"3f79a3b5_eb0c0738","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/params.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      # package names"},{"line_number":19,"context_line":"      $package_name                      \u003d \u0027openstack-placement-api\u0027"},{"line_number":20,"context_line":"      $common_package_name               \u003d \u0027openstack-placement-common\u0027"},{"line_number":21,"context_line":"      $python_package_name               \u003d \"python${pyvers}-placement\""},{"line_number":22,"context_line":"      $service_name                      \u003d \u0027httpd\u0027"},{"line_number":23,"context_line":"      $public_url                        \u003d \u0027http://127.0.0.1/placement\u0027"},{"line_number":24,"context_line":"      $internal_url                      \u003d \u0027http://127.0.0.1/placement\u0027"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_eb25e7a7","line":21,"range":{"start_line":21,"start_character":27,"end_line":21,"end_character":41},"updated":"2018-12-11 09:43:58.000000000","message":"spacing on all these lines","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      # package names"},{"line_number":19,"context_line":"      $package_name                      \u003d \u0027openstack-placement-api\u0027"},{"line_number":20,"context_line":"      $common_package_name               \u003d \u0027openstack-placement-common\u0027"},{"line_number":21,"context_line":"      $python_package_name               \u003d \"python${pyvers}-placement\""},{"line_number":22,"context_line":"      $service_name                      \u003d \u0027httpd\u0027"},{"line_number":23,"context_line":"      $public_url                        \u003d \u0027http://127.0.0.1/placement\u0027"},{"line_number":24,"context_line":"      $internal_url                      \u003d \u0027http://127.0.0.1/placement\u0027"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_0b662357","line":21,"range":{"start_line":21,"start_character":27,"end_line":21,"end_character":41},"in_reply_to":"3f79a3b5_eb25e7a7","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"    \u0027Debian\u0027: {"},{"line_number":32,"context_line":"      $package_name                      \u003d \u0027placement-api\u0027"},{"line_number":33,"context_line":"      $common_package_name               \u003d \u0027placement-common\u0027"},{"line_number":34,"context_line":"      $python_package_name               \u003d \"python${pyvers}-placement\""},{"line_number":35,"context_line":"      $service_name                      \u003d \u0027placement-api\u0027"},{"line_number":36,"context_line":"      $public_url                        \u003d \u0027http://127.0.0.1\u0027"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_cb2a6b77","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":41},"updated":"2018-12-11 09:43:58.000000000","message":"spacing on all these lines","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"    \u0027Debian\u0027: {"},{"line_number":32,"context_line":"      $package_name                      \u003d \u0027placement-api\u0027"},{"line_number":33,"context_line":"      $common_package_name               \u003d \u0027placement-common\u0027"},{"line_number":34,"context_line":"      $python_package_name               \u003d \"python${pyvers}-placement\""},{"line_number":35,"context_line":"      $service_name                      \u003d \u0027placement-api\u0027"},{"line_number":36,"context_line":"      $public_url                        \u003d \u0027http://127.0.0.1\u0027"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_cb6b4b1a","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":41},"in_reply_to":"3f79a3b5_cb2a6b77","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"manifests/policy.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   Defaults to empty hash."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*policy_path*]"},{"line_number":23,"context_line":"#   (optional) Path to the nova policy.json file"},{"line_number":24,"context_line":"#   Defaults to /etc/placement/policy.json"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class placement::policy ("}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_8c37294d","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":31},"updated":"2018-11-20 20:28:48.000000000","message":"placement","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    wsgi_process_display_name \u003d\u003e $wsgi_process_display_name,"},{"line_number":151,"context_line":"    wsgi_process_group        \u003d\u003e \u0027placement-api\u0027,"},{"line_number":152,"context_line":"    wsgi_script_dir           \u003d\u003e $::placement::params::wsgi_script_path,"},{"line_number":153,"context_line":"    wsgi_script_file          \u003d\u003e \u0027nova-placement-api\u0027,"},{"line_number":154,"context_line":"    wsgi_script_source        \u003d\u003e $::placement::params::wsgi_script_source,"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_cc068175","line":153,"range":{"start_line":153,"start_character":34,"end_line":153,"end_character":52},"updated":"2018-11-20 20:28:48.000000000","message":"in extracted placement it is called \u0027placement-api\u0027","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"}],"manifests/wsgi/apache_api.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a166fd7b79f934425ef04a9de705c14a13966fe2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2015 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Emilien Macchi \u003cemilien.macchi@enovance.com\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_cfbc97dd","line":1,"updated":"2018-09-24 11:02:26.000000000","message":"does this need to be apache_api, probably not likely that placement will have another service than it\u0027s API, atleast fronting with Apache WSGI","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2015 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Emilien Macchi \u003cemilien.macchi@enovance.com\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_41461325","line":1,"in_reply_to":"3f79a3b5_cfbc97dd","updated":"2018-09-24 16:44:12.000000000","message":"Done","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"}],"metadata.json":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a166fd7b79f934425ef04a9de705c14a13966fe2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        {"},{"line_number":21,"context_line":"            \"name\": \"openstack/oslo\","},{"line_number":22,"context_line":"            \"version_requirement\": \"\u003e\u003d11.0.0 \u003c12.0.0\""},{"line_number":23,"context_line":"        }"},{"line_number":24,"context_line":"    ],"},{"line_number":25,"context_line":"    \"description\": \"Installs and configures OpenStack Placement.\","},{"line_number":26,"context_line":"    \"issues_url\": \"https://bugs.launchpad.net/puppet-placement\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_2fcbcb73","line":23,"updated":"2018-09-24 11:02:26.000000000","message":"missing apache","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        {"},{"line_number":21,"context_line":"            \"name\": \"openstack/oslo\","},{"line_number":22,"context_line":"            \"version_requirement\": \"\u003e\u003d11.0.0 \u003c12.0.0\""},{"line_number":23,"context_line":"        }"},{"line_number":24,"context_line":"    ],"},{"line_number":25,"context_line":"    \"description\": \"Installs and configures OpenStack Placement.\","},{"line_number":26,"context_line":"    \"issues_url\": \"https://bugs.launchpad.net/puppet-placement\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_61430f13","line":23,"in_reply_to":"3f79a3b5_2fcbcb73","updated":"2018-09-24 16:44:12.000000000","message":"Done","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        {"},{"line_number":37,"context_line":"            \"operatingsystem\": \"Fedora\","},{"line_number":38,"context_line":"            \"operatingsystemrelease\": ["},{"line_number":39,"context_line":"                \"24\""},{"line_number":40,"context_line":"            ]"},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"        {"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_214d173b","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":19},"updated":"2018-09-24 16:44:12.000000000","message":"Also updated this.","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a166fd7b79f934425ef04a9de705c14a13966fe2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        {"},{"line_number":49,"context_line":"            \"operatingsystem\": \"Ubuntu\","},{"line_number":50,"context_line":"            \"operatingsystemrelease\": ["},{"line_number":51,"context_line":"                \"16.04\""},{"line_number":52,"context_line":"            ]"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_4fc88774","line":51,"updated":"2018-09-24 11:02:26.000000000","message":"18.04","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"274dc74431af192913e4c56b7810d24b420ab5ac","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        {"},{"line_number":49,"context_line":"            \"operatingsystem\": \"Ubuntu\","},{"line_number":50,"context_line":"            \"operatingsystemrelease\": ["},{"line_number":51,"context_line":"                \"16.04\""},{"line_number":52,"context_line":"            ]"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_01501bd5","line":51,"in_reply_to":"3f79a3b5_4fc88774","updated":"2018-09-24 16:44:12.000000000","message":"Done","commit_id":"636c6bca35cf2f30ce5d9f91bfe09d34cfe205aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    ],"},{"line_number":66,"context_line":"    \"source\": \"git://github.com/openstack/puppet-placement.git\","},{"line_number":67,"context_line":"    \"summary\": \"Puppet module for OpenStack Placement\","},{"line_number":68,"context_line":"    \"version\": \"0.0.1\""},{"line_number":69,"context_line":"}"}],"source_content_type":"application/json","patch_set":34,"id":"3f79a3b5_eb53a707","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":22},"updated":"2018-12-11 09:43:58.000000000","message":"Lets default it to the same version as OpenStack, so 14.0.0 like all other modules.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    ],"},{"line_number":66,"context_line":"    \"source\": \"git://github.com/openstack/puppet-placement.git\","},{"line_number":67,"context_line":"    \"summary\": \"Puppet module for OpenStack Placement\","},{"line_number":68,"context_line":"    \"version\": \"0.0.1\""},{"line_number":69,"context_line":"}"}],"source_content_type":"application/json","patch_set":34,"id":"3f79a3b5_ab5e0f75","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":22},"in_reply_to":"3f79a3b5_eb53a707","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"run_unit_tests.sh":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-sh","patch_set":34,"id":"3f79a3b5_2ba3dffe","line":1,"updated":"2018-12-11 09:43:58.000000000","message":"Leftover right? Should not be needed by any jobs we run.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-sh","patch_set":34,"id":"3f79a3b5_cbd90bf2","line":1,"in_reply_to":"3f79a3b5_2ba3dffe","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"setup.cfg":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"description-file \u003d"},{"line_number":5,"context_line":"    README.md"},{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author-email \u003d openstack-dev@lists.openstack.org"},{"line_number":8,"context_line":"home-page \u003d https://docs.openstack.org/puppet-openstack-guide/latest"},{"line_number":9,"context_line":"classifier \u003d"},{"line_number":10,"context_line":"    Intended Audience :: Developers"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"3f79a3b5_4b73bba2","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":28},"updated":"2018-12-11 09:43:58.000000000","message":"discuss","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"spec/classes/placement_config_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f523d7b60195981920d421fbd8f05b94d4827e98","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      :region_name      \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":10,"context_line":"      :username            \u003d\u003e \u0027placement\u0027,"},{"line_number":11,"context_line":"      :user_domain_name    \u003d\u003e \u0027Default\u0027,"},{"line_number":12,"context_line":"      :auth_url            \u003d\u003e \u0027http://127.0.0.1:35357/v3\u0027,"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3f79a3b5_27f5c4c9","line":12,"range":{"start_line":12,"start_character":48,"end_line":12,"end_character":53},"updated":"2018-11-21 10:36:02.000000000","message":"5000","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f523d7b60195981920d421fbd8f05b94d4827e98","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          :valid_interfaces        \u003d\u003e \u0027internal\u0027,"},{"line_number":44,"context_line":"          :username            \u003d\u003e \u0027placement2\u0027,"},{"line_number":45,"context_line":"          :user_domain_name    \u003d\u003e \u0027default\u0027,"},{"line_number":46,"context_line":"          :auth_url            \u003d\u003e \u0027https://127.0.0.1:35357/v3\u0027,"},{"line_number":47,"context_line":"        )"},{"line_number":48,"context_line":"      end"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3f79a3b5_e72cac4a","line":46,"range":{"start_line":46,"start_character":53,"end_line":46,"end_character":58},"updated":"2018-11-21 10:36:02.000000000","message":"5000","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          :auth_type           \u003d\u003e \u0027password\u0027,"},{"line_number":40,"context_line":"          :project_name        \u003d\u003e \u0027service\u0027,"},{"line_number":41,"context_line":"          :project_domain_name \u003d\u003e \u0027default\u0027,"},{"line_number":42,"context_line":"          :region_name      \u003d\u003e \u0027RegionTwo\u0027,"},{"line_number":43,"context_line":"          :valid_interfaces        \u003d\u003e \u0027internal\u0027,"},{"line_number":44,"context_line":"          :username            \u003d\u003e \u0027placement2\u0027,"},{"line_number":45,"context_line":"          :user_domain_name    \u003d\u003e \u0027default\u0027,"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3f79a3b5_2b8c3f7f","line":42,"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          :auth_type           \u003d\u003e \u0027password\u0027,"},{"line_number":40,"context_line":"          :project_name        \u003d\u003e \u0027service\u0027,"},{"line_number":41,"context_line":"          :project_domain_name \u003d\u003e \u0027default\u0027,"},{"line_number":42,"context_line":"          :region_name      \u003d\u003e \u0027RegionTwo\u0027,"},{"line_number":43,"context_line":"          :valid_interfaces        \u003d\u003e \u0027internal\u0027,"},{"line_number":44,"context_line":"          :username            \u003d\u003e \u0027placement2\u0027,"},{"line_number":45,"context_line":"          :user_domain_name    \u003d\u003e \u0027default\u0027,"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3f79a3b5_cb44aba2","line":42,"in_reply_to":"3f79a3b5_2b8c3f7f","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          :project_name        \u003d\u003e \u0027service\u0027,"},{"line_number":41,"context_line":"          :project_domain_name \u003d\u003e \u0027default\u0027,"},{"line_number":42,"context_line":"          :region_name      \u003d\u003e \u0027RegionTwo\u0027,"},{"line_number":43,"context_line":"          :valid_interfaces        \u003d\u003e \u0027internal\u0027,"},{"line_number":44,"context_line":"          :username            \u003d\u003e \u0027placement2\u0027,"},{"line_number":45,"context_line":"          :user_domain_name    \u003d\u003e \u0027default\u0027,"},{"line_number":46,"context_line":"          :auth_url            \u003d\u003e \u0027https://127.0.0.1:5000/v3\u0027,"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3f79a3b5_cb86eb60","line":43,"updated":"2018-12-11 09:43:58.000000000","message":"spacing","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          :project_name        \u003d\u003e \u0027service\u0027,"},{"line_number":41,"context_line":"          :project_domain_name \u003d\u003e \u0027default\u0027,"},{"line_number":42,"context_line":"          :region_name      \u003d\u003e \u0027RegionTwo\u0027,"},{"line_number":43,"context_line":"          :valid_interfaces        \u003d\u003e \u0027internal\u0027,"},{"line_number":44,"context_line":"          :username            \u003d\u003e \u0027placement2\u0027,"},{"line_number":45,"context_line":"          :user_domain_name    \u003d\u003e \u0027default\u0027,"},{"line_number":46,"context_line":"          :auth_url            \u003d\u003e \u0027https://127.0.0.1:5000/v3\u0027,"}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3f79a3b5_eb3f2707","line":43,"in_reply_to":"3f79a3b5_cb86eb60","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}],"spec/classes/placement_db_sync_spec.rb":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45b969a84a84decc8d49a0d535af9d3257e1b400","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    it \u0027runs placement-db-sync\u0027 do"},{"line_number":8,"context_line":"      is_expected.to contain_exec(\u0027placement-db-sync\u0027).with("},{"line_number":9,"context_line":"        :command     \u003d\u003e \u0027placement-manage db_sync \u0027,"},{"line_number":10,"context_line":"        :path        \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027, ],"},{"line_number":11,"context_line":"        :refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":12,"context_line":"        :try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3f79a3b5_6cd88dec","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":49},"updated":"2018-11-20 20:28:48.000000000","message":"db sync","commit_id":"a8946d3a89683ed25e18598c0547bfe3aae0c8a8"}],"tests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"478f6cbc3e18e66d83468c2f42a6811891ab71e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The baseline for module testing used by Puppet Labs is that each manifest"},{"line_number":2,"context_line":"# should have a corresponding test manifest that declares that class or defined"},{"line_number":3,"context_line":"# type."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_4bc17b82","line":1,"updated":"2018-12-11 09:43:58.000000000","message":"can remove this file and folder, found the same on glance and removed it ealier. we can probably delete this folder from cookiecutter if it\u0027s there as well.","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e0022643e5a30f36ab9da6b3e36e075e2dc9f50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The baseline for module testing used by Puppet Labs is that each manifest"},{"line_number":2,"context_line":"# should have a corresponding test manifest that declares that class or defined"},{"line_number":3,"context_line":"# type."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3f79a3b5_2bcf5f26","line":1,"in_reply_to":"3f79a3b5_4bc17b82","updated":"2018-12-11 10:17:28.000000000","message":"Done","commit_id":"e4e4af52b50ce313612f6a717642e81fd96221c1"}]}