)]}'
{"manifests/config.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"170386d175aa6b6a50b3da1f07720c956fcaeb31","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"#   NOTE: The configuration MUST NOT be already handled by this module"},{"line_number":65,"context_line":"#   or Puppet catalog compilation will fail with duplicate resources."},{"line_number":66,"context_line":"# "},{"line_number":67,"context_line":"class placement::config("},{"line_number":68,"context_line":"  $password            \u003d false,"},{"line_number":69,"context_line":"  $auth_type           \u003d \u0027password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_21b542ef","line":66,"updated":"2019-05-31 21:40:47.000000000","message":"trailing space","commit_id":"711aee7f0a8e1eb9f1ef2bba3c4707241f5f7df2"},{"author":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"change_message_id":"f23abc7b6e11bb081be8975fa231152092ae9752","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"#   NOTE: The configuration MUST NOT be already handled by this module"},{"line_number":65,"context_line":"#   or Puppet catalog compilation will fail with duplicate resources."},{"line_number":66,"context_line":"# "},{"line_number":67,"context_line":"class placement::config("},{"line_number":68,"context_line":"  $password            \u003d false,"},{"line_number":69,"context_line":"  $auth_type           \u003d \u0027password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_ff46d54f","line":66,"in_reply_to":"9fb8cfa7_21b542ef","updated":"2019-06-10 07:55:24.000000000","message":"Done","commit_id":"711aee7f0a8e1eb9f1ef2bba3c4707241f5f7df2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"3964c87fc201cb5546edf0ed4fc35ea898d5b404","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include ::placement::deps"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  $default_parameters \u003d {"},{"line_number":83,"context_line":"    \u0027placement/auth_type\u0027            \u003d\u003e { value \u003d\u003e $auth_type},"},{"line_number":84,"context_line":"    \u0027placement/auth_url\u0027             \u003d\u003e { value \u003d\u003e $auth_url},"},{"line_number":85,"context_line":"    \u0027placement/password\u0027             \u003d\u003e { value \u003d\u003e $password, secret \u003d\u003e true},"},{"line_number":86,"context_line":"    \u0027placement/project_domain_name\u0027  \u003d\u003e { value \u003d\u003e $project_domain_name},"},{"line_number":87,"context_line":"    \u0027placement/project_name\u0027         \u003d\u003e { value \u003d\u003e $project_name},"},{"line_number":88,"context_line":"    \u0027placement/user_domain_name\u0027     \u003d\u003e { value \u003d\u003e $user_domain_name},"},{"line_number":89,"context_line":"    \u0027placement/username\u0027             \u003d\u003e { value \u003d\u003e $username},"},{"line_number":90,"context_line":"    \u0027placement/region_name\u0027          \u003d\u003e { value \u003d\u003e $region_name},"},{"line_number":91,"context_line":"    \u0027placement/valid_interfaces\u0027     \u003d\u003e { value \u003d\u003e $valid_interfaces},"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $default_parameters)"},{"line_number":95,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $placement_config)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_19292a89","line":92,"range":{"start_line":82,"start_character":2,"end_line":92,"end_character":3},"updated":"2019-06-07 09:08:15.000000000","message":"I wonder why we even have these, maybe Lee knows","commit_id":"9ec9616e0730cee1da70797ee02cd97d268ae1b3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"896910d83efb6c0a3c80381e7847c865c8c904c0","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include ::placement::deps"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  $default_parameters \u003d {"},{"line_number":83,"context_line":"    \u0027placement/auth_type\u0027            \u003d\u003e { value \u003d\u003e $auth_type},"},{"line_number":84,"context_line":"    \u0027placement/auth_url\u0027             \u003d\u003e { value \u003d\u003e $auth_url},"},{"line_number":85,"context_line":"    \u0027placement/password\u0027             \u003d\u003e { value \u003d\u003e $password, secret \u003d\u003e true},"},{"line_number":86,"context_line":"    \u0027placement/project_domain_name\u0027  \u003d\u003e { value \u003d\u003e $project_domain_name},"},{"line_number":87,"context_line":"    \u0027placement/project_name\u0027         \u003d\u003e { value \u003d\u003e $project_name},"},{"line_number":88,"context_line":"    \u0027placement/user_domain_name\u0027     \u003d\u003e { value \u003d\u003e $user_domain_name},"},{"line_number":89,"context_line":"    \u0027placement/username\u0027             \u003d\u003e { value \u003d\u003e $username},"},{"line_number":90,"context_line":"    \u0027placement/region_name\u0027          \u003d\u003e { value \u003d\u003e $region_name},"},{"line_number":91,"context_line":"    \u0027placement/valid_interfaces\u0027     \u003d\u003e { value \u003d\u003e $valid_interfaces},"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $default_parameters)"},{"line_number":95,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $placement_config)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_a3722ce2","line":92,"range":{"start_line":82,"start_character":2,"end_line":92,"end_character":3},"in_reply_to":"9fb8cfa7_19292a89","updated":"2019-06-07 13:08:13.000000000","message":"It\u0027s when the module was original made. I don\u0027t think it followed our usual pattern.  This isn\u0027t a bad pattern to just use the singular config class for all the configs but it\u0027s just odd.","commit_id":"9ec9616e0730cee1da70797ee02cd97d268ae1b3"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"5ec6bbcbd290581d7d957dd6ffb28f9b0f760b0b","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include ::placement::deps"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  $default_parameters \u003d {"},{"line_number":83,"context_line":"    \u0027placement/auth_type\u0027            \u003d\u003e { value \u003d\u003e $auth_type},"},{"line_number":84,"context_line":"    \u0027placement/auth_url\u0027             \u003d\u003e { value \u003d\u003e $auth_url},"},{"line_number":85,"context_line":"    \u0027placement/password\u0027             \u003d\u003e { value \u003d\u003e $password, secret \u003d\u003e true},"},{"line_number":86,"context_line":"    \u0027placement/project_domain_name\u0027  \u003d\u003e { value \u003d\u003e $project_domain_name},"},{"line_number":87,"context_line":"    \u0027placement/project_name\u0027         \u003d\u003e { value \u003d\u003e $project_name},"},{"line_number":88,"context_line":"    \u0027placement/user_domain_name\u0027     \u003d\u003e { value \u003d\u003e $user_domain_name},"},{"line_number":89,"context_line":"    \u0027placement/username\u0027             \u003d\u003e { value \u003d\u003e $username},"},{"line_number":90,"context_line":"    \u0027placement/region_name\u0027          \u003d\u003e { value \u003d\u003e $region_name},"},{"line_number":91,"context_line":"    \u0027placement/valid_interfaces\u0027     \u003d\u003e { value \u003d\u003e $valid_interfaces},"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $default_parameters)"},{"line_number":95,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $placement_config)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_6650c2d5","line":92,"range":{"start_line":82,"start_character":2,"end_line":92,"end_character":3},"in_reply_to":"9fb8cfa7_a3722ce2","updated":"2019-06-07 13:22:09.000000000","message":"From the default placement config file it seems the parameters do not exist in the [placement] section on the placement service [1]. I think we can remove them in a follow up patch.\n\n[1] https://docs.openstack.org/placement/latest/configuration/sample-config.html","commit_id":"9ec9616e0730cee1da70797ee02cd97d268ae1b3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e7897c66131a11b2ce25fd5b0711afc59a0b5893","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include ::placement::deps"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  $default_parameters \u003d {"},{"line_number":83,"context_line":"    \u0027placement/auth_type\u0027            \u003d\u003e { value \u003d\u003e $auth_type},"},{"line_number":84,"context_line":"    \u0027placement/auth_url\u0027             \u003d\u003e { value \u003d\u003e $auth_url},"},{"line_number":85,"context_line":"    \u0027placement/password\u0027             \u003d\u003e { value \u003d\u003e $password, secret \u003d\u003e true},"},{"line_number":86,"context_line":"    \u0027placement/project_domain_name\u0027  \u003d\u003e { value \u003d\u003e $project_domain_name},"},{"line_number":87,"context_line":"    \u0027placement/project_name\u0027         \u003d\u003e { value \u003d\u003e $project_name},"},{"line_number":88,"context_line":"    \u0027placement/user_domain_name\u0027     \u003d\u003e { value \u003d\u003e $user_domain_name},"},{"line_number":89,"context_line":"    \u0027placement/username\u0027             \u003d\u003e { value \u003d\u003e $username},"},{"line_number":90,"context_line":"    \u0027placement/region_name\u0027          \u003d\u003e { value \u003d\u003e $region_name},"},{"line_number":91,"context_line":"    \u0027placement/valid_interfaces\u0027     \u003d\u003e { value \u003d\u003e $valid_interfaces},"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $default_parameters)"},{"line_number":95,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $placement_config)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_46e7be41","line":92,"range":{"start_line":82,"start_character":2,"end_line":92,"end_character":3},"in_reply_to":"9fb8cfa7_a3722ce2","updated":"2019-06-07 13:20:57.000000000","message":"This looks like leftovers from the original copy paste out of puppet-nova tbh, pretty much all of these live outside the [placement] section of placement.conf anyway.\n\nhttps://github.com/openstack/placement/blob/master/placement/conf/placement.py","commit_id":"9ec9616e0730cee1da70797ee02cd97d268ae1b3"}],"spec/classes/placement_config_spec.rb":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"a2e20cd3465ce884e592c88b7b5e6a982c88605a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  shared_examples \u0027placement::config\u0027 do"},{"line_number":28,"context_line":"    context \u0027with required parameters\u0027 do"},{"line_number":29,"context_line":"      it { should contain_class(\u0027placement::deps\u0027) }"},{"line_number":30,"context_line":"      "},{"line_number":31,"context_line":"      it {"},{"line_number":32,"context_line":"        should contain_placement_config(\u0027placement/password\u0027).with_value(params[:password]).with_secret(true)"},{"line_number":33,"context_line":"        should contain_placement_config(\u0027placement/auth_type\u0027).with_value(default_params[:auth_type])"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9fb8cfa7_9c9487ea","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":6},"updated":"2019-06-03 08:39:30.000000000","message":"nit spaces","commit_id":"711aee7f0a8e1eb9f1ef2bba3c4707241f5f7df2"},{"author":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"change_message_id":"f23abc7b6e11bb081be8975fa231152092ae9752","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  shared_examples \u0027placement::config\u0027 do"},{"line_number":28,"context_line":"    context \u0027with required parameters\u0027 do"},{"line_number":29,"context_line":"      it { should contain_class(\u0027placement::deps\u0027) }"},{"line_number":30,"context_line":"      "},{"line_number":31,"context_line":"      it {"},{"line_number":32,"context_line":"        should contain_placement_config(\u0027placement/password\u0027).with_value(params[:password]).with_secret(true)"},{"line_number":33,"context_line":"        should contain_placement_config(\u0027placement/auth_type\u0027).with_value(default_params[:auth_type])"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9fb8cfa7_bf7a9d85","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":6},"in_reply_to":"9fb8cfa7_9c9487ea","updated":"2019-06-10 07:55:24.000000000","message":"Done","commit_id":"711aee7f0a8e1eb9f1ef2bba3c4707241f5f7df2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"636497d8eb9dd1335e966e7ae3c3d5b3833bb12c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      :username            \u003d\u003e \u0027placement\u0027,"},{"line_number":11,"context_line":"      :user_domain_name    \u003d\u003e \u0027Default\u0027,"},{"line_number":12,"context_line":"      :auth_url            \u003d\u003e \u0027http://127.0.0.1:5000/v3\u0027,"},{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  let :params do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9fb8cfa7_26508a32","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":6},"updated":"2019-06-07 13:48:44.000000000","message":"small nit","commit_id":"9ec9616e0730cee1da70797ee02cd97d268ae1b3"}]}