)]}'
{"id":"openstack%2Fpuppet-placement~816692","triplet_id":"openstack%2Fpuppet-placement~master~Ie6482ced6ab0fdf2f406d60b8c2d329dd494a636","project":"openstack/puppet-placement","branch":"master","topic":"os_package_type","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2021-11-08 11:49:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie6482ced6ab0fdf2f406d60b8c2d329dd494a636","subject":"Avoid usage of custom os_package_type fact","status":"MERGED","created":"2021-11-04 13:16:46.000000000","updated":"2021-11-08 11:49:59.000000000","submitted":"2021-11-08 11:49:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"816692-os_package_type","meta_rev_id":"a203cccf69155a2ae57c5921e93c3e40611b0144","_number":816692,"virtual_id_number":816692,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-11-08 11:49:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":2,"date":"2021-11-05 16:23:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2021-11-08 09:53:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2021-11-08 09:53:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-04 15:35:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-05 16:23:03.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-11-08 09:53:45.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"fa8862cb9bb448be486e0c75d30a248795688ba5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-04 13:16:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38c38e34ff675dec51aa6757f3cd200a0fadae07","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-04 13:17:10.000000000","message":"Topic set to os_package_type","accounts_in_message":[],"_revision_number":1},{"id":"bf5523c4c818a9d3c1f90f34f7f2bd77f3066a5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-04 13:20:42.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"cf490949ee17b61a19bde84658be26af4b69077f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-04 15:35:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/feb57654b22945cd9e892204b0b0e51b : SUCCESS in 4m 36s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/12a1d86467c64b1da79653582c46e58e : SUCCESS in 5m 09s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/11332522c29949dea5fe4b9c9e5cbbc0 : SUCCESS in 4m 48s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/e4e2c26bcf034934a278ab1079a47865 : SUCCESS in 11m 55s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/5be7617d432046a4af90185dfc356fa9 : SUCCESS in 14m 41s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3b518a9515e64e85b4cee470e00b35f8 : SUCCESS in 9m 30s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d01f112d8a81487e8a61c0ac724cfd3b : SUCCESS in 12m 11s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0721890684bf42869afa9197cb88ac93 : SUCCESS in 8m 53s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c692b9fb353d48668965826ea2cb6046 : FAILURE in 1h 16m 58s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ad9021f58f21447aaa3fde2d48d226d0 : FAILURE in 1h 14m 21s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/51f6ae7021ac4ef8a83402a9fce28f17 : FAILURE in 58m 49s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3ef62248a9c443f7af120fb5325f592a : FAILURE in 29m 43s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/f8578dd4e9ce44e9b1aa7ee39820c33c : SUCCESS in 26m 08s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7e08e9d02dbd44de9efd8eead7491d7f : SUCCESS in 1h 20m 51s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/e0af7b1941654b63b20901b5525c3b9f : SUCCESS in 1h 33m 23s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/fad3f7821f6c44a4900c5deae16e76f8 : SUCCESS in 1h 31m 22s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/891481ac75d24e7cafe671e8ac867efd : SUCCESS in 1h 33m 38s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/607c02d2b252499e96f2a1bc7e56b448 : SUCCESS in 16m 26s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/fb8d29d20625425ab32794e41237aeb0 : SUCCESS in 21m 19s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e4b364573b154468a6c9ec725b322c83 : SUCCESS in 15m 17s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/53ddda5392414293a4a13eb6c1d43df2 : SUCCESS in 18m 27s (non-voting)\n- puppet-placement-tripleo-standalone https://zuul.opendev.org/t/openstack/build/331d537e25154d98a17a5491731eab58 : SUCCESS in 1h 55m 56s","accounts_in_message":[],"_revision_number":2},{"id":"3c087c49bdb1f1e764003225c018c00c8090eac9","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-11-05 16:23:03.000000000","message":"Patch Set 2: Code-Review+2\n\nwe can probably deprecate the custom fact. It was used when we had people packaing debian packages for use on ubuntu (e.g. mirantis) so it\u0027s likely no longer something we need to carry","accounts_in_message":[],"_revision_number":2},{"id":"938a35671484c52a382c8aab6dd1392246c8400b","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-08 09:43:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"57f6866d6c0952533f5c853367afe0131de8a0c2","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-11-08 09:53:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7d3c4b5ec5b3ded887bbda9712be57c2be8d0c7e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 09:55:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1e53c9d462ba7f4054db61f80ad8ac179ff55c34","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 11:49:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6bc2c7c121c141bbba551360668a2b50 : SUCCESS in 3m 47s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1abc44b06de349ceaaaef06e4546773a : SUCCESS in 4m 31s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b4a78167c45a4d76b021051d4314dd80 : SUCCESS in 3m 28s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/6f4fa82b3fd14860ae4cf5b2524af30b : SUCCESS in 9m 35s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/0a64a1bcb68146a5a8e0bd64dc3afa09 : SUCCESS in 10m 43s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6e3a91c441864637be0fa5a2b1444ac7 : SUCCESS in 10m 11s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8daa687fb1064fc9a568b286fb74dffe : SUCCESS in 8m 52s\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/18c3f96f0db244f48920ef689a32a786 : SUCCESS in 1h 15m 29s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/752da3924a1c498f86c4756cff517d3a : SUCCESS in 1h 13m 06s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/1937611427234af397a01e5535cd6ea4 : SUCCESS in 1h 21m 07s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/aaf3043df535495d9e24878caf74d9c2 : SUCCESS in 1h 12m 27s\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/ca82173d2cc34d5187575923bcddca82 : SUCCESS in 22m 10s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/260a6795ff9640058e126e9d0677f8e7 : SUCCESS in 13m 24s (non-voting)\n- puppet-placement-tripleo-standalone https://zuul.opendev.org/t/openstack/build/3631fe70ed054afb9dbb9273cd165519 : SUCCESS in 1h 53m 10s","accounts_in_message":[],"_revision_number":2},{"id":"a203cccf69155a2ae57c5921e93c3e40611b0144","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 11:49:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11c40173f1a42cbf1c4f7a8196dfb8fde286bf63","revisions":{"2d32311f399d35963ef80733711775a4c024c19b":{"kind":"REWORK","_number":1,"created":"2021-11-04 13:16:46.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/92/816692/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-placement","ref":"refs/changes/92/816692/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/1"}}},"commit":{"parents":[{"commit":"04500c7e2545fc70547bc25a0c620cbdfe4a994f","subject":"Merge \"Bump puppetlabs-inifile\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/04500c7e2545fc70547bc25a0c620cbdfe4a994f"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:13:55.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:13:55.000000000","tz":540},"subject":"Avoid usage of custom os_package_type fact","message":"Avoid usage of custom os_package_type fact\n\nCurrently the os_package_type fact is used to distinguish Ubuntu and\nDebian but it\u0027s redundant $::operatingsystem should be enough. What is\nworse the custom fact is not injected while composing facts data in\nunit tests and has never been tested properly.\n\nChange-Id: Ie6482ced6ab0fdf2f406d60b8c2d329dd494a636\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/2d32311f399d35963ef80733711775a4c024c19b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/2d32311f399d35963ef80733711775a4c024c19b"}]},"branch":"refs/heads/master"},"11c40173f1a42cbf1c4f7a8196dfb8fde286bf63":{"kind":"NO_CHANGE","_number":2,"created":"2021-11-04 13:20:42.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/92/816692/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-placement","ref":"refs/changes/92/816692/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-placement refs/changes/92/816692/2"}}},"commit":{"parents":[{"commit":"04500c7e2545fc70547bc25a0c620cbdfe4a994f","subject":"Merge \"Bump puppetlabs-inifile\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/04500c7e2545fc70547bc25a0c620cbdfe4a994f"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:13:55.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:20:30.000000000","tz":540},"subject":"Avoid usage of custom os_package_type fact","message":"Avoid usage of custom os_package_type fact\n\nCurrently the os_package_type fact is used to distinguish Ubuntu and\nDebian but it\u0027s redundant $::operatingsystem should be enough. What is\nworse the custom fact is not injected while composing facts data in\nunit tests and has never been tested properly.\n\nChange-Id: Ie6482ced6ab0fdf2f406d60b8c2d329dd494a636\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/11c40173f1a42cbf1c4f7a8196dfb8fde286bf63"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-placement/commit/11c40173f1a42cbf1c4f7a8196dfb8fde286bf63"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}