)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0b95643335429929b06babcd3ac42b47850475c0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  $router_remote_ls_max_age   \u003d \u002760\u0027,"},{"line_number":161,"context_line":"  $router_sasl_name           \u003d \u0027qdrouterd\u0027,"},{"line_number":162,"context_line":"  $router_sasl_path           \u003d \u0027/etc/sasl2\u0027,"},{"line_number":163,"context_line":"  $router_worker_threads      \u003d $::os_workers,"},{"line_number":164,"context_line":") inherits qdr::params {"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  validate_absolute_path($router_debug_dump)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da4df55a_c6a520b6","line":163,"updated":"2016-12-21 22:44:14.000000000","message":"Don\u0027t need a release note for right now since we\u0027ve never released this module.  A test to ensure this works as expected would be nice.","commit_id":"11ffeb76518544eb49c6816edbce3d4a51cc6b85"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"044a6f9b61f25268478b4d6dc40e5c5f4bf3a994","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  $router_remote_ls_max_age   \u003d \u002760\u0027,"},{"line_number":161,"context_line":"  $router_sasl_name           \u003d \u0027qdrouterd\u0027,"},{"line_number":162,"context_line":"  $router_sasl_path           \u003d \u0027/etc/sasl2\u0027,"},{"line_number":163,"context_line":"  $router_worker_threads      \u003d $::os_workers,"},{"line_number":164,"context_line":") inherits qdr::params {"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  validate_absolute_path($router_debug_dump)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a6eadb0_92f1496d","line":163,"updated":"2016-12-20 17:40:27.000000000","message":"do you plan to have unit tests like we have in other modules?","commit_id":"11ffeb76518544eb49c6816edbce3d4a51cc6b85"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"26eccf4f61bfe12895bc711a93d6d9c660b9b244","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  $router_remote_ls_max_age   \u003d \u002760\u0027,"},{"line_number":161,"context_line":"  $router_sasl_name           \u003d \u0027qdrouterd\u0027,"},{"line_number":162,"context_line":"  $router_sasl_path           \u003d \u0027/etc/sasl2\u0027,"},{"line_number":163,"context_line":"  $router_worker_threads      \u003d $::os_workers,"},{"line_number":164,"context_line":") inherits qdr::params {"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  validate_absolute_path($router_debug_dump)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a6eadb0_315152d9","line":163,"in_reply_to":"1a6eadb0_92f1496d","updated":"2016-12-20 18:20:23.000000000","message":"Yes, would like to meet the standards of the other modules over time. \n\nI submitted this patch now as I did not want to run into an issue with puppet-openstack-integration inclusion of qdr. \n\nNote, I also need to add the support for release notes...","commit_id":"11ffeb76518544eb49c6816edbce3d4a51cc6b85"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"35e84d288c8e8fd513530e2dd8929f8347cff7bc","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  validate_re($listener_auth_peer,\u0027^(yes$|no$)\u0027)"},{"line_number":174,"context_line":"  validate_string($listener_sasl_mech)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"  if $::operatingsystem \u003d\u003d \u0027Ubuntu\u0027 {"},{"line_number":177,"context_line":"      include ::apt"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"      Class[\u0027apt::update\u0027] -\u003e Package\u003c| provider \u003d\u003d \u0027apt\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5201f7_6e5ae52b","line":176,"updated":"2017-01-05 18:25:18.000000000","message":"I know this is a copy from qdr::install, but we don\u0027t traditionally handle this in our modules. This should live outside of the puppet-qdr module.  We have the openstack_extras module that has some repo specific items. But this is environment specific so I don\u0027t think this belongs here.","commit_id":"755fa463e1dec9b1a3b8fbbf7acd0247b5f50b98"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"35e84d288c8e8fd513530e2dd8929f8347cff7bc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    provider \u003d\u003e $::qdr::params::package_provider,"},{"line_number":199,"context_line":"    require  \u003d\u003e Package[$::qdr::params::service_package_name],"},{"line_number":200,"context_line":"  }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  class { \u0027::qdr::config\u0027: } -\u003e"},{"line_number":203,"context_line":"  class { \u0027::qdr::service\u0027: }"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5201f7_8e438941","line":201,"updated":"2017-01-05 18:25:18.000000000","message":"So this loses the ordering that used to be there when class { \u0027::qdr::install\u0027: } -\u003e was there. Not that it should affect anything but it could","commit_id":"755fa463e1dec9b1a3b8fbbf7acd0247b5f50b98"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad187816602a018a95a0a7563ead11d29c1bd4e2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"#      apt::ppa { \u0027ppa:qpid/testing\u0027 : }"},{"line_number":183,"context_line":"#  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  class { \u0027::qdr::install\u0027:"},{"line_number":186,"context_line":"    ensure_package       \u003d\u003e $ensure_package,"},{"line_number":187,"context_line":"    service_package_name \u003d\u003e $::qdr::params::service_package_name,"},{"line_number":188,"context_line":"    package_provider     \u003d\u003e $::qdr::params::package_provider,"},{"line_number":189,"context_line":"    sasl_package_list    \u003d\u003e $::qdr::params::sasl_package_list,"},{"line_number":190,"context_line":"    tools_package_list   \u003d\u003e $::qdr::params::tools_package_list,"},{"line_number":191,"context_line":"  } -\u003e"},{"line_number":192,"context_line":"  class { \u0027::qdr::config\u0027: } ~\u003e"},{"line_number":193,"context_line":"  class { \u0027::qdr::service\u0027: }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_10f79259","line":193,"range":{"start_line":185,"start_character":0,"end_line":193,"end_character":29},"updated":"2017-01-06 16:04:10.000000000","message":"Should do this...\n\n  include ::qdr::install\n  include ::qdr::config\n  include ::qdr::service\n\n  Class[\u0027::qdr::install\u0027] -\u003e\n    Class[\u0027::qdr::config\u0027] -\u003e\n      Class[\u0027::qdr::service\u0027]","commit_id":"5e6bdd551e35cc7b50b0c31ab9e58fcee3c42454"}],"manifests/install.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"35e84d288c8e8fd513530e2dd8929f8347cff7bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class qdr::install"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class is called from qdr for qdrouterd service installation"},{"line_number":4,"context_line":"class qdr::install inherits qdr {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  $ensure_package       \u003d $::qdr::ensure_package"},{"line_number":7,"context_line":"  $service_package_name \u003d $::qdr::params::service_package_name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5201f7_4e5521f8","side":"PARENT","line":4,"updated":"2017-01-05 18:25:18.000000000","message":"While we don\u0027t use install in the other modules, what\u0027s the thought around removing this class and moving it\u0027s contents into init?  It might just be better to leave this in place and move the variables below to parameters on this class which would be more flexiable to allow people to customize the package names better.","commit_id":"68a0e44e8091c58ecd9b16fff497bb47f7afe724"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad187816602a018a95a0a7563ead11d29c1bd4e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class is called from qdr for qdrouterd service installation"},{"line_number":4,"context_line":"class qdr::install ("},{"line_number":5,"context_line":"  $ensure_package       \u003d \u0027installed\u0027,"},{"line_number":6,"context_line":"  $service_package_name \u003d undef,"},{"line_number":7,"context_line":"  $package_provider     \u003d undef,"},{"line_number":8,"context_line":"  $sasl_package_list    \u003d undef,"},{"line_number":9,"context_line":"  $tools_package_list   \u003d undef,"},{"line_number":10,"context_line":"){"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  package { $sasl_package_list :"},{"line_number":13,"context_line":"    ensure   \u003d\u003e $ensure_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_d03d0a2c","line":10,"range":{"start_line":5,"start_character":0,"end_line":10,"end_character":2},"updated":"2017-01-06 16:04:10.000000000","message":"class qdr::install (\n  $ensure_package       \u003d $::qdr::ensure_package\n  $service_package_name \u003d $::qdr::params::service_package_name\n  $package_provider     \u003d $::qdr::params::package_provider\n  $sasl_package_list    \u003d $::qdr::params::sasl_package_list\n  $tools_package_list   \u003d $::qdr::params::tools_package_list\n) inherits qdr {\n ...","commit_id":"5e6bdd551e35cc7b50b0c31ab9e58fcee3c42454"}],"spec/classes/init_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad187816602a018a95a0a7563ead11d29c1bd4e2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    it { is_expected.to contain_class(\u0027qdr::params\u0027) }"},{"line_number":9,"context_line":"    it { is_expected.to contain_class(\u0027qdr::config\u0027) }"},{"line_number":10,"context_line":"    it { is_expected.to contain_class(\u0027qdr::service\u0027) }"},{"line_number":11,"context_line":"  "},{"line_number":12,"context_line":"    it \u0027installs packages\u0027 do"},{"line_number":13,"context_line":"      is_expected.to contain_package(platform_params[:qdr_package_name]).with({ :ensure \u003d\u003e :installed })"},{"line_number":14,"context_line":"      platform_params[:sasl_package_list].each do |p|"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5201f7_90b8e276","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":2},"updated":"2017-01-06 16:04:10.000000000","message":"please remove this extra space","commit_id":"5e6bdd551e35cc7b50b0c31ab9e58fcee3c42454"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad187816602a018a95a0a7563ead11d29c1bd4e2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"          :mode   \u003d\u003e \u00270644\u0027,"},{"line_number":26,"context_line":"        })"},{"line_number":27,"context_line":"      end"},{"line_number":28,"context_line":"  "},{"line_number":29,"context_line":"      it do"},{"line_number":30,"context_line":"        should contain_file(\u0027/etc/qpid-dispatch\u0027).with({"},{"line_number":31,"context_line":"          :ensure \u003d\u003e :directory,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5201f7_b0b32697","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"updated":"2017-01-06 16:04:10.000000000","message":"and this extra space","commit_id":"5e6bdd551e35cc7b50b0c31ab9e58fcee3c42454"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad187816602a018a95a0a7563ead11d29c1bd4e2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    end"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  end"},{"line_number":119,"context_line":"  "},{"line_number":120,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5201f7_b07a46bb","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":2},"updated":"2017-01-06 16:04:10.000000000","message":"and this space","commit_id":"5e6bdd551e35cc7b50b0c31ab9e58fcee3c42454"}]}