)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"eda9d2c3548ebfd16522c887147061590e34d51a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make less hardcode at the modules side and stop usage"},{"line_number":10,"context_line":"of extra parameters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib3090c01bfdcb60168dd1c6db23c520a103c051e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_e0aa6b6b","line":11,"updated":"2018-11-20 11:10:14.000000000","message":"Commit message should be reworded, because the content of the patch is different now.","commit_id":"475f19582d93dd7b77f2e9f47d1034fd4011c886"}],"manifests/init.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3afd3daadb9703a8d451d3ca729f8ce174fc3f69","unresolved":false,"context_lines":[{"line_number":143,"context_line":"#"},{"line_number":144,"context_line":"class qdr("},{"line_number":145,"context_line":"  $connectors                 \u003d [],"},{"line_number":146,"context_line":"  $connectors_ssl_profiles    \u003d [],"},{"line_number":147,"context_line":"  $ensure_package             \u003d \u0027installed\u0027,"},{"line_number":148,"context_line":"  $ensure_service             \u003d \u0027running\u0027,"},{"line_number":149,"context_line":"  $enable_service             \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_899d496d","line":146,"range":{"start_line":146,"start_character":3,"end_line":146,"end_character":26},"updated":"2018-11-13 10:06:29.000000000","message":"ssl profiles are not used by connectors only. You can use then in  listener configuration, so this parameter should be named \u0027ssl_profiles\u0027.","commit_id":"e4c68a865bf6f9824ad82378d59f0e9fba3dec15"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e7df1f026ae2c6529205167e9ecdb9bbfc90deb3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  $listener_ssl_pw_file       \u003d undef,"},{"line_number":162,"context_line":"  $listener_ssl_password      \u003d undef,"},{"line_number":163,"context_line":"  $listener_trusted_certs     \u003d \u0027UNSET\u0027,"},{"line_number":164,"context_line":"  $connector_addr             \u003d \u0027127.0.0.1\u0027,"},{"line_number":165,"context_line":"  $connector_username         \u003d undef,"},{"line_number":166,"context_line":"  $connector_password         \u003d undef,"},{"line_number":167,"context_line":"  $connector_name             \u003d \u0027broker\u0027,"},{"line_number":168,"context_line":"  $connector_ssl_name         \u003d \u0027connector\u0027,"},{"line_number":169,"context_line":"  $connector_port             \u003d \u002761616\u0027,"},{"line_number":170,"context_line":"  $connector_role             \u003d undef,"},{"line_number":171,"context_line":"  $connector_require_ssl      \u003d false,"},{"line_number":172,"context_line":"  $connector_require_encrypt  \u003d false,"},{"line_number":173,"context_line":"  $connector_sasl_mech        \u003d \u0027ANONYMOUS\u0027,"},{"line_number":174,"context_line":"  $connector_ssl_cert_db      \u003d undef,"},{"line_number":175,"context_line":"  $connector_ssl_cert_file    \u003d undef,"},{"line_number":176,"context_line":"  $connector_ssl_key_file     \u003d undef,"},{"line_number":177,"context_line":"  $connector_ssl_pw_file      \u003d undef,"},{"line_number":178,"context_line":"  $connector_ssl_password     \u003d undef,"},{"line_number":179,"context_line":"  $connector_trusted_certs    \u003d \u0027UNSET\u0027,"},{"line_number":180,"context_line":"  $autolinks_addresses        \u003d [],"},{"line_number":181,"context_line":"  $extra_addresses            \u003d [],"},{"line_number":182,"context_line":"  $log_enable                 \u003d \u0027debug+\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3f79a3b5_9e8c8182","side":"PARENT","line":179,"range":{"start_line":164,"start_character":0,"end_line":179,"end_character":40},"updated":"2018-11-14 16:07:56.000000000","message":"You can\u0027t just remove these without allowing for a deprecation period. You need to deprecate them before removing them completely from the class.  This usually means setting all these values to undef and throwing a warning if they are set. You can see additional examples of deprecation in the other modules if you grep for DEPRECATED","commit_id":"b87634ca57febdcf8c930ecb5bb8adfb92358001"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7d8b532eef34b26de095a44df4ea115f484904ca","unresolved":false,"context_lines":[{"line_number":162,"context_line":"  $listener_ssl_pw_file       \u003d undef,"},{"line_number":163,"context_line":"  $listener_ssl_password      \u003d undef,"},{"line_number":164,"context_line":"  $listener_trusted_certs     \u003d \u0027UNSET\u0027,"},{"line_number":165,"context_line":"  $autolinks_addresses        \u003d [],"},{"line_number":166,"context_line":"  $extra_addresses            \u003d [],"},{"line_number":167,"context_line":"  $log_enable                 \u003d \u0027debug+\u0027,"},{"line_number":168,"context_line":"  $log_module                 \u003d \u0027DEFAULT\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3f79a3b5_31fc5a3f","line":165,"range":{"start_line":165,"start_character":2,"end_line":165,"end_character":35},"updated":"2018-11-16 20:39:53.000000000","message":"This new parameter is not used in the template. Also small nit here: could the name be autolink_addresses please?","commit_id":"9714c1d710d098f3d7c624140bb86e88f5009bab"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"8ed3f82271cb92df57201a0db05b9374738d4ff6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"# [*router_worker_threads*]"},{"line_number":141,"context_line":"#   (optional) Number of threads create to process message traffic"},{"line_number":142,"context_line":"#   Defaults to $::processorcount"},{"line_number":143,"context_line":"#"},{"line_number":144,"context_line":"class qdr("},{"line_number":145,"context_line":"  $connectors                 \u003d [],"},{"line_number":146,"context_line":"  $ssl_profiles               \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3f79a3b5_80279eaf","line":143,"updated":"2018-11-26 16:32:46.000000000","message":"Can you add the two new params to the param string here.","commit_id":"299070ebaab5f14584a283015e86a48f2e7b5896"}],"spec/classes/init_spec.rb":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3afd3daadb9703a8d451d3ca729f8ce174fc3f69","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          :listener_port         \u003d\u003e \u00275671\u0027,"},{"line_number":93,"context_line":"          :listener_auth_peer    \u003d\u003e \u0027yes\u0027,"},{"line_number":94,"context_line":"          :listener_sasl_mech    \u003d\u003e \u0027ANONYMOUS DIGEST-MD5 EXTERNAL PLAIN\u0027,"},{"line_number":95,"context_line":"          :connectors            \u003d\u003e [{\u0027role\u0027 \u003d\u003e \u0027route-container\u0027}],"},{"line_number":96,"context_line":"          :extra_listeners       \u003d\u003e [{\u0027mode\u0027 \u003d\u003e \u0027interior\u0027}],"},{"line_number":97,"context_line":"          :extra_addresses       \u003d\u003e [{\u0027prefix\u0027 \u003d\u003e \u0027exclusive\u0027}]"},{"line_number":98,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_2990b541","line":95,"range":{"start_line":95,"start_character":49,"end_line":95,"end_character":64},"updated":"2018-11-13 10:06:29.000000000","message":"What\u0027s the point of setting route-container value ...","commit_id":"e4c68a865bf6f9824ad82378d59f0e9fba3dec15"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3afd3daadb9703a8d451d3ca729f8ce174fc3f69","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/port: 5671/)"},{"line_number":105,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/authenticatePeer: yes/)"},{"line_number":106,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/saslMechanisms: ANONYMOUS DIGEST-MD5 EXTERNAL PLAIN/)"},{"line_number":107,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/role: inter-router/)"},{"line_number":108,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/mode: interior/)"},{"line_number":109,"context_line":"        should contain_file(\u0027qdrouterd.conf\u0027).with_content(/prefix: exclusive/)"},{"line_number":110,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3f79a3b5_49e3b1d8","line":107,"range":{"start_line":107,"start_character":66,"end_line":107,"end_character":78},"updated":"2018-11-13 10:06:29.000000000","message":"... when you then test for inter-router value here? Do you plan to not pass unit tests? :)","commit_id":"e4c68a865bf6f9824ad82378d59f0e9fba3dec15"}],"templates/qdrouterd.conf.erb":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3afd3daadb9703a8d451d3ca729f8ce174fc3f69","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\u003c%- @connectors.each do |connector| -%\u003e"},{"line_number":62,"context_line":"\u003c%- @connectors_ssl_profiles.each do |ssl_profile| -%\u003e"},{"line_number":63,"context_line":"connector {"},{"line_number":64,"context_line":"\u003c%- connector.each do |k,v| -%\u003e"},{"line_number":65,"context_line":"    \u003c%\u003d k %\u003e: \u003c%\u003d v %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_29ad15a4","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":54},"updated":"2018-11-13 10:06:29.000000000","message":"This loop should not be inside connectors loop. This way you will have duplicate profile configuration inside every connector configuration. IIUC this is not correct configuration and QDR will probably fail to start. \n\nYou define the ssl profiles and then just point to them using their names in connector (or listener) configuration.","commit_id":"e4c68a865bf6f9824ad82378d59f0e9fba3dec15"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5fda237efe4e25281eb66ce1474fabe40c0a7921","unresolved":false,"context_lines":[{"line_number":62,"context_line":"connector {"},{"line_number":63,"context_line":"\u003c%- connector.each do |k,v| -%\u003e"},{"line_number":64,"context_line":"    \u003c%\u003d k %\u003e: \u003c%\u003d v %\u003e"},{"line_number":65,"context_line":"\u003c%- if k \u003d\u003d \u0027sslProfile\u0027 -%\u003e"},{"line_number":66,"context_line":"\u003c%- ssl_profiles[v].each do |l,m| -%\u003e"},{"line_number":67,"context_line":"    \u003c%\u003d l %\u003e: \u003c%\u003d m %\u003e"},{"line_number":68,"context_line":"\u003c%- end -%\u003e"},{"line_number":69,"context_line":"\u003c%- end -%\u003e"},{"line_number":70,"context_line":"\u003c%- end -%\u003e"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""}],"source_content_type":"application/x-erb","patch_set":8,"id":"3f79a3b5_df6e572c","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":11},"updated":"2018-11-16 12:39:14.000000000","message":"This is invalid. As I wrote in the previous review. SSL profiles are separate configuration blocks [1] and cannot be contained in connector block.\n\n[1] https://qpid.apache.org/releases/qpid-dispatch-0.6.1/man/qdrouterd.conf.html","commit_id":"e185c537c849f9f148c6a48daa98b90bbaa745d5"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7d8b532eef34b26de095a44df4ea115f484904ca","unresolved":false,"context_lines":[{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\u003c%- end -%\u003e"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\u003c%- @connectors.each do |connector| -%\u003e"},{"line_number":71,"context_line":"connector {"},{"line_number":72,"context_line":"\u003c%- connector.each do |k,v| -%\u003e"}],"source_content_type":"application/x-erb","patch_set":9,"id":"3f79a3b5_71c97222","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":0},"updated":"2018-11-16 20:39:53.000000000","message":"We don\u0027t need those white spaces.","commit_id":"9714c1d710d098f3d7c624140bb86e88f5009bab"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7d8b532eef34b26de095a44df4ea115f484904ca","unresolved":false,"context_lines":[{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\u003c%- end -%\u003e"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"address {"},{"line_number":81,"context_line":"    prefix: unicast"},{"line_number":82,"context_line":"    distribution: closest"}],"source_content_type":"application/x-erb","patch_set":9,"id":"3f79a3b5_91cc4e34","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":0},"updated":"2018-11-16 20:39:53.000000000","message":"Ditto","commit_id":"9714c1d710d098f3d7c624140bb86e88f5009bab"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"ccef04651266430fd5faad02f7a2e9b5e39e511e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    distribution: multicast"},{"line_number":90,"context_line":"}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\u003c%- if @broker_connection \u003d\u003d \u0027yes\u0027 -%\u003e"},{"line_number":93,"context_line":"address {"},{"line_number":94,"context_line":"    prefix: queue"},{"line_number":95,"context_line":"    waypoint: yes"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"autoLink {"},{"line_number":99,"context_line":"    addr: queue.first"},{"line_number":100,"context_line":"    direction: in"},{"line_number":101,"context_line":"    connection: broker"},{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"\u003c%- @autolink_addresses.each do |autoLink| -%\u003e"},{"line_number":105,"context_line":"autoLink {"}],"source_content_type":"application/x-erb","patch_set":10,"id":"3f79a3b5_8b5bac5f","line":102,"range":{"start_line":92,"start_character":0,"end_line":102,"end_character":1},"updated":"2018-11-19 16:11:17.000000000","message":"You can achieve that just with using $autolink_addresses and $extra_addresses parameters. You don\u0027t need to implement special option $broker_connection. IMO just enabling operator to specify autolinks as is implemented below is enough and gives the operator maximum flexibility with the configuration file.\n\nFor example current implementation makes it impossible to have autolinks and extra_addresses in configuration file.","commit_id":"dce1f7cbc4c39321fdbcfb93feec625e23bb15a7"}]}