)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0121e812e44b51db588ef8ff40fe75233a38a233","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $router_id)"},{"line_number":197,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_addr)"},{"line_number":198,"context_line":"  validate_legacy(Integer, \u0027validate_re\u0027, $listener_port, [\u0027\\d+\u0027])"},{"line_number":199,"context_line":"  validate_legacy(Boolean, \u0027validate_bool\u0027, $listener_auth_peer)"},{"line_number":200,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_sasl_mech)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# TODO (ansmith) - manage repo via openstack-extras"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"537fb8b2_92fdf147","line":199,"updated":"2021-02-25 14:59:02.000000000","message":"To support backwards compatibility, just don\u0027t do this and convert yes/no string to a boolean before proceeding.","commit_id":"226c6ba7350a0d22e10d7a418f4f9eaf44eb746e"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"8788a58061a97ed77f12975a943557657beb0279","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $router_id)"},{"line_number":197,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_addr)"},{"line_number":198,"context_line":"  validate_legacy(Integer, \u0027validate_re\u0027, $listener_port, [\u0027\\d+\u0027])"},{"line_number":199,"context_line":"  validate_legacy(Boolean, \u0027validate_bool\u0027, $listener_auth_peer)"},{"line_number":200,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_sasl_mech)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# TODO (ansmith) - manage repo via openstack-extras"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"32afd1c7_bfc42118","line":199,"in_reply_to":"537fb8b2_92fdf147","updated":"2021-02-25 19:15:28.000000000","message":"Okay, that makes sense to me. I\u0027ll whip it up. Thanks","commit_id":"226c6ba7350a0d22e10d7a418f4f9eaf44eb746e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a4ec7e305e1ce5cb2b0cefa0306b8d2c891d12d","unresolved":true,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"function qdr::fixTruthy($truthyvar) \u003e\u003e Boolean {"},{"line_number":225,"context_line":"  if $truthyvar.is_a(String) {"},{"line_number":226,"context_line":"    validate_legacy(Enum[\u0027yes\u0027, \u0027no\u0027], \u0027validate_re\u0027, $truthyvar, [\u0027^(yes$|no$)\u0027])"},{"line_number":227,"context_line":"    if $truthyvar \u003d\u003d \u0027yes\u0027 {"},{"line_number":228,"context_line":"      return true"},{"line_number":229,"context_line":"    } elsif $truthyvar \u003d\u003d \u0027no\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f27df7f_4a961802","line":226,"range":{"start_line":226,"start_character":4,"end_line":226,"end_character":82},"updated":"2021-03-12 14:38:59.000000000","message":"I think it\u0027s better to deprecate usage of yes/no so that we can make this simpler in a future release.\n(This can be done as a follow up)","commit_id":"43f80842c7344f10624adf5c614951bdef3adeff"}]}
