)]}'
{"manifests/init.pp":[{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"cfa4931e60f8f2bae4632183166e1f407b38504e","unresolved":true,"context_lines":[{"line_number":198,"context_line":"  validate_legacy(Integer, \u0027validate_re\u0027, $listener_port, [\u0027\\d+\u0027])"},{"line_number":199,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_sasl_mech)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  $listener_auth_peer_bool \u003d qdr::fixTruthy($listener_auth_peer)"},{"line_number":202,"context_line":"  $listener_require_encrypt_bool \u003d qdr::fixTruthy($listener_require_encrypt)"},{"line_number":203,"context_line":"  $listener_require_ssl_bool \u003d qdr::fixTruthy($listener_require_ssl)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"75617af0_940bdc79","side":"PARENT","line":201,"updated":"2021-03-23 20:22:41.000000000","message":"Here you are removing my new _bool version of the variable, which works fine for this one, but doesn\u0027t for the other two since they are used in conditionals inside the template (old code had `if @listener_require_ssl \u003d\u003d \u0027yes\u0027` new code just has `if @listener_require_ssl`)\n\nWould you be okay with it if I put this back how it was and just add the warning on L234 and the deprecation notices to the release notes? I don\u0027t think it makes sense to support both \u0027yes\u0027 and true at the template level.\n\nOtherwise I\u0027d suggest just merging this how it is now with no further changes.","commit_id":"43f80842c7344f10624adf5c614951bdef3adeff"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13a1037a2aba8ad16ce8f7e10135c0e3d693ffb9","unresolved":true,"context_lines":[{"line_number":198,"context_line":"  validate_legacy(Integer, \u0027validate_re\u0027, $listener_port, [\u0027\\d+\u0027])"},{"line_number":199,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $listener_sasl_mech)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  $listener_auth_peer_bool \u003d qdr::fixTruthy($listener_auth_peer)"},{"line_number":202,"context_line":"  $listener_require_encrypt_bool \u003d qdr::fixTruthy($listener_require_encrypt)"},{"line_number":203,"context_line":"  $listener_require_ssl_bool \u003d qdr::fixTruthy($listener_require_ssl)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3996cc93_bebd33c4","side":"PARENT","line":201,"in_reply_to":"75617af0_940bdc79","updated":"2021-03-23 23:01:40.000000000","message":"This change was made to keep the result consistent with older versions just in case you intended backport.\nIf we don\u0027t need to backport then adding warning in L226, in fixTruthy function, is enough.","commit_id":"43f80842c7344f10624adf5c614951bdef3adeff"}]}