)]}'
{"manifests/db.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0cebd42ee1dc32688028cabab467c08824e352c8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  validate_re($database_connection_real,"},{"line_number":61,"context_line":"    \u0027(sqlite|mysql|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if \u0027sqlite\u0027 in $database_connection_real {"},{"line_number":64,"context_line":"    $sqlite_dir \u003d regsubst($database_connection_real,\u0027^sqlite:\\/\\/\\/(\\S+)+\\/(\\S+)$\u0027,\u0027\\1\u0027)"},{"line_number":65,"context_line":"    file { \u0027create_sqlite_directory\u0027:"},{"line_number":66,"context_line":"      ensure \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_bed98959","line":63,"updated":"2016-05-31 17:10:49.000000000","message":"I\u0027d prefer to see a regexp here like https://github.com/openstack/puppet-oslo/blob/master/manifests/db.pp#L146","commit_id":"5f9d1d9c0d706693e4eb8f31642d8fad236b7377"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"70d907d8303438cb15f6f3bf128956d51b729ac3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  validate_re($database_connection_real,"},{"line_number":61,"context_line":"    \u0027(sqlite|mysql|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if \u0027sqlite\u0027 in $database_connection_real {"},{"line_number":64,"context_line":"    $sqlite_dir \u003d regsubst($database_connection_real,\u0027^sqlite:\\/\\/\\/(\\S+)+\\/(\\S+)$\u0027,\u0027\\1\u0027)"},{"line_number":65,"context_line":"    file { \u0027create_sqlite_directory\u0027:"},{"line_number":66,"context_line":"      ensure \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_3c474f78","line":63,"in_reply_to":"9abb7d3a_bed98959","updated":"2016-06-01 03:32:45.000000000","message":"Done","commit_id":"5f9d1d9c0d706693e4eb8f31642d8fad236b7377"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e2c3e774aab4a8a12386073686dc384b3e3536a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if \u0027sqlite\u0027 in $database_connection_real {"},{"line_number":64,"context_line":"    $sqlite_dir \u003d regsubst($database_connection_real,\u0027^sqlite:\\/\\/\\/(\\S+)+\\/(\\S+)$\u0027,\u0027\\1\u0027)"},{"line_number":65,"context_line":"    file { \u0027create_sqlite_directory\u0027:"},{"line_number":66,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":67,"context_line":"      owner  \u003d\u003e root,"},{"line_number":68,"context_line":"      group  \u003d\u003e root,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_70a91724","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":8},"updated":"2016-05-31 15:27:35.000000000","message":"If we\u0027re going to do this, it should be an ensure resource rather than a file declaration.","commit_id":"5f9d1d9c0d706693e4eb8f31642d8fad236b7377"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e2c3e774aab4a8a12386073686dc384b3e3536a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":67,"context_line":"      owner  \u003d\u003e root,"},{"line_number":68,"context_line":"      group  \u003d\u003e root,"},{"line_number":69,"context_line":"      mode   \u003d\u003e \u00270644\u0027,"},{"line_number":70,"context_line":"      path   \u003d\u003e $sqlite_dir,"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_b0653f1f","line":69,"range":{"start_line":69,"start_character":17,"end_line":69,"end_character":21},"updated":"2016-05-31 15:27:35.000000000","message":"is this right for the directory?","commit_id":"5f9d1d9c0d706693e4eb8f31642d8fad236b7377"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"70d907d8303438cb15f6f3bf128956d51b729ac3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":67,"context_line":"      owner  \u003d\u003e root,"},{"line_number":68,"context_line":"      group  \u003d\u003e root,"},{"line_number":69,"context_line":"      mode   \u003d\u003e \u00270644\u0027,"},{"line_number":70,"context_line":"      path   \u003d\u003e $sqlite_dir,"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_5c421369","line":69,"range":{"start_line":69,"start_character":17,"end_line":69,"end_character":21},"in_reply_to":"9abb7d3a_b0653f1f","updated":"2016-06-01 03:32:45.000000000","message":"I have test it and it works, do we need to set it to \u00270755\u0027 which like /etc/nova dir?","commit_id":"5f9d1d9c0d706693e4eb8f31642d8fad236b7377"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"998a0794123f19429dc1bc08eaab669ed5129046","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  # This is only for rally SQLite"},{"line_number":64,"context_line":"  if $database_connection_real \u003d~ /^sqlite:\\/\\// {"},{"line_number":65,"context_line":"    $sqlite_dir \u003d regsubst($database_connection_real,\u0027^sqlite:\\/\\/\\/(\\S+)+\\/(\\S+)$\u0027,\u0027\\1\u0027)"},{"line_number":66,"context_line":"    file { \u0027create_sqlite_directory\u0027:"},{"line_number":67,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":68,"context_line":"      owner  \u003d\u003e root,"},{"line_number":69,"context_line":"      group  \u003d\u003e root,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9abb7d3a_1683a3cd","line":66,"updated":"2016-06-03 14:03:12.000000000","message":"I think this should be an ensure_resource(\u0027file\u0027, $sqlite_dir, { \u0027ensure\u0027 \u003d\u003e directory }) and that\u0027s it. This way if someone is managing it in their catalog it won\u0027t conflict. Additionally I believe root/root/0755 are the defaults.","commit_id":"cf773433a50515e7dd37830f69a8a42b9b7f76ac"}]}