)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ff7d38df5cbe2db2246a91c4eb58a5285650ea3a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Denis Egorenko \u003cdegorenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-15 20:42:09 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable tests for oslo_messaging_rabbit/rabit_host parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem is that value for this parameter quotes in quote \u0027,"},{"line_number":10,"context_line":"but it should be double quotes \"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_b87e94e2","line":7,"updated":"2015-06-15 17:44:46.000000000","message":"Sorry, typo here","commit_id":"9ef2e71a8825ab6ca510e49c9302271744845f73"}],"manifests/notify/rabbitmq.pp":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"c3b60a51a5662fb284390fe116dfca0ef9afcec0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_host\u0027:      value \u003d\u003e $rabbit_host;"},{"line_number":150,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_port\u0027:      value \u003d\u003e $rabbit_port;"},{"line_number":151,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e false;"},{"line_number":152,"context_line":"      # single-quotes to get literal dollar signs"},{"line_number":153,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_hosts\u0027:     value \u003d\u003e \"${rabbit_host}:${rabbit_port}\";"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_fa5df179","line":152,"updated":"2015-06-15 18:14:54.000000000","message":"according to this comment the single quotes were intentional. are you really sure you should be changing them to double-quotes? if so, then at least delete the comment to avoid confusion.","commit_id":"10a95b30b3cef3d743c04b3bc40ef19a71ed067f"},{"author":{"_account_id":13948,"name":"Bartłomiej Piotrowski","email":"bpiotrowski@mirantis.com","username":"bpiotrowski"},"change_message_id":"2b2c5d1226ff32fdaa1670def6a327a357fcc1e9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_host\u0027:      value \u003d\u003e $rabbit_host;"},{"line_number":150,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_port\u0027:      value \u003d\u003e $rabbit_port;"},{"line_number":151,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e false;"},{"line_number":152,"context_line":"      # single-quotes to get literal dollar signs"},{"line_number":153,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_hosts\u0027:     value \u003d\u003e \"${rabbit_host}:${rabbit_port}\";"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_23c0f7df","line":152,"in_reply_to":"fa32b979_03893326","updated":"2015-06-16 09:06:56.000000000","message":"It\u0027s rather mistake in puppet-glance. Both will substitute this value on their own, like it\u0027s not in *default* configs.","commit_id":"10a95b30b3cef3d743c04b3bc40ef19a71ed067f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"95ca1432fd30b22e4ad5d138a10a77dcde36fb32","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_host\u0027:      value \u003d\u003e $rabbit_host;"},{"line_number":150,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_port\u0027:      value \u003d\u003e $rabbit_port;"},{"line_number":151,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e false;"},{"line_number":152,"context_line":"      # single-quotes to get literal dollar signs"},{"line_number":153,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_hosts\u0027:     value \u003d\u003e \"${rabbit_host}:${rabbit_port}\";"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_03893326","line":152,"in_reply_to":"fa32b979_fa5df179","updated":"2015-06-16 08:59:15.000000000","message":"Toby, i think, it was some kind of mistake, because puppet-glance doesn\u0027t contain such comment and value: https://github.com/openstack/puppet-glance/blob/master/manifests/notify/rabbitmq.pp#L97","commit_id":"10a95b30b3cef3d743c04b3bc40ef19a71ed067f"}]}
