)]}'
{"manifests/init.pp":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"1d9b1cf5891eb34e8da803b29af031d52508f662","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*service_host*]"},{"line_number":41,"context_line":"#   (Optional) Hostname for sahara to listen on"},{"line_number":42,"context_line":"#   Defaults to \u00270.0.0.0\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*service_port*]"},{"line_number":45,"context_line":"#   (Optional) Port for sahara to listen on"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_68999a78","side":"PARENT","line":42,"updated":"2015-06-24 15:05:13.000000000","message":"By removing service_host, we are losing the capability to make sahara-api listen on a defined interface, which is not desirable. Maybe this option should be moved to class sahara::api?","commit_id":"aed85d74da2e55a9da86c5134bbd1a71e5a88986"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4167ef24bcc57eb600a040490506b5a249752bcf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*service_host*]"},{"line_number":41,"context_line":"#   (Optional) Hostname for sahara to listen on"},{"line_number":42,"context_line":"#   Defaults to \u00270.0.0.0\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*service_port*]"},{"line_number":45,"context_line":"#   (Optional) Port for sahara to listen on"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_10fb547a","side":"PARENT","line":42,"in_reply_to":"fa32b979_68999a78","updated":"2015-06-24 15:44:24.000000000","message":"Javier,\n\nseems you\u0027re right! It\u0027s my mistake. I\u0027ll move it to sahara::api and the same for \u0027port\u0027, i think. Thanks!","commit_id":"aed85d74da2e55a9da86c5134bbd1a71e5a88986"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*service_host*]"},{"line_number":41,"context_line":"#   (Optional) Hostname for sahara to listen on"},{"line_number":42,"context_line":"#   Defaults to \u00270.0.0.0\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*service_port*]"},{"line_number":45,"context_line":"#   (Optional) Port for sahara to listen on"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_b3871260","side":"PARENT","line":42,"in_reply_to":"fa32b979_68999a78","updated":"2015-06-24 15:58:21.000000000","message":"service_host param deprecated. Need use host parameter","commit_id":"aed85d74da2e55a9da86c5134bbd1a71e5a88986"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   (Optional) Hostname for sahara to listen on"},{"line_number":42,"context_line":"#   Defaults to \u00270.0.0.0\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*service_port*]"},{"line_number":45,"context_line":"#   (Optional) Port for sahara to listen on"},{"line_number":46,"context_line":"#   Defaults to 8386."},{"line_number":47,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_537a4678","side":"PARENT","line":44,"updated":"2015-06-24 15:58:21.000000000","message":"Need use port parameter","commit_id":"aed85d74da2e55a9da86c5134bbd1a71e5a88986"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# \u003d\u003d keystone authentication options"},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# [*keystone_username*]"},{"line_number":63,"context_line":"#   (Optional) Username for sahara credentials"},{"line_number":64,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":65,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_9339aea6","line":62,"updated":"2015-06-24 15:58:21.000000000","message":"Unused option is sahara","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (Optional) Username for sahara credentials"},{"line_number":64,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# [*keystone_password*]"},{"line_number":67,"context_line":"#   (Optional) Password for sahara credentials"},{"line_number":68,"context_line":"#   Defaults to false."},{"line_number":69,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_533fa686","line":66,"updated":"2015-06-24 15:58:21.000000000","message":"ditto","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#   (Optional) Password for sahara credentials"},{"line_number":68,"context_line":"#   Defaults to false."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*keystone_tenant*]"},{"line_number":71,"context_line":"#   (Optional) Tenant for keystone_username"},{"line_number":72,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":73,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_7342ea10","line":70,"updated":"2015-06-24 15:58:21.000000000","message":"ditto","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#   (Optional) Tenant for keystone_username"},{"line_number":72,"context_line":"#   Defaults to \u0027admin\u0027."},{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# [*keystone_url*]"},{"line_number":75,"context_line":"#   (Optional) Public identity endpoint"},{"line_number":76,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027."},{"line_number":77,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_3349c231","line":74,"updated":"2015-06-24 15:58:21.000000000","message":"ditto","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#   (Optional) Public identity endpoint"},{"line_number":76,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027."},{"line_number":77,"context_line":"#"},{"line_number":78,"context_line":"# [*identity_url*]"},{"line_number":79,"context_line":"#   (Optional) Admin identity endpoint"},{"line_number":80,"context_line":"#   Defaults to \u0027http://127.0.0.1:35357/\u0027."},{"line_number":81,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_9360cea6","line":78,"updated":"2015-06-24 15:58:21.000000000","message":"ditto","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"daa2f828a2329dfbadc567aa76177a7592fb29be","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  $database_connection \u003d \u0027mysql://sahara:secrete@localhost:3306/sahara\u0027,"},{"line_number":246,"context_line":"  $max_retries           \u003d \u002710\u0027,"},{"line_number":247,"context_line":"  $idle_timeout          \u003d \u00273600\u0027,"},{"line_number":248,"context_line":"  $keystone_username     \u003d \u0027admin\u0027,"},{"line_number":249,"context_line":"  $keystone_password     \u003d false,"},{"line_number":250,"context_line":"  $keystone_tenant       \u003d \u0027admin\u0027,"},{"line_number":251,"context_line":"  $keystone_url          \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa32b979_d30176b0","line":248,"updated":"2015-06-24 15:58:21.000000000","message":"248-252: ditto about unused params","commit_id":"0c69486f5f80e937b967cc7853f39e09696907f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"55e0c099a57ea2d40850360428fc64bbd8f0672d","unresolved":false,"context_lines":[{"line_number":674,"context_line":"  }"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"  if $manage_service or $enabled {"},{"line_number":677,"context_line":"    warning(\u0027Configuring daemon services from init class is deprecated.\u0027)"},{"line_number":678,"context_line":"    warning(\u0027Use ::sahara::service::{all|api|engine}.pp for configuring daemon services instead.\u0027)"},{"line_number":679,"context_line":"  }"},{"line_number":680,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"da20952f_e614f54d","line":677,"updated":"2015-08-31 11:43:16.000000000","message":"so you\u0027re not correctly deprecating here because the end user will see the warning without having time to update the manifest.\n\nIn this cycle, we should send the warning + declare ::sahara::service::all.pp so we are sure it will work for people running all.pp mode.\nKeeping undef for default value seems reasonable though.\n\nIn the next cycle (after stable/liberty probably), we can drop the parameters and this conditional.","commit_id":"0991a44294129616e674ff97fcf1d708434d9df0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56f2b97274da222849eaa4d41932207ad646f796","unresolved":false,"context_lines":[{"line_number":674,"context_line":"  }"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"  if $manage_service or $enabled {"},{"line_number":677,"context_line":"    warning(\u0027Configuring daemon services from init class is deprecated.\u0027)"},{"line_number":678,"context_line":"    warning(\u0027Use ::sahara::service::{all|api|engine}.pp for configuring daemon services instead.\u0027)"},{"line_number":679,"context_line":"  }"},{"line_number":680,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"da20952f_a0d6dc25","line":677,"in_reply_to":"da20952f_e614f54d","updated":"2015-08-31 15:24:13.000000000","message":"Done","commit_id":"0991a44294129616e674ff97fcf1d708434d9df0"}],"manifests/notify.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47925efb2be937bd998910e2bd13f47ad888edf2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: sahara::notify"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  Ceilometer notifications configuration for Sahara"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_d76ac9ec","line":1,"updated":"2015-06-17 22:24:43.000000000","message":"we don\u0027t use to configure RPC like this. Please have a look at other modules and see how we do that.","commit_id":"64d7514834677306574f45406b78aafc538736a2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"24f51b133a36ab37f18909861587d5fb55b78d0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: sahara::notify"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  Ceilometer notifications configuration for Sahara"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_564a2927","line":1,"in_reply_to":"fa32b979_d76ac9ec","updated":"2015-06-18 10:09:03.000000000","message":"Emillien, it\u0027s not configuring RPC. It\u0027s just configuring Ceilometer\u0027s notifications.\nThe problem is that other modules configure RPC with ceilometer notifications. In this case sahara-engine need RPC backend even if notifications are disabled. That\u0027s why i move rpc and notify configuring to different modules.","commit_id":"64d7514834677306574f45406b78aafc538736a2"}],"manifests/rpc_backend.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47925efb2be937bd998910e2bd13f47ad888edf2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: sahara_rpc_backend"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  RPC backend configuration"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_777c1db5","line":1,"updated":"2015-06-17 22:24:43.000000000","message":"same here","commit_id":"64d7514834677306574f45406b78aafc538736a2"}]}