)]}'
{"manifests/notify/qpid.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#   (Optional) The default exchange to scope topics."},{"line_number":57,"context_line":"#   Defaults to \u0027openstack\u0027."},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":60,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":61,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":62,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_1e39fea3","side":"PARENT","line":59,"updated":"2015-07-29 16:08:07.000000000","message":"no deprecation?","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4071f95b58f3bad4f0e2ed86f47e376c6260f8a2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#   (Optional) The default exchange to scope topics."},{"line_number":57,"context_line":"#   Defaults to \u0027openstack\u0027."},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":60,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":61,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":62,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_af544ffd","side":"PARENT","line":59,"in_reply_to":"3a50d1a3_1e39fea3","updated":"2015-07-29 19:06:12.000000000","message":"Emillien, see please: http://docs.openstack.org/kilo/config-reference/content/ch_configuring-sahara.html\n\nNo such parameters for qpid in Sahara - it\u0027s only for rabbit. It was a mistake, when it was added.","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7c36e760b05a509641af3a21d448081323da81a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#   (Optional) The default exchange to scope topics."},{"line_number":57,"context_line":"#   Defaults to \u0027openstack\u0027."},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":60,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":61,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":62,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a4dcd0f_5f746234","side":"PARENT","line":59,"in_reply_to":"3a50d1a3_af544ffd","updated":"2015-08-13 10:24:05.000000000","message":"the parameters might be useless, we still need to deprecate the interface and add warnings to say \"hey, drop this param from your manifests they are useless - they\u0027ll be dropped in the next release\".\n\nthis is how we deprecate things.","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"}],"manifests/notify/rabbitmq.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  sahara_config {"},{"line_number":158,"context_line":"    \u0027DEFAULT/rpc_backend\u0027:                         value \u003d\u003e \u0027rabbit\u0027;"},{"line_number":159,"context_line":"    \u0027oslo_messaging_rabbit/amqp_durable_queues\u0027:   value \u003d\u003e $durable_queues;"},{"line_number":160,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_use_ssl\u0027:        value \u003d\u003e $rabbit_use_ssl;"},{"line_number":161,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_userid\u0027:         value \u003d\u003e $rabbit_userid;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_9efbcec0","line":158,"updated":"2015-07-29 16:08:07.000000000","message":"is it in DEFAULT?","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4071f95b58f3bad4f0e2ed86f47e376c6260f8a2","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  sahara_config {"},{"line_number":158,"context_line":"    \u0027DEFAULT/rpc_backend\u0027:                         value \u003d\u003e \u0027rabbit\u0027;"},{"line_number":159,"context_line":"    \u0027oslo_messaging_rabbit/amqp_durable_queues\u0027:   value \u003d\u003e $durable_queues;"},{"line_number":160,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_use_ssl\u0027:        value \u003d\u003e $rabbit_use_ssl;"},{"line_number":161,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_userid\u0027:         value \u003d\u003e $rabbit_userid;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_0f878361","line":158,"in_reply_to":"3a50d1a3_9efbcec0","updated":"2015-07-29 19:06:12.000000000","message":"Yes, see please: http://docs.openstack.org/kilo/config-reference/content/ch_configuring-sahara.html and section Description of RPC configuration options","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_interval\u0027: value \u003d\u003e $rabbit_retry_interval;"},{"line_number":168,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_backoff\u0027:  value \u003d\u003e $rabbit_retry_backoff;"},{"line_number":169,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_max_retries\u0027:    value \u003d\u003e $rabbit_max_retries;"},{"line_number":170,"context_line":"    \u0027DEFAULT/notification_topics\u0027:                 value \u003d\u003e $notification_topics;"},{"line_number":171,"context_line":"    \u0027DEFAULT/control_exchange\u0027:                    value \u003d\u003e $control_exchange;"},{"line_number":172,"context_line":"    \u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027: value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":173,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_7efcc2b4","line":170,"updated":"2015-07-29 16:08:07.000000000","message":"is it in DEFAULT?","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4071f95b58f3bad4f0e2ed86f47e376c6260f8a2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_interval\u0027: value \u003d\u003e $rabbit_retry_interval;"},{"line_number":168,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_backoff\u0027:  value \u003d\u003e $rabbit_retry_backoff;"},{"line_number":169,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_max_retries\u0027:    value \u003d\u003e $rabbit_max_retries;"},{"line_number":170,"context_line":"    \u0027DEFAULT/notification_topics\u0027:                 value \u003d\u003e $notification_topics;"},{"line_number":171,"context_line":"    \u0027DEFAULT/control_exchange\u0027:                    value \u003d\u003e $control_exchange;"},{"line_number":172,"context_line":"    \u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027: value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":173,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_6f9887c0","line":170,"in_reply_to":"3a50d1a3_7efcc2b4","updated":"2015-07-29 19:06:12.000000000","message":"sahe here, section: Description of AMQP configuration options","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_backoff\u0027:  value \u003d\u003e $rabbit_retry_backoff;"},{"line_number":169,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_max_retries\u0027:    value \u003d\u003e $rabbit_max_retries;"},{"line_number":170,"context_line":"    \u0027DEFAULT/notification_topics\u0027:                 value \u003d\u003e $notification_topics;"},{"line_number":171,"context_line":"    \u0027DEFAULT/control_exchange\u0027:                    value \u003d\u003e $control_exchange;"},{"line_number":172,"context_line":"    \u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027: value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":173,"context_line":"  }"},{"line_number":174,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_1e2ede42","line":171,"updated":"2015-07-29 16:08:07.000000000","message":"is it in DEFAULT?","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4071f95b58f3bad4f0e2ed86f47e376c6260f8a2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_retry_backoff\u0027:  value \u003d\u003e $rabbit_retry_backoff;"},{"line_number":169,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_max_retries\u0027:    value \u003d\u003e $rabbit_max_retries;"},{"line_number":170,"context_line":"    \u0027DEFAULT/notification_topics\u0027:                 value \u003d\u003e $notification_topics;"},{"line_number":171,"context_line":"    \u0027DEFAULT/control_exchange\u0027:                    value \u003d\u003e $control_exchange;"},{"line_number":172,"context_line":"    \u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027: value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":173,"context_line":"  }"},{"line_number":174,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_2f8eff78","line":171,"in_reply_to":"3a50d1a3_1e2ede42","updated":"2015-07-29 19:06:12.000000000","message":"ditto","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"}],"manifests/notify/zeromq.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (Optional) TTL for zeromq messages."},{"line_number":33,"context_line":"#   Defaults to 30."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":36,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":37,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":38,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_be1d6a10","side":"PARENT","line":35,"updated":"2015-07-29 16:08:07.000000000","message":"no deprecation?","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7c36e760b05a509641af3a21d448081323da81a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (Optional) TTL for zeromq messages."},{"line_number":33,"context_line":"#   Defaults to 30."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":36,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":37,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":38,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a4dcd0f_1fb81ac7","side":"PARENT","line":35,"in_reply_to":"3a50d1a3_6f22c753","updated":"2015-08-13 10:24:05.000000000","message":"same comment, please deprecate the interface.","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f85e0a25d5a8044f3b7c5625149ad05d682a97e9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (Optional) TTL for zeromq messages."},{"line_number":33,"context_line":"#   Defaults to 30."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  [*kombu_ssl_version*]"},{"line_number":36,"context_line":"#    (optional) SSL version to use (valid only if SSL enabled)."},{"line_number":37,"context_line":"#    Valid values are TLSv1, SSLv23 and SSLv3. SSLv2 may be"},{"line_number":38,"context_line":"#    available on some distributions."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_6f22c753","side":"PARENT","line":35,"in_reply_to":"3a50d1a3_be1d6a10","updated":"2015-07-29 19:09:10.000000000","message":"The same as for qpid","commit_id":"d8cccf84b07972456310c571480446b7e0bc3aca"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  sahara_config {"},{"line_number":46,"context_line":"    \u0027DEFAULT/rpc_backend\u0027:           value \u003d\u003e \u0027zmq\u0027;"},{"line_number":47,"context_line":"    \u0027DEFAULT/rpc_zmq_bind_address\u0027:  value \u003d\u003e $zeromq_bind_address;"},{"line_number":48,"context_line":"    \u0027DEFAULT/rpc_zmq_port\u0027:          value \u003d\u003e $zeromq_port;"},{"line_number":49,"context_line":"    \u0027DEFAULT/rpc_zmq_contexts\u0027:      value \u003d\u003e $zeromq_contexts;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_1ed57e1a","line":46,"updated":"2015-07-29 16:08:07.000000000","message":"not in oslo messaging?","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4071f95b58f3bad4f0e2ed86f47e376c6260f8a2","unresolved":false,"context_lines":[{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  sahara_config {"},{"line_number":46,"context_line":"    \u0027DEFAULT/rpc_backend\u0027:           value \u003d\u003e \u0027zmq\u0027;"},{"line_number":47,"context_line":"    \u0027DEFAULT/rpc_zmq_bind_address\u0027:  value \u003d\u003e $zeromq_bind_address;"},{"line_number":48,"context_line":"    \u0027DEFAULT/rpc_zmq_port\u0027:          value \u003d\u003e $zeromq_port;"},{"line_number":49,"context_line":"    \u0027DEFAULT/rpc_zmq_contexts\u0027:      value \u003d\u003e $zeromq_contexts;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_0fd54341","line":46,"in_reply_to":"3a50d1a3_1ed57e1a","updated":"2015-07-29 19:06:12.000000000","message":"See please also: http://docs.openstack.org/kilo/config-reference/content/configuring-rpc.html , section - Description of ZeroMQ configuration options","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"}],"spec/classes/sahara_init_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e5b7fb0f69e8e335de225c4f5db19911da0e8055","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      it { is_expected.to contain_sahara_config(\u0027keystone_authtoken/admin_password\u0027).with_value(\u0027new_password\u0027).with_secret(true) }"},{"line_number":55,"context_line":"    end"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    context \u0027with deprecated params\u0027 do"},{"line_number":58,"context_line":"      let :params do {"},{"line_number":59,"context_line":"        :service_host      \u003d\u003e \u0027localhost\u0027,"},{"line_number":60,"context_line":"        :service_port      \u003d\u003e \u00278387\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a50d1a3_fedd3241","line":57,"updated":"2015-07-29 16:08:07.000000000","message":"excellent","commit_id":"4cdcb965561b982a10e378ad6df55e7a248fc6df"}]}