)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"411583b2a3cbdb2e1ee6da701c1df97e41f05a61","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#"},{"line_number":123,"context_line":"# \u003d\u003d rpc backend options"},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"# [*default_transport_url*]"},{"line_number":126,"context_line":"#    (optional) A URL representing the messaging driver to use and its full"},{"line_number":127,"context_line":"#    configuration. Transport URLs take the form:"},{"line_number":128,"context_line":"#      transport://user:pass@host1:port[,hostN:portN]/virtual_host"},{"line_number":129,"context_line":"#    Defaults to $::os_service_default"},{"line_number":130,"context_line":"#"},{"line_number":131,"context_line":"# [*rpc_backend*]"},{"line_number":132,"context_line":"#   (optional) The rpc backend implementation to use, can be:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_a51fda06","line":129,"range":{"start_line":125,"start_character":0,"end_line":129,"end_character":38},"updated":"2016-05-31 09:55:00.000000000","message":"add it to notify class too, please","commit_id":"d6ee0459544d6300f9a1d77f7c0b95412fc20b85"}],"manifests/notify.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"34675e2a58bd5ac1714d082df63d835a6ec98e3b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class sahara::notify ("},{"line_number":41,"context_line":"  $default_transport_url      \u003d $::sahara::default_transport_url,"},{"line_number":42,"context_line":"  $control_exchange           \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $enable_notifications       \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $notification_transport_url \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_5f4dfcc2","line":41,"range":{"start_line":41,"start_character":33,"end_line":41,"end_character":64},"updated":"2016-05-31 16:37:06.000000000","message":"is it necessary to add this parameter to main class? why not just here?","commit_id":"aa7082b72b27b4cdded85d29a81ea5699f667f7d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1fa9c5dfb9e86ce562b4fe59e11ae6d27bf65b24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class sahara::notify ("},{"line_number":41,"context_line":"  $default_transport_url      \u003d $::sahara::default_transport_url,"},{"line_number":42,"context_line":"  $control_exchange           \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $enable_notifications       \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $notification_transport_url \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_d0a716bb","line":41,"range":{"start_line":41,"start_character":33,"end_line":41,"end_character":64},"in_reply_to":"9abb7d3a_2a7a7377","updated":"2016-05-31 19:09:55.000000000","message":"Well, oslo::messaging::default class can be moved to init.pp actually. You need just deprecate parameter control_exchange here (make it undef, raise warning where it should be used now). I\u0027m ok with such approach. Also you need reflect such change in release note too.","commit_id":"aa7082b72b27b4cdded85d29a81ea5699f667f7d"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"7f0c733f0d185a31cd09fddd8c81eb04e4eb0d75","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class sahara::notify ("},{"line_number":41,"context_line":"  $default_transport_url      \u003d $::sahara::default_transport_url,"},{"line_number":42,"context_line":"  $control_exchange           \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $enable_notifications       \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $notification_transport_url \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9abb7d3a_2a7a7377","line":41,"range":{"start_line":41,"start_character":33,"end_line":41,"end_character":64},"in_reply_to":"9abb7d3a_5f4dfcc2","updated":"2016-05-31 18:26:47.000000000","message":"In oslo.messaging, the (default) transport_url defines the messaging driver to use and its full configuration for RPCs. The control_exchange scopes topics and may be overriden by an exchange name specified in the transport_url options.\n\nThere is an additional (notification) transport_url representing the messaging driver to use for notifications. This allows for RPC and notification backends to differ. If it is not set, oslo.messaging will fall back to the same configuration used for RPC (.e.g the default_transport_url).\n\nGenerally, I was approaching it thinking that init.pp would have parameters to setup RPCs (e.g. via oslo::messaging::default) and notify.pp would have parameters to setup notifications (e.g. via oslo::messaging::notifications). The challenge has been that control_exchange is sahara::notify parameter and was concerned about the impact of moving it hence the approach taken.\n\nSuggestions welcomed...","commit_id":"aa7082b72b27b4cdded85d29a81ea5699f667f7d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"01550381a6cd6fa169a686f57d5101858eb0e01c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $notification_transport_url \u003d $::os_service_default,"},{"line_number":39,"context_line":"  $notification_driver        \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $notification_topics        \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $notification_level         \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $control_exchange           \u003d undef,"},{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_9bb9497c","line":41,"updated":"2016-06-07 20:45:45.000000000","message":"add a line # DEPRECATED PARAMETERS","commit_id":"e15c218afba9298bc892e64bb7825a13837890d3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"01550381a6cd6fa169a686f57d5101858eb0e01c","unresolved":false,"context_lines":[{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $control_exchange {"},{"line_number":46,"context_line":"    warning(\u0027control_exchange is moved to sahara:: and will be removed from sahara::notify in a future release\u0027)"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  oslo::messaging::notifications { \u0027sahara_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_fbb20d93","line":46,"updated":"2016-06-07 20:45:45.000000000","message":"::sahara","commit_id":"e15c218afba9298bc892e64bb7825a13837890d3"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f974bc8733923fc090cfb12555169bf9a965c1d2","unresolved":false,"context_lines":[{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $control_exchange {"},{"line_number":47,"context_line":"    warning(\u0027control_exchange is moved to ::sahara and will be removed from sahara::notify in a future release\u0027)"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  oslo::messaging::notifications { \u0027sahara_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_3d1ffb0a","line":47,"updated":"2016-06-09 11:20:14.000000000","message":"I think it\u0027s backport incompatible change. User may expect this parameter set from this class.","commit_id":"26f73195ae775dd859bed54f825a1053c00ceb23"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"06977a1618e341662dd34670b74caa34a4746fac","unresolved":false,"context_lines":[{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $control_exchange {"},{"line_number":47,"context_line":"    warning(\u0027control_exchange is moved to ::sahara and will be removed from sahara::notify in a future release\u0027)"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  oslo::messaging::notifications { \u0027sahara_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_bd9f6b64","line":47,"in_reply_to":"7aa08908_3d1ffb0a","updated":"2016-06-09 11:22:47.000000000","message":"Yes it is. But as this parameter related to main messaging, i think that\u0027s ok. We also reflect this in release notes.","commit_id":"26f73195ae775dd859bed54f825a1053c00ceb23"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7c9270033bd8232e7fd23a1ba952dc62e08d78c0","unresolved":false,"context_lines":[{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $control_exchange {"},{"line_number":47,"context_line":"    warning(\u0027control_exchange is moved to ::sahara and will be removed from sahara::notify in a future release\u0027)"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  oslo::messaging::notifications { \u0027sahara_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_6851bfd8","line":47,"in_reply_to":"7aa08908_bd9f6b64","updated":"2016-06-09 11:38:58.000000000","message":"so let\u0027s make it more clear in release notes","commit_id":"26f73195ae775dd859bed54f825a1053c00ceb23"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ee379f8eaccbaccc900f366148643b9442fa7497","unresolved":false,"context_lines":[{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $control_exchange {"},{"line_number":47,"context_line":"    warning(\u0027control_exchange is moved to ::sahara and will be removed from sahara::notify in a future release\u0027)"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  oslo::messaging::notifications { \u0027sahara_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_6f5522f9","line":47,"updated":"2016-06-15 20:12:10.000000000","message":"well, deprecation is not well respected because the param won\u0027t be set by default but I think we can live with it...","commit_id":"c715716a9ca576f271fb61c9e6006815cf8c0316"}],"releasenotes/notes/add_transport_url_parameters-973b95ec1ad18717.yaml":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"badc446807d91db14f8cd8180a795afb9d1aabec","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add oslo.messaging transport_url parameters via puppet-oslo resource"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - control_exchange moved to sahara:: from sahara::notify and will be"},{"line_number":6,"context_line":"    removed in a future release"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_afff1aa9","line":5,"range":{"start_line":5,"start_character":30,"end_line":5,"end_character":38},"updated":"2016-06-02 19:13:58.000000000","message":"i guess release note job doesn\u0027t like this :)","commit_id":"57c07e20f17b47f9daeef43c8ebc9683acf08605"}]}