)]}'
{"manifests/notify.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"24cf84cb908057392da60ff5b6239f7945df05ce","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class sahara::notify ("},{"line_number":37,"context_line":"  $enable_notifications       \u003d false,"},{"line_number":38,"context_line":"  $notification_transport_url \u003d $::os_service_default,"},{"line_number":39,"context_line":"  $notification_driver        \u003d \u0027messagingv2\u0027,"},{"line_number":40,"context_line":"  $notification_topics        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a6eadb0_311bc0cb","line":37,"updated":"2016-12-15 23:24:02.000000000","message":"Sounds like we should deprecate this with a warning to set notification_driver if you wish to enable notifications and update the docs for $notification_driver with this information","commit_id":"187569048eadd8bbcda7b472ce211f975518100a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"24cf84cb908057392da60ff5b6239f7945df05ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $notification_transport_url \u003d $::os_service_default,"},{"line_number":39,"context_line":"  $notification_driver        \u003d \u0027messagingv2\u0027,"},{"line_number":40,"context_line":"  $notification_topics        \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $notification_level         \u003d $::os_service_default,"},{"line_number":42,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $control_exchange           \u003d undef,"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a6eadb0_517cbceb","line":41,"updated":"2016-12-15 23:24:02.000000000","message":"This should probably also be deprecated since i couldn\u0027t find this in oslo.messaging","commit_id":"187569048eadd8bbcda7b472ce211f975518100a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"24cf84cb908057392da60ff5b6239f7945df05ce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  sahara_config {"},{"line_number":65,"context_line":"    \u0027oslo_messaging_notifications/enable\u0027: value \u003d\u003e $enable_notifications;"},{"line_number":66,"context_line":"    \u0027oslo_messaging_notifications/level\u0027:  value \u003d\u003e $notification_level;"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a6eadb0_717ff8df","line":65,"updated":"2016-12-15 23:24:02.000000000","message":"I couldn\u0027t find these two items in oslo.messaging, are they consumed by sahara? If not we should remove the setting of these when we deprecate the options.","commit_id":"187569048eadd8bbcda7b472ce211f975518100a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b823441a94e4b27fb021c5610de779c609b46fef","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $notification_topics        \u003d $::os_service_default,"},{"line_number":42,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $control_exchange           \u003d undef,"},{"line_number":44,"context_line":"  $enable_notifications       \u003d $::os_service_default,"},{"line_number":45,"context_line":"  $notification_level         \u003d $::os_service_default,"},{"line_number":46,"context_line":") {"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_496cf107","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":53},"updated":"2016-12-16 16:04:32.000000000","message":"switch this to undef since we aren\u0027t using this anymore and it\u0027ll only trigger the deprecation notice if a user has set them in their catalog.","commit_id":"54a01456d847b5330cf095618797cf42d8fc3191"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b823441a94e4b27fb021c5610de779c609b46fef","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $control_exchange           \u003d undef,"},{"line_number":44,"context_line":"  $enable_notifications       \u003d $::os_service_default,"},{"line_number":45,"context_line":"  $notification_level         \u003d $::os_service_default,"},{"line_number":46,"context_line":") {"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  include ::sahara::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_a97585cb","line":45,"range":{"start_line":45,"start_character":32,"end_line":45,"end_character":53},"updated":"2016-12-16 16:04:32.000000000","message":"same","commit_id":"54a01456d847b5330cf095618797cf42d8fc3191"}]}