)]}'
{"manifests/storage/server.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47e42261229b9d2c04db9cb5af11d2d0e729bcd0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  $outgoing_chmod         \u003d \u00270644\u0027,"},{"line_number":118,"context_line":"  $max_connections        \u003d 25,"},{"line_number":119,"context_line":"  $pipeline               \u003d [\"${type}-server\"],"},{"line_number":120,"context_line":"  $mount_check            \u003d true,"},{"line_number":121,"context_line":"  $user                   \u003d \u0027swift\u0027,"},{"line_number":122,"context_line":"  $workers                \u003d \u0027auto\u0027,"},{"line_number":123,"context_line":"  $allow_versions         \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a50d1a3_0b3be99d","line":120,"updated":"2015-07-23 21:29:45.000000000","message":"We try to keep backward compatibility for at least one release.\n\nI would suggest to:\n\n1/ patch puppet-swift to run a warning if mount_check is at False and explain it will be True in the next release\n\n2/ Wait until next release\n\n3/ Do this change.","commit_id":"666392cbe6e8da2e57730c74dedcbbead264428f"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"046efbbbb9a633ef0394b8c2ef8ddbc91a5f2740","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if ($mount_check \u003d\u003d false) {"},{"line_number":145,"context_line":"    warning(\u0027The default for the mount_check parameter will change from false to true in the next release to match upstream.\u0027)"},{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  # Warn if ${type-server} isn\u0027t included in the pipeline"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_09b94a15","line":145,"updated":"2015-07-31 22:32:53.000000000","message":"Is there any reason to set this value to false? If so, someone setting it to false (on purpose) will *always* get a warning, that\u0027s inconvenient.\n\nWe can make it so the default value is undef. If the value is found to be undef, throw a warning asking the user to explicitly provide a false value to be forward compatible.\n\nIn the template, we implement a logic so if undef is passed, the false value is used, otherwise the user provided value is used.\n\nIn next version, we remove the warning and switch the default value to true.\n\nThis won\u0027t keep backward compatibility for people overriding our concat fragment but I think it\u0027s an acceptable compromise.","commit_id":"0a8992910c613f6751c5e5854a681e01c0a307c0"}]}