)]}'
{"lib/puppet/provider/service/swiftinit.rb":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"c01c633521c21218f29922815a1afd9f3a9fd7c2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  has_feature :refreshable"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  confine :any \u003d\u003e ["},{"line_number":11,"context_line":"    Facter.value(:osfamily) \u003d\u003d \u0027Debian\u0027,"},{"line_number":12,"context_line":"    Facter.value(:osfamily) \u003d\u003d \u0027RedHat\u0027"},{"line_number":13,"context_line":"  ]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":35,"id":"ba15a1d1_c6082794","line":11,"updated":"2015-09-15 20:23:06.000000000","message":"Even though the Puppet OpenStack project only officially supports EL and Ubuntu, picking Debian here is dangerous and should be limited to Ubuntu.  Upstream Debian chose to move directly to systemd and never implemented anything upstart.","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"6d5a128e050b0668ae81cdbd6eb689554876f33a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  has_feature :refreshable"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  confine :any \u003d\u003e ["},{"line_number":11,"context_line":"    Facter.value(:osfamily) \u003d\u003d \u0027Debian\u0027,"},{"line_number":12,"context_line":"    Facter.value(:osfamily) \u003d\u003d \u0027RedHat\u0027"},{"line_number":13,"context_line":"  ]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":35,"id":"ba15a1d1_14962193","line":11,"in_reply_to":"ba15a1d1_c6082794","updated":"2015-09-16 15:24:21.000000000","message":"Good point.\nCody, thank you for pointing this out. \n\nA primary goal of this patch is to make swift support more generic across operating systems while providing more control.\nI have now made changes in the next patch that will include upstream Debian in the systemd case and ONLY include Ubuntu in the upstart case.  Though upstream Debian is not officially supported I don\u0027t want to exclude it when its simple enough for me to adjust my patch as I have.","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"5332c3390d78889cb96c99090d60832d8eceb5b0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  def disable"},{"line_number":101,"context_line":"    if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":102,"context_line":"      systemctl_run(\u0027disable\u0027, [resource[:pattern]], true)"},{"line_number":103,"context_line":"      File.delete(\"/etc/systemd/system/#{resource[:manifest]}.service\")"},{"line_number":104,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":105,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":106,"context_line":"      File.delete(\"/etc/init/#{resource[:pattern]}.conf\")"}],"source_content_type":"text/x-ruby","patch_set":40,"id":"9a1a9d01_c53f1986","line":103,"updated":"2015-10-01 16:42:46.000000000","message":"This is probably not needed anymore, as we are not creating the file in enable, right? Or should the commented out code not be commented?","commit_id":"bc6b87869fa43a59ef4a8ea7a7557785919959f1"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"39d5d59734dc1d7d52dc5c45445c97f4c305f00f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  def disable"},{"line_number":101,"context_line":"    if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":102,"context_line":"      systemctl_run(\u0027disable\u0027, [resource[:pattern]], true)"},{"line_number":103,"context_line":"      File.delete(\"/etc/systemd/system/#{resource[:manifest]}.service\")"},{"line_number":104,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":105,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":106,"context_line":"      File.delete(\"/etc/init/#{resource[:pattern]}.conf\")"}],"source_content_type":"text/x-ruby","patch_set":40,"id":"9a1a9d01_9a487389","line":103,"in_reply_to":"9a1a9d01_c53f1986","updated":"2015-10-02 13:48:59.000000000","message":"Good eye.  The above was left commented during testing by mistake.  We are creating those files to control service start at boot time.   Thank you for your review.","commit_id":"bc6b87869fa43a59ef4a8ea7a7557785919959f1"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"5332c3390d78889cb96c99090d60832d8eceb5b0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      File.delete(\"/etc/systemd/system/#{resource[:manifest]}.service\")"},{"line_number":104,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":105,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":106,"context_line":"      File.delete(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":107,"context_line":"    end"},{"line_number":108,"context_line":"  end"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":40,"id":"9a1a9d01_65516dd8","line":106,"updated":"2015-10-01 16:42:46.000000000","message":"Same as above.","commit_id":"bc6b87869fa43a59ef4a8ea7a7557785919959f1"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"39d5d59734dc1d7d52dc5c45445c97f4c305f00f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      File.delete(\"/etc/systemd/system/#{resource[:manifest]}.service\")"},{"line_number":104,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":105,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":106,"context_line":"      File.delete(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":107,"context_line":"    end"},{"line_number":108,"context_line":"  end"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":40,"id":"9a1a9d01_5a741bce","line":106,"in_reply_to":"9a1a9d01_65516dd8","updated":"2015-10-02 13:48:59.000000000","message":"Done","commit_id":"bc6b87869fa43a59ef4a8ea7a7557785919959f1"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"2bc10d31ccf09894de0f7d055a7ef97639b14827","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      # not running then send stop to systemctl so that service can be started"},{"line_number":22,"context_line":"      # with swift-init and fully managed by this provider."},{"line_number":23,"context_line":"      if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":24,"context_line":"        systemctl_run(\u0027stop\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"},{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":"      return :stopped"},{"line_number":27,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":43,"id":"7a2fa921_ef9dc866","line":24,"updated":"2015-10-08 13:50:10.000000000","message":"If we are going to use this block to stop the distro-provided service, we should also disable the service, as we will be later replacing it with our own one, but keeping the same name. It may work without this, but it would be cleaner.","commit_id":"1df126c255fa6032e0b6bb5b0031da9d7fba9efb"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"c56a27c18fc1ac3b875ba406b1f3a0aafbeb7c7b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      # not running then send stop to systemctl so that service can be started"},{"line_number":22,"context_line":"      # with swift-init and fully managed by this provider."},{"line_number":23,"context_line":"      if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":24,"context_line":"        systemctl_run(\u0027stop\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"},{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":"      return :stopped"},{"line_number":27,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":43,"id":"5a2ca52d_9a7c7fb6","line":24,"in_reply_to":"7a2fa921_ef9dc866","updated":"2015-10-16 18:23:36.000000000","message":"I agree, great idea.","commit_id":"1df126c255fa6032e0b6bb5b0031da9d7fba9efb"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"2bc10d31ccf09894de0f7d055a7ef97639b14827","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      )"},{"line_number":85,"context_line":"      file.write(file)"},{"line_number":86,"context_line":"      systemctl_run(\u0027enable\u0027, [resource[:pattern]], false)"},{"line_number":87,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":88,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":89,"context_line":"      file \u003d Puppet::Type.type(:file).new("},{"line_number":90,"context_line":"        :name    \u003d\u003e \"/etc/init/#{resource[:pattern]}.conf\","}],"source_content_type":"text/x-ruby","patch_set":43,"id":"7a2fa921_2f98a077","line":87,"updated":"2015-10-08 13:50:10.000000000","message":"I would reverse the order here, first daemon-reload (so systemd takes the new configuration), then enable. This is not doing any harm as it is now, because we are manually starting the service using swift-init, but it makes more sense from the systemd point of view.","commit_id":"1df126c255fa6032e0b6bb5b0031da9d7fba9efb"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"c56a27c18fc1ac3b875ba406b1f3a0aafbeb7c7b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      )"},{"line_number":85,"context_line":"      file.write(file)"},{"line_number":86,"context_line":"      systemctl_run(\u0027enable\u0027, [resource[:pattern]], false)"},{"line_number":87,"context_line":"      systemctl_run(\u0027daemon-reload\u0027, nil, true)"},{"line_number":88,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":89,"context_line":"      file \u003d Puppet::Type.type(:file).new("},{"line_number":90,"context_line":"        :name    \u003d\u003e \"/etc/init/#{resource[:pattern]}.conf\","}],"source_content_type":"text/x-ruby","patch_set":43,"id":"5a2ca52d_05b803c7","line":87,"in_reply_to":"7a2fa921_2f98a077","updated":"2015-10-16 18:23:36.000000000","message":"Good to know. \nDone","commit_id":"1df126c255fa6032e0b6bb5b0031da9d7fba9efb"}],"manifests/manage_boot.pp":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"19512221b85b9d7dac098826839c9570bf95d608","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      # init file names match service package names for swift services"},{"line_number":70,"context_line":"      $service_file \u003d getvar(\"::swift::params::${type}_${subtype}_service_name\")"},{"line_number":71,"context_line":"      if $enable {"},{"line_number":72,"context_line":"        file { \"/usr/lib/systemd/system/${service_file}.service\":"},{"line_number":73,"context_line":"          ensure  \u003d\u003e file,"},{"line_number":74,"context_line":"          content \u003d\u003e template(\u0027swift/type-subtype-systemd.erb\u0027),"},{"line_number":75,"context_line":"          mode    \u003d\u003e \u00270644\u0027,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"da20952f_29524bde","line":72,"updated":"2015-09-02 10:09:47.000000000","message":"You\u0027ll probably want to run \"systemctl daemon-reload\" after deploying or removing the file, to signal systemd that there is a new unit file.\n\nAlso, it is not a good idea to place user-defined unit files under /usr/lib/systemd/system, I would recommend to put them under /etc/systemd/system","commit_id":"df7d9956c641f32cd1790e7f60780a52439101a5"}],"manifests/objectexpirer.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"71126cc45e6e715676f10b64d544132e13a5892c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $reclaim_age                   \u003d 604800,"},{"line_number":79,"context_line":"  $recon_cache_path              \u003d \u0027/var/cache/swift\u0027,"},{"line_number":80,"context_line":"  $report_interval               \u003d 300,"},{"line_number":81,"context_line":"  $service_provider              \u003d $::swift::params::service_provider"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  include ::swift::params"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_76a306b3","line":81,"updated":"2015-11-10 20:39:12.000000000","message":"If swift::params hasn\u0027t already been included by something else when this class is pulled in, then this default won\u0027t work.  The normal way of addressing that is to inherit from the swift::params class.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"a790d71a0f58bc1611e209e5ba89efb4da73a4ab","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $reclaim_age                   \u003d 604800,"},{"line_number":79,"context_line":"  $recon_cache_path              \u003d \u0027/var/cache/swift\u0027,"},{"line_number":80,"context_line":"  $report_interval               \u003d 300,"},{"line_number":81,"context_line":"  $service_provider              \u003d $::swift::params::service_provider"},{"line_number":82,"context_line":") {"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  include ::swift::params"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_ff41dd63","line":81,"in_reply_to":"da85f559_76a306b3","updated":"2015-11-11 17:08:59.000000000","message":"I agree that this is a good corner case to protect against.  I\u0027ll put up an update to inherit from params.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"}],"manifests/proxy.pp":[{"author":{"_account_id":5559,"name":"gui maluf balzana","display_name":"Gui Maluf Balzana","email":"guilherme.balzana@canonical.com","username":"guimalufb"},"change_message_id":"3900f1b076edb39b36cdf41604da3dd58f003a9f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#    Configures log_name for swift proxy-server."},{"line_number":99,"context_line":"#    Optional. Defaults to proxy-server"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#  [*service_provider*]"},{"line_number":102,"context_line":"#    (optional) Default is to use service providers specified"},{"line_number":103,"context_line":"#    in params file.  To use the swiftinit service provider"},{"line_number":104,"context_line":"#    set this value to \"swiftinit\".  Using the swiftinit service"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"da20952f_a8a027f4","line":101,"updated":"2015-09-11 15:07:17.000000000","message":"I think you should be more practical in these docs. \nEverything from your commit to these explanations are too long to read, it could be straight forward. Maybe you could put all those details in some README or blueprint or even the future doc[1]\n\n[1] https://review.openstack.org/#/c/220555/","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"6d5a128e050b0668ae81cdbd6eb689554876f33a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#    Configures log_name for swift proxy-server."},{"line_number":99,"context_line":"#    Optional. Defaults to proxy-server"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#  [*service_provider*]"},{"line_number":102,"context_line":"#    (optional) Default is to use service providers specified"},{"line_number":103,"context_line":"#    in params file.  To use the swiftinit service provider"},{"line_number":104,"context_line":"#    set this value to \"swiftinit\".  Using the swiftinit service"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"ba15a1d1_74bc3ddc","line":101,"in_reply_to":"da20952f_a8a027f4","updated":"2015-09-16 15:24:21.000000000","message":"I agree.\nIn the next patch I have contributed to the README adding detailed sections on my additions.  I reduced the amount of details in each class and point readers to the README for more detail.","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":5559,"name":"gui maluf balzana","display_name":"Gui Maluf Balzana","email":"guilherme.balzana@canonical.com","username":"guimalufb"},"change_message_id":"3900f1b076edb39b36cdf41604da3dd58f003a9f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":235,"context_line":"    }"},{"line_number":236,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":237,"context_line":"    swift::manage_boot { \u0027swift-proxy-server\u0027:"},{"line_number":238,"context_line":"      enable           \u003d\u003e $enabled,"},{"line_number":239,"context_line":"      config_file_name \u003d\u003e [[\u0027proxy-sever.conf\u0027]],"},{"line_number":240,"context_line":"    } -\u003e # and then"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"da20952f_68af6fe3","line":237,"updated":"2015-09-11 15:07:17.000000000","message":"I\u0027ve seen that you use alot this manage_boot -\u003e service pattern, could this be a resource?","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"ad27426da927ad05bc71dce3d6581ba1d041923b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":235,"context_line":"    }"},{"line_number":236,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":237,"context_line":"    swift::manage_boot { \u0027swift-proxy-server\u0027:"},{"line_number":238,"context_line":"      enable           \u003d\u003e $enabled,"},{"line_number":239,"context_line":"      config_file_name \u003d\u003e [[\u0027proxy-sever.conf\u0027]],"},{"line_number":240,"context_line":"    } -\u003e # and then"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"ba15a1d1_7e15e53d","line":237,"in_reply_to":"da20952f_68af6fe3","updated":"2015-09-17 02:29:32.000000000","message":"After some soul searching, I have moved this functionality into the swiftinit service provider. I have removed the manage_boot type entirely.  Its much cleaner having it all in the provider.  Thanks for the push in this direction.","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"6d5a128e050b0668ae81cdbd6eb689554876f33a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":235,"context_line":"    }"},{"line_number":236,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":237,"context_line":"    swift::manage_boot { \u0027swift-proxy-server\u0027:"},{"line_number":238,"context_line":"      enable           \u003d\u003e $enabled,"},{"line_number":239,"context_line":"      config_file_name \u003d\u003e [[\u0027proxy-sever.conf\u0027]],"},{"line_number":240,"context_line":"    } -\u003e # and then"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"ba15a1d1_74075dca","line":237,"in_reply_to":"da20952f_68af6fe3","updated":"2015-09-16 15:24:21.000000000","message":"I looked this over many times and feel like the defined type provides the same ability as a resource might in this situation.  I\u0027d like to stick with it as is.","commit_id":"3ea053464d7291152d3cbf47c5c9293b97cb4675"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"71126cc45e6e715676f10b64d544132e13a5892c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  $manage_service            \u003d true,"},{"line_number":139,"context_line":"  $enabled                   \u003d true,"},{"line_number":140,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":141,"context_line":"  $service_provider          \u003d $::swift::params::service_provider"},{"line_number":142,"context_line":") {"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  include ::swift::params"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_b6740e36","line":141,"updated":"2015-11-10 20:39:12.000000000","message":"Missing comma at end of the line. Same issue with swift::params possibly not being included at this point","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"a790d71a0f58bc1611e209e5ba89efb4da73a4ab","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  $manage_service            \u003d true,"},{"line_number":139,"context_line":"  $enabled                   \u003d true,"},{"line_number":140,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":141,"context_line":"  $service_provider          \u003d $::swift::params::service_provider"},{"line_number":142,"context_line":") {"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  include ::swift::params"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_9f7c51b6","line":141,"in_reply_to":"da85f559_b6740e36","updated":"2015-11-11 17:08:59.000000000","message":"I agree that this is a good corner case to protect against.  I\u0027ll put up an update to inherit from params.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"71126cc45e6e715676f10b64d544132e13a5892c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  include ::swift::params"},{"line_number":145,"context_line":"  include ::concat::setup"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  Swift_config\u003c| |\u003e ~\u003e Service[\u0027swift-proxy-server\u0027]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  validate_bool($account_autocreate)"},{"line_number":150,"context_line":"  validate_bool($allow_account_management)"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_b6c2ce32","line":147,"updated":"2015-11-10 20:39:12.000000000","message":"Would it make more sense to have a deps class like puppet-heat does that just does something more generic like:\n\n    Swift_config\u003c||\u003e -\u003e Service\u003c| tag \u003d\u003d \u0027swift-service\u0027|\u003e\n\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/deps.pp\n\nIn a future patch you might want to do something like this also:\n\n    Package\u003c| tag \u003d\u003d \u0027swift-package\u0027|\u003e -\u003e Swift_config\u003c||\u003e\n\nwhich will allow you to remove all the Package deps from the services.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"a790d71a0f58bc1611e209e5ba89efb4da73a4ab","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  include ::swift::params"},{"line_number":145,"context_line":"  include ::concat::setup"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  Swift_config\u003c| |\u003e ~\u003e Service[\u0027swift-proxy-server\u0027]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  validate_bool($account_autocreate)"},{"line_number":150,"context_line":"  validate_bool($allow_account_management)"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_cb277fc8","line":147,"in_reply_to":"da85f559_b6c2ce32","updated":"2015-11-11 17:08:59.000000000","message":"This is an interesting idea, thanks for sharing.  I\u0027ll take a closer look at this and consider a future patch set that might make use of it.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"}],"manifests/storage/account.pp":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"19512221b85b9d7dac098826839c9570bf95d608","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":59,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":60,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":61,"context_line":"    provider   \u003d\u003e \u0027swiftinit\u0027,"},{"line_number":62,"context_line":"    pattern    \u003d\u003e getvar(::swift::params::account_reaper_service_name),"},{"line_number":63,"context_line":"    manifest   \u003d\u003e $config_file_name,"},{"line_number":64,"context_line":"    require    \u003d\u003e Package[\u0027swift-account\u0027],"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"da20952f_099f4760","line":61,"updated":"2015-09-02 10:09:47.000000000","message":"I\u0027m not convinced by the idea of having swiftinit used by default. It is breaking compatibility with previous releases (users will not be very happy to see their Swift services are now started in a different way), and it also bypasses any changes done in packaging.\n\nSince there is now a new provider for \"service\", let\u0027s use that. I would create a new parameter for each class (for example, $service_provider), with a default value of undef. If it has the default value, it will use the OS-provided init scripts. If it is \u0027swiftinit\u0027, then the new service provider will take over.","commit_id":"df7d9956c641f32cd1790e7f60780a52439101a5"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"71126cc45e6e715676f10b64d544132e13a5892c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      hasrestart \u003d\u003e true,"},{"line_number":82,"context_line":"      provider   \u003d\u003e \u0027swiftinit\u0027,"},{"line_number":83,"context_line":"      pattern    \u003d\u003e $::swift::params::account_reaper_service_name,"},{"line_number":84,"context_line":"      manifest   \u003d\u003e $config_file_name,"},{"line_number":85,"context_line":"      require    \u003d\u003e Package[\u0027swift-account\u0027],"},{"line_number":86,"context_line":"      tag        \u003d\u003e \u0027swift-service\u0027,"},{"line_number":87,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_b61e4eb9","line":84,"updated":"2015-11-10 20:39:12.000000000","message":"If you pass manifest and pattern into the default service provider, but they\u0027re undef, does Puppet complain?  If not, you might be able to remove a lot of these conditionals.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"a790d71a0f58bc1611e209e5ba89efb4da73a4ab","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      hasrestart \u003d\u003e true,"},{"line_number":82,"context_line":"      provider   \u003d\u003e \u0027swiftinit\u0027,"},{"line_number":83,"context_line":"      pattern    \u003d\u003e $::swift::params::account_reaper_service_name,"},{"line_number":84,"context_line":"      manifest   \u003d\u003e $config_file_name,"},{"line_number":85,"context_line":"      require    \u003d\u003e Package[\u0027swift-account\u0027],"},{"line_number":86,"context_line":"      tag        \u003d\u003e \u0027swift-service\u0027,"},{"line_number":87,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"da85f559_cb569f5b","line":84,"in_reply_to":"da85f559_b61e4eb9","updated":"2015-11-11 17:08:59.000000000","message":"manifest and pattern are used by the swiftinit provider to provide the functionality it does.  They are required.","commit_id":"3b6c756c899829b840e01df800cd71db57d319ad"}]}