)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"650f2eafebfd3db3f45db49d26348b410678f312","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create ring builders under swift user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since we\u0027re running ring rebalance unser \u0027swift\u0027 user, we also"},{"line_number":10,"context_line":"need to create ring builders under the same user."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I04972e883b8f5f6355737545525f6dc32582563d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_1873e54e","line":9,"updated":"2015-11-25 21:22:41.000000000","message":"typo i guess, under","commit_id":"36ee91aacc7a1f0848688ec9fa61b8012e9379b6"}],"manifests/ringbuilder/create.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"be8030de169d47f1ebd69604f696395720b8b935","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  exec { \"create_${name}\":"},{"line_number":40,"context_line":"    command \u003d\u003e \"swift-ring-builder /etc/swift/${name}.builder create ${part_power} ${replicas} ${min_part_hours}\","},{"line_number":41,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027],"},{"line_number":42,"context_line":"    user    \u003d\u003e \"swift\","},{"line_number":43,"context_line":"    creates \u003d\u003e \"/etc/swift/${name}.builder\","},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_a925deae","line":42,"updated":"2015-12-01 10:52:38.000000000","message":"should be a single quotes","commit_id":"c909ea647572a2f877246ca97053ee5f5b84a1bb"},{"author":{"_account_id":18290,"name":"Kyrylo Galanov","email":"kgalanov@mirantis.com","username":"kgalanov"},"change_message_id":"8ac1d9a457de37cbac682e86842a1ad35749424c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  exec { \"create_${name}\":"},{"line_number":40,"context_line":"    command \u003d\u003e \"swift-ring-builder /etc/swift/${name}.builder create ${part_power} ${replicas} ${min_part_hours}\","},{"line_number":41,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027],"},{"line_number":42,"context_line":"    user    \u003d\u003e \"swift\","},{"line_number":43,"context_line":"    creates \u003d\u003e \"/etc/swift/${name}.builder\","},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_bc3bda9b","line":42,"in_reply_to":"9a8ffd7b_a925deae","updated":"2015-12-01 11:12:03.000000000","message":"Done","commit_id":"c909ea647572a2f877246ca97053ee5f5b84a1bb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"600729d83b45ac643bfc473cf23b46d5985a434c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  exec { \"create_${name}\":"},{"line_number":40,"context_line":"    command \u003d\u003e \"swift-ring-builder /etc/swift/${name}.builder create ${part_power} ${replicas} ${min_part_hours}\","},{"line_number":41,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027],"},{"line_number":42,"context_line":"    user    \u003d\u003e \u0027swift\u0027,"},{"line_number":43,"context_line":"    creates \u003d\u003e \"/etc/swift/${name}.builder\","},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_0acda865","line":42,"updated":"2015-12-07 15:57:51.000000000","message":"This should either be configurable or perhaps pull from storage/server.pp","commit_id":"218928887e68de760763be47252d30aedbc28229"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fcf8f2c9f58b353d6cc6ca9fedfe3fb1e4c2ac15","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  exec { \"create_${name}\":"},{"line_number":40,"context_line":"    command \u003d\u003e \"swift-ring-builder /etc/swift/${name}.builder create ${part_power} ${replicas} ${min_part_hours}\","},{"line_number":41,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027],"},{"line_number":42,"context_line":"    user    \u003d\u003e \u0027swift\u0027,"},{"line_number":43,"context_line":"    creates \u003d\u003e \"/etc/swift/${name}.builder\","},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_c1f8297f","line":42,"in_reply_to":"7a740942_06d3b239","updated":"2015-12-10 14:18:31.000000000","message":"So for this change I would say, no this needs to be configurable since it\u0027s new and that isn\u0027t where the user for the jobs is set. At the minimum this should just be a default for the parameter on this define. https://github.com/openstack/puppet-swift/blob/master/manifests/storage/server.pp#L125 is where the user that the jobs run at is setup. So it is possible for a person to have a swift user created via init but the jobs run as something else.","commit_id":"218928887e68de760763be47252d30aedbc28229"},{"author":{"_account_id":18290,"name":"Kyrylo Galanov","email":"kgalanov@mirantis.com","username":"kgalanov"},"change_message_id":"c10bf8337b679d3a808f122b5af22b3923b4bc1a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  exec { \"create_${name}\":"},{"line_number":40,"context_line":"    command \u003d\u003e \"swift-ring-builder /etc/swift/${name}.builder create ${part_power} ${replicas} ${min_part_hours}\","},{"line_number":41,"context_line":"    path    \u003d\u003e [\u0027/usr/bin\u0027],"},{"line_number":42,"context_line":"    user    \u003d\u003e \u0027swift\u0027,"},{"line_number":43,"context_line":"    creates \u003d\u003e \"/etc/swift/${name}.builder\","},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_06d3b239","line":42,"in_reply_to":"7a740942_0acda865","updated":"2015-12-10 10:56:44.000000000","message":"It should be a separate refactoring task, because user \u0027swift\u0027 is hardcoded in other places, like https://github.com/openstack/puppet-swift/blob/master/manifests/init.pp#L57-L59","commit_id":"218928887e68de760763be47252d30aedbc28229"}]}