)]}'
{"lib/puppet/provider/service/swiftinit.rb":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"86d27a0e46d037c0b35344ac6fe74c387689d8e1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        if !current_contents.eql? systemd_template"},{"line_number":65,"context_line":"          current_conf.close"},{"line_number":66,"context_line":"          return :false"},{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"        if systemctl_run(\u0027is-enabled\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a710552_9c834856","line":65,"updated":"2015-12-16 10:48:44.000000000","message":"If the contents are not equal to the systemd_template, we are leaving the file open. I guess we could close if right after reading it.","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"cc0870033733324fdbd16855a26293e7311a86bd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        if !current_contents.eql? systemd_template"},{"line_number":65,"context_line":"          current_conf.close"},{"line_number":66,"context_line":"          return :false"},{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"        if systemctl_run(\u0027is-enabled\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a7e1126_6e834f05","line":65,"in_reply_to":"5a710552_8b2a177d","updated":"2015-12-17 22:46:23.000000000","message":"Done","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"be020216c739781231120d9295143b7620578620","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        if !current_contents.eql? systemd_template"},{"line_number":65,"context_line":"          current_conf.close"},{"line_number":66,"context_line":"          return :false"},{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"        if systemctl_run(\u0027is-enabled\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a710552_8b2a177d","line":65,"in_reply_to":"5a710552_9c834856","updated":"2015-12-16 12:34:32.000000000","message":"Agree.","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"cc0870033733324fdbd16855a26293e7311a86bd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        if !current_contents.eql? systemd_template"},{"line_number":65,"context_line":"          current_conf.close"},{"line_number":66,"context_line":"          return :false"},{"line_number":67,"context_line":"        end"},{"line_number":68,"context_line":"        if systemctl_run(\u0027is-enabled\u0027, [resource[:pattern]], false).exitstatus \u003d\u003d 0"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a7e1126_ce8cc337","line":65,"in_reply_to":"5a710552_9c834856","updated":"2015-12-17 22:46:23.000000000","message":"Done","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"86d27a0e46d037c0b35344ac6fe74c387689d8e1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      if Puppet::FileSystem.exist?(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":76,"context_line":"        current_conf \u003d File.open(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":77,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":78,"context_line":"        if current_contents.eql? upstart_template"},{"line_number":79,"context_line":"          current_conf.close"},{"line_number":80,"context_line":"          return :true"},{"line_number":81,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a710552_7c80dc46","line":78,"updated":"2015-12-16 10:48:44.000000000","message":"Same as above","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"cc0870033733324fdbd16855a26293e7311a86bd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      if Puppet::FileSystem.exist?(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":76,"context_line":"        current_conf \u003d File.open(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":77,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":78,"context_line":"        if current_contents.eql? upstart_template"},{"line_number":79,"context_line":"          current_conf.close"},{"line_number":80,"context_line":"          return :true"},{"line_number":81,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a7e1126_2e7ea719","line":78,"in_reply_to":"5a710552_7c80dc46","updated":"2015-12-17 22:46:23.000000000","message":"Done","commit_id":"9ebec5d0c340296ac728c023b81013f6f4748bf3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f8098e71e89d02145acd61136b57d481c24982e9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  def enabled?"},{"line_number":60,"context_line":"    if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":61,"context_line":"      if Puppet::FileSystem.exist?(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        current_conf.close"},{"line_number":65,"context_line":"        if !current_contents.eql? systemd_template"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a7e1126_ee941fe3","line":62,"updated":"2015-12-17 22:59:00.000000000","message":"I think you can just do File.read(...) instead of the open/read/close.  At least that\u0027s what the IO.read docs seem to indicate, http://ruby-doc.org/core-1.9.3/IO.html#method-i-read","commit_id":"cb1023ff51929f6149c9a3d70a13aa9dbe1e4519"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"51cff1033aaec2a1bf8bc7cc54c6e3bca7e1833f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  def enabled?"},{"line_number":60,"context_line":"    if Facter.value(:operatingsystem) !\u003d \u0027Ubuntu\u0027"},{"line_number":61,"context_line":"      if Puppet::FileSystem.exist?(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":62,"context_line":"        current_conf \u003d File.open(\"/etc/systemd/system/#{resource[:pattern]}.service\")"},{"line_number":63,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":64,"context_line":"        current_conf.close"},{"line_number":65,"context_line":"        if !current_contents.eql? systemd_template"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a7e1126_8283ea03","line":62,"in_reply_to":"3a7e1126_ee941fe3","updated":"2015-12-18 00:45:14.000000000","message":"Once I had it all stacked up like that I was wondering the same thing.  Thanks for the pointer.. much cleaner.","commit_id":"cb1023ff51929f6149c9a3d70a13aa9dbe1e4519"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f8098e71e89d02145acd61136b57d481c24982e9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":"    elsif Facter.value(:operatingsystem) \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":75,"context_line":"      if Puppet::FileSystem.exist?(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":76,"context_line":"        current_conf \u003d File.open(\"/etc/init/#{resource[:pattern]}.conf\")"},{"line_number":77,"context_line":"        current_contents \u003d current_conf.read"},{"line_number":78,"context_line":"        current_conf.close"},{"line_number":79,"context_line":"        if current_contents.eql? upstart_template"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a7e1126_6eb7cf86","line":76,"updated":"2015-12-17 22:59:00.000000000","message":"Same for here too","commit_id":"cb1023ff51929f6149c9a3d70a13aa9dbe1e4519"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f8098e71e89d02145acd61136b57d481c24982e9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          return :true"},{"line_number":81,"context_line":"        end"},{"line_number":82,"context_line":"      else"},{"line_number":83,"context_line":"          return :false"},{"line_number":84,"context_line":"      end"},{"line_number":85,"context_line":"    end"},{"line_number":86,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a7e1126_4e2213bb","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":10},"updated":"2015-12-17 22:59:00.000000000","message":"There\u0027s some extra space in here as well","commit_id":"cb1023ff51929f6149c9a3d70a13aa9dbe1e4519"}]}