)]}'
{"manifests/storage/server.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"16cffab9a476133e7c9ce1cdac38978d757ea511","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  concat { \"/etc/swift/${config_file_path}\":"},{"line_number":183,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":184,"context_line":"    group   \u003d\u003e $group,"},{"line_number":185,"context_line":"    notify  \u003d\u003e Service[\"swift-${type}-server\", \"swift-${type}-replicator\", \"swift-${type}-auditor\"],"},{"line_number":186,"context_line":"    require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa69d971_2e91c852","line":185,"updated":"2016-01-08 16:00:28.000000000","message":"isn\u0027t this redundant with the subscribe on the either end? don\u0027t you just need one of these?","commit_id":"2ffbf4527773f94425bde2e9df12a18fe95fef4c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a2a128124edc2d2d60bec49f803c6ded645b2fbb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  concat { \"/etc/swift/${config_file_path}\":"},{"line_number":183,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":184,"context_line":"    group   \u003d\u003e $group,"},{"line_number":185,"context_line":"    notify  \u003d\u003e Service[\"swift-${type}-server\", \"swift-${type}-replicator\", \"swift-${type}-auditor\"],"},{"line_number":186,"context_line":"    require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa69d971_da778600","line":185,"in_reply_to":"fa69d971_1a40bea4","updated":"2016-01-08 17:08:35.000000000","message":"Ah so many services names. Thanks for the clarification.","commit_id":"2ffbf4527773f94425bde2e9df12a18fe95fef4c"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"7372dcc7c65640aff2c752fdb097957a439e6082","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  concat { \"/etc/swift/${config_file_path}\":"},{"line_number":183,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":184,"context_line":"    group   \u003d\u003e $group,"},{"line_number":185,"context_line":"    notify  \u003d\u003e Service[\"swift-${type}-server\", \"swift-${type}-replicator\", \"swift-${type}-auditor\"],"},{"line_number":186,"context_line":"    require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa69d971_6e7020dd","line":185,"in_reply_to":"fa69d971_2e91c852","updated":"2016-01-08 16:09:08.000000000","message":"The subscribe in swift:storage:generic is on the package and not the config file.","commit_id":"2ffbf4527773f94425bde2e9df12a18fe95fef4c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4590843b9add1607732f5a84ca30846424ab6cbb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  concat { \"/etc/swift/${config_file_path}\":"},{"line_number":183,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":184,"context_line":"    group   \u003d\u003e $group,"},{"line_number":185,"context_line":"    notify  \u003d\u003e Service[\"swift-${type}-server\", \"swift-${type}-replicator\", \"swift-${type}-auditor\"],"},{"line_number":186,"context_line":"    require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa69d971_e962cad7","line":185,"in_reply_to":"fa69d971_6e7020dd","updated":"2016-01-08 16:15:13.000000000","message":"I meant the changes in the other files for this review.  You\u0027re adding a subscribe to swift::service { \u0027swift-{object,container,account}-XXXX\u0027...} items so wouldn\u0027t this be a duplication?  It\u0027s not hurting anything I was just wondering where the appropriate place to put the notify/subscribe is.","commit_id":"2ffbf4527773f94425bde2e9df12a18fe95fef4c"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"67a55621f73d96816a68ac6ca312862202e49636","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  concat { \"/etc/swift/${config_file_path}\":"},{"line_number":183,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":184,"context_line":"    group   \u003d\u003e $group,"},{"line_number":185,"context_line":"    notify  \u003d\u003e Service[\"swift-${type}-server\", \"swift-${type}-replicator\", \"swift-${type}-auditor\"],"},{"line_number":186,"context_line":"    require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa69d971_1a40bea4","line":185,"in_reply_to":"fa69d971_e962cad7","updated":"2016-01-08 17:06:50.000000000","message":"Those other services, such as \"swift-object-updater\" are independent services from the ones listed here.  swift-object-server being reloaded doesn\u0027t reload swift-object-updater.  A notification to swift-object-replicator won\u0027t notify swift-object-auditor for example.","commit_id":"2ffbf4527773f94425bde2e9df12a18fe95fef4c"}]}