)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f7da95d3a3da55bee9415ad225792b891d0b6ea1","unresolved":false,"context_lines":[{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  include ::swift::params"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($swift_hash_suffix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":68,"context_line":"    fail(\u0027You must specific swift_hash_path_suffix\u0027)"},{"line_number":69,"context_line":"  } elsif ($swift_hash_suffix !\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a68dd71_7b0270b6","line":66,"updated":"2016-01-26 15:11:28.000000000","message":"should we sanitize the hash with validate_hash function?","commit_id":"fe0421475b97c31316e4aa920dacc1b59a7a706e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7a608ccb663a4ad996133fd36b15450826bcd3c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  include ::swift::params"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($swift_hash_suffix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":68,"context_line":"    fail(\u0027You must specific swift_hash_path_suffix\u0027)"},{"line_number":69,"context_line":"  } elsif ($swift_hash_suffix !\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a68dd71_db691c27","line":66,"in_reply_to":"9a68dd71_7b0270b6","updated":"2016-01-26 15:19:50.000000000","message":"No because it\u0027s not actually a hash, it\u0027s a string used in hashing. http://docs.openstack.org/liberty/config-reference/content/swift-general-service-configuration.html","commit_id":"fe0421475b97c31316e4aa920dacc1b59a7a706e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f7da95d3a3da55bee9415ad225792b891d0b6ea1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  include ::swift::params"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($swift_hash_suffix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":68,"context_line":"    fail(\u0027You must specific swift_hash_path_suffix\u0027)"},{"line_number":69,"context_line":"  } elsif ($swift_hash_suffix !\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":70,"context_line":"    warning(\u0027swift_hash_suffix has been deprecated and should be replaced with swift_hash_path_suffix, this will be removed as part of the N-cycle\u0027)"},{"line_number":71,"context_line":"    $swift_hash_path_suffix_real \u003d $swift_hash_suffix"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a68dd71_9bff24aa","line":68,"updated":"2016-01-26 15:11:28.000000000","message":"specify?","commit_id":"fe0421475b97c31316e4aa920dacc1b59a7a706e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7a608ccb663a4ad996133fd36b15450826bcd3c9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  include ::swift::params"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  if ($swift_hash_suffix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":68,"context_line":"    fail(\u0027You must specific swift_hash_path_suffix\u0027)"},{"line_number":69,"context_line":"  } elsif ($swift_hash_suffix !\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":70,"context_line":"    warning(\u0027swift_hash_suffix has been deprecated and should be replaced with swift_hash_path_suffix, this will be removed as part of the N-cycle\u0027)"},{"line_number":71,"context_line":"    $swift_hash_path_suffix_real \u003d $swift_hash_suffix"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a68dd71_5bcbec1e","line":68,"in_reply_to":"9a68dd71_9bff24aa","updated":"2016-01-26 15:19:50.000000000","message":"Done","commit_id":"fe0421475b97c31316e4aa920dacc1b59a7a706e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9912e30ffc0271da152bf5e9dada5cbfc3420116","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  swift_config {"},{"line_number":112,"context_line":"    \u0027swift-hash/swift_hash_path_suffix\u0027: value \u003d\u003e $swift_hash_path_suffix_real;"},{"line_number":113,"context_line":"    \u0027swift-hash/swift_hash_path_prefix\u0027: value \u003d\u003e $swift_hash_path_prefix;"},{"line_number":114,"context_line":"    \u0027swift-constraints/max_header_size\u0027: value \u003d\u003e $max_header_size;"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_10656944","line":113,"range":{"start_line":113,"start_character":51,"end_line":113,"end_character":73},"updated":"2016-01-27 12:42:49.000000000","message":"This parameter has undef by default, do we need set it to absent in this case?","commit_id":"c41983cd87f9f6cea61e19945985962529dc5aac"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7036bd6a71ec0447cac5992f690fe6f89af2bd06","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  swift_config {"},{"line_number":112,"context_line":"    \u0027swift-hash/swift_hash_path_suffix\u0027: value \u003d\u003e $swift_hash_path_suffix_real;"},{"line_number":113,"context_line":"    \u0027swift-hash/swift_hash_path_prefix\u0027: value \u003d\u003e $swift_hash_path_prefix;"},{"line_number":114,"context_line":"    \u0027swift-constraints/max_header_size\u0027: value \u003d\u003e $max_header_size;"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_b4c1c930","line":113,"range":{"start_line":113,"start_character":51,"end_line":113,"end_character":73},"in_reply_to":"7a5de9d1_10656944","updated":"2016-01-27 23:11:55.000000000","message":"Technically I think you\u0027re supposed to define it as you should change it.  Undef in this case would just leave whatever is there alone so I don\u0027t think we want an absent in this case.  But since it\u0027s not currently defined and technically \u0027\u0027 is a valid setting as well we don\u0027t want to be removing it from configurations.","commit_id":"c41983cd87f9f6cea61e19945985962529dc5aac"}]}