)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"c42f07d5121529c90d2ead6b7ec4901f6f43df9e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Keystone endpoints should go before the service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This commit sets up a relationship in Class[swift::keystone::auth] so"},{"line_number":10,"context_line":"  at to guarantee that all endpoints are setup before launching any"},{"line_number":11,"context_line":"  swift services."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I95476d5a61787d5c27c46d9daa84f62911c24183"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_356ae3ee","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":4},"updated":"2016-04-06 13:46:42.000000000","message":"typo","commit_id":"28974700175e04a5f84cfd04b2ce1b33a0fd1315"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a8f78db0582a9294e535333c74caf5daf5ffd92f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  # Establish that keystone auth and endpoints are properly setup before"},{"line_number":286,"context_line":"  # manageing any type of swift related service."},{"line_number":287,"context_line":"  Class[\u0027::swift::keystone::auth\u0027] -\u003e Swift::Service\u003c||\u003e"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"  keystone::resource::service_identity { \u0027swift\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_cd496db9","line":286,"range":{"start_line":286,"start_character":4,"end_line":286,"end_character":13},"updated":"2016-04-06 10:04:40.000000000","message":"typo: managing","commit_id":"28974700175e04a5f84cfd04b2ce1b33a0fd1315"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a8f78db0582a9294e535333c74caf5daf5ffd92f","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  # Establish that keystone auth and endpoints are properly setup before"},{"line_number":286,"context_line":"  # manageing any type of swift related service."},{"line_number":287,"context_line":"  Class[\u0027::swift::keystone::auth\u0027] -\u003e Swift::Service\u003c||\u003e"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"  keystone::resource::service_identity { \u0027swift\u0027:"},{"line_number":290,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_0df52556","line":287,"range":{"start_line":287,"start_character":2,"end_line":287,"end_character":56},"updated":"2016-04-06 10:04:40.000000000","message":"why not do it like done for cinder?\n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/keystone/auth.pp","commit_id":"28974700175e04a5f84cfd04b2ce1b33a0fd1315"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"1fc57caf263bc69d3806ad61d57fb94b7b7f0d6a","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  # Establish that keystone auth and endpoints are properly setup before"},{"line_number":286,"context_line":"  # manageing any type of swift related service."},{"line_number":287,"context_line":"  Class[\u0027::swift::keystone::auth\u0027] -\u003e Swift::Service\u003c||\u003e"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"  keystone::resource::service_identity { \u0027swift\u0027:"},{"line_number":290,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_175510f9","line":287,"range":{"start_line":287,"start_character":2,"end_line":287,"end_character":56},"in_reply_to":"9a061dce_0df52556","updated":"2016-04-06 18:38:08.000000000","message":"For consistency I\u0027ll go ahead and change it but doing it this way is probably more of my preference.  It removes the need to know which resources are actually being defined from within the keystone::resource::service_identity defined resource type, which I think heavily reduces the benefit of the abstraction.","commit_id":"28974700175e04a5f84cfd04b2ce1b33a0fd1315"}]}